Commit Graph

919 Commits

Author SHA1 Message Date
Jorge Martin Espinosa
17f22d143b Add 'send private read receipts' option in advanced settings (#2290)
* Add 'send private read receipts' option in advanced settings
* Create `SessionPreferencesStore` that stores the settings for the current use separate from those of the app.
* Rename `PreferencesStore` to `AppPreferencesStore` to split the preferences.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-26 10:06:26 +01:00
Jorge Martin Espinosa
14fc747e80 Update timeline items read receipts when the room members are loaded (#2194)
* Update timeline items' sender info and read receipts when the room members info is loaded

* Only update this info if we have loaded the room members
2024-01-24 08:07:15 +01:00
Benoit Marty
30cea9c70a Always use the latest... fix. 2024-01-23 18:13:33 +01:00
Benoit Marty
cff076b508 Fix detekt issue:
Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.

If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect.

See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. [LambdaParameterInRestartableEffect]
2024-01-23 18:13:33 +01:00
Benoit Marty
7ed20f9aab Remove unnecessary parenthesis. 2024-01-23 14:27:06 +01:00
Benoit Marty
746719d961 @Suppress("LargeClass") for test. 2024-01-23 14:25:16 +01:00
Benoit Marty
f9aa178388 Fix complexity error by extracting condition to a val. 2024-01-23 14:24:40 +01:00
Benoit Marty
cdbfe8f92c Fix API break: use new methods canUserRedactOwn and canUserRedactOther. 2024-01-23 13:32:13 +01:00
Jorge Martin Espinosa
06439536a8 Edited text message bubbles should resize when edited (#2272)
* Make `ContentAvoidingLayoutScopeInstance` scope aware so message bubbles are resized when edited.

* Move back to using `Layout` instead of `SubcomposeLayout`
2024-01-22 17:53:10 +01:00
Benoit Marty
f42e220d55 Merge pull request #2130 from element-hq/feature/bma/roomListBadge
Some rework on the codebase
2024-01-22 10:17:38 +01:00
bmarty
d2a4c737a6 Sync Strings from Localazy 2024-01-22 00:10:44 +00:00
Benoit Marty
32dc7bca23 Merge pull request #2221 from element-hq/feature/bma/displayNameAmbiguous
Display name disambiguation
2024-01-19 17:42:32 +01:00
Jorge Martin Espinosa
ac3201b317 Remove some state events at the start of DMs (#2252)
* Remove some initial events for DMs
2024-01-19 17:34:27 +01:00
Benoit Marty
49abbfce7f Remove dead code. 2024-01-19 16:46:42 +01:00
Benoit Marty
371aec4427 Remove RoomSummaryDetails.lastMessageTimestamp and replace by a getter on lastMessage 2024-01-19 16:11:10 +01:00
Benoit Marty
603b10264b Rename avatarURLString to avatarUrl 2024-01-19 15:58:37 +01:00
Benoit Marty
47a5c74129 Rename aRoomSummaryDetail to aRoomSummaryDetails 2024-01-19 15:55:26 +01:00
Jorge Martin Espinosa
64a18afc1b Replace 'leave room' text with 'leave conversation' for DMs (#2231)
* Replace 'leave room' text with 'leave conversation' for DMs

* Add `isDm` property to both `RoomSummary` and `RoomListRoomSummary`

* Remove redundant `leave_conversation_alert_subtitle_*` texts

* Fix maestro flow

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-16 15:49:44 +01:00
ElementBot
3a37460814 Sync Strings (#2230)
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
2024-01-15 09:21:04 +01:00
Benoit Marty
3f7e641c2f Display name disambiguation #2215.
Applied to:
- timeline message
- detail of timeline message
- reply preview of timeline message
- rendering of state Event
Not applied to:
- room last message
- room member list (we display the MatrixId here)
- room member detail page
2024-01-12 15:58:33 +01:00
Benoit Marty
d76ee23514 Merge pull request #2202 from element-hq/feature/bma/removeReadReceiptFlag
Remove ReadReceipts feature flag.
2024-01-11 17:13:35 +01:00
Benoit Marty
439c2f191b Ensure preview are not impacted when removing the ReadReceipt feature flag. 2024-01-11 15:58:36 +01:00
Benoit Marty
4dcafb6aa6 Remove ReadReceipts feature flag. 2024-01-11 15:57:59 +01:00
Benoit Marty
72a363c244 Fix moar ktlint issues 2024-01-11 11:24:10 +01:00
Benoit Marty
378692f743 Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
Benoit Marty
d3830af78b Fix ktlint issues 2024-01-10 19:33:39 +01:00
renovate[bot]
7e9cda3aa9 Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Jorge Martin Espinosa
e762584a37 Improve rendering of voice messages in the timeline in large displays (#2199)
* Improve rendering of voice messages in the timeline in large displays

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-09 18:07:23 +01:00
Benoit Marty
ae424ffe6a Merge pull request #1782 from element-hq/feature/bma/upgradeKover
Upgrade kover
2024-01-09 17:52:14 +01:00
Jorge Martin Espinosa
7008b403c0 Fix mention selector getting stuck when quickly deleting the prompt (#2195)
* Fix mention selector getting stuck when quickly deleting the prompt
2024-01-09 11:07:10 +00:00
Benoit Marty
b377da22ad Remove empty test module 2024-01-09 10:45:36 +01:00
Jorge Martin Espinosa
3954612a72 Hide keyboard when tapping on a message in the timeline (#2187)
* Hide keyboard when tapping on a message in the timeline if it would result in navigating to another screen
2024-01-08 14:02:57 +01:00
Benoit Marty
a424cb0a6a exclude items.count(), which is not a valid index for the list. 2024-01-08 11:41:29 +01:00
Benoit Marty
66201c6e58 Do not use sublist as it crashes if index > items.count(). Using range is safer.
Fix https://github.com/element-hq/element-x-android-rageshakes/issues/1301
2024-01-08 11:26:50 +01:00
Benoit Marty
cbc86ea1e4 Merge branch 'develop' into feature/bma/sendImageFromKeyboard 2024-01-08 08:59:00 +01:00
bmarty
06db67abe8 Sync Strings from Localazy 2024-01-08 00:10:36 +00:00
Jorge Martin Espinosa
00c27ffafc Use SubcomposeLayout for ContentAvoidingLayout (#2171)
Use `SubcomposeLayout` for `ContentAvoidingLayout`
2024-01-05 12:40:25 +00:00
Jorge Martin Espinosa
0e3f0ac6b5 Trim whitespace at the end of messages (#2169)
Trim whitespace at the end of messages
2024-01-05 12:40:10 +01:00
Jorge Martin Espinosa
936127c682 Fix crashes for extremely long messages with no line breaks (#2163) 2024-01-05 11:11:49 +00:00
Benoit Marty
24a3c2baf7 Merge pull request #2166 from element-hq/feature/bma/fixFlakyTest
Introduce AsyncAction with a Confirmation state and use it for logout action
2024-01-05 10:30:43 +01:00
Benoit Marty
1dc6e5edb3 Clean up 2024-01-04 18:45:34 +01:00
Benoit Marty
d78ce21939 Rename AsyncView to AsyncActionView 2024-01-04 17:50:52 +01:00
Benoit Marty
bd91dd64e2 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
Benoit Marty
676ec90c22 Merge pull request #2160 from surakin/msc4027
Implement MSC4027 (Custom images in reactions)
2024-01-04 16:23:30 +01:00
Benoit Marty
9838092ca2 Merge pull request #2162 from surakin/do-not-forward-stickers
Disable forwarding for stickers (until it can be properly fixed)
2024-01-04 16:17:20 +01:00
Jorge Martin Espinosa
1e2fc6ad27 Remove 'document' case for message with timestamp preview (#2164)
* Remove 'document' case for message with timestamp preview

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-04 15:22:09 +01:00
Marco Antonio Alvarez
fb743a98a3 add comment about sticker forwarding being disabled
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
2024-01-04 13:57:16 +01:00
Marco Antonio Alvarez
42d0bf0339 Disable forwarding for stickers (until it can be properly fixed)
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
2024-01-04 13:04:56 +01:00
Marco Antonio Alvarez
5eceab15b6 use different heights for reaction summary view and reaction buttons
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
2024-01-04 10:53:53 +01:00
Marco Antonio Alvarez
8f48e11201 Merge branch 'develop' into msc4027 2024-01-04 09:42:23 +01:00