letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity
5,714 Commits 1 Branch 0 Tags
21d6ea1dbbc4e19a4746532e53ea160078cea950
Commit Graph

97 Commits

Author SHA1 Message Date
Benoit Marty
72b89338b3 Remove Modifier parameter in private function when only default value is used. 
This will improve the code coverage metrics, and this also fixes a few potential bug, where the Modifier was used several times.
 2024-02-08 11:06:06 +01:00
bmarty
7911a26003 Sync Strings from Localazy 2024-02-05 00:09:59 +00:00
Benoit Marty
cff076b508 Fix detekt issue: 
Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.

If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect.

See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. [LambdaParameterInRestartableEffect]
 2024-01-23 18:13:33 +01:00
ElementBot
3a37460814 Sync Strings (#2230) 
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
 2024-01-15 09:21:04 +01:00
Benoit Marty
378692f743 Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
renovate[bot]
7e9cda3aa9 Update plugin ktlint to v12.1.0 (#2200) 
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2024-01-10 16:22:24 +01:00
bmarty
06db67abe8 Sync Strings from Localazy 2024-01-08 00:10:36 +00:00
Benoit Marty
bd91dd64e2 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
bmarty
ada357b344 Sync Strings from Localazy 2023-12-26 09:39:48 +01:00
ganfra
7d33409810 Merge pull request #2059 from element-hq/feature/fga/appyx_overlay 
Appyx Overlay
 2023-12-20 11:17:23 +01:00
ganfra
9f045fc7de Fix detekt 2023-12-19 12:59:13 +01:00
ganfra
280d55bd6e BackstackParentNode now become BaseFlowNode and adds Overlay navModel into it. 2023-12-19 12:55:14 +01:00
bmarty
96dd875f3d Sync Strings from Localazy 2023-12-18 00:10:14 +00:00
Benoit Marty
d31909e049 Sync localazy using fixed script 2023-12-08 19:24:35 +01:00
Benoit Marty
ef5927d0bc Merge pull request #1952 from vector-im/sync-localazy 
Sync Strings
 2023-12-05 13:47:44 +01:00
Benoit Marty
b43ddd36b9 Run the script again. 2023-12-05 12:25:59 +01:00
Benoit Marty
7c58a843dc Add Konsist test to use isTrue() instead of isEqualTo(true), and fix existing issues. 2023-12-04 15:23:36 +01:00
Benoit Marty
65924eac6b Add Konsist test to use isFalse() instead of isEqualTo(false), and fix existing issues. 2023-12-04 15:21:50 +01:00
bmarty
ad2ca01094 Sync Strings from Localazy 2023-12-04 00:09:56 +00:00
Jorge Martin Espinosa
a8b85fb4e6 Extract compound tokens and theming to compound-android library (#1888) 
* Replace tokens & icons with the external Compound ones

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2023-11-27 10:30:07 +01:00
Benoit Marty
5f8e85edc6 Prevent usage of hard-coded string for contentDescription, and fix existing issues. 2023-11-21 15:38:21 +01:00
ElementBot
38f1d9932b Sync Strings (#1789) 
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
 2023-11-13 12:31:34 +01:00
ganfra
4d48005f3d Merge pull request #1757 from vector-im/feature/fga/lock_polish 
LockScreen polish
 2023-11-08 14:02:53 +01:00
ganfra
a5e23431a7 Lock screen : fix one more test. 2023-11-08 13:45:28 +01:00
ganfra
dc2e05430b Lockscreen : should fix tests 2023-11-08 12:01:54 +01:00
ganfra
39da7e75a5 Lock screen : fix code quality 2023-11-07 21:08:02 +01:00
ganfra
8b4d3a4bc8 Lock : fix race condition on setup pin 2023-11-07 21:06:26 +01:00
ganfra
41517614c8 LockScreen : fix one more navigation issue 2023-11-07 18:22:40 +01:00
ganfra
a5e098dd1f LockScreen : reduce delay before validation step in setup 2023-11-07 16:30:25 +01:00
ganfra
43d4f96a9f LockScreen : do not show the entire setup flow when changing the pin is settings 2023-11-07 16:23:41 +01:00
ganfra
f10231091d LockScreen : refact some code and add secureFlag 2023-11-07 15:55:53 +01:00
Benoit Marty
0e918e9db8 Use ButtonColumnMolecule 2023-11-07 10:53:21 +01:00
bmarty
6014858aba Sync Strings from Localazy 2023-11-06 08:23:40 +00:00
Benoit Marty
8b85aa51e2 Konsist: check that if sealed interface is used in parameter of Composable, it has the @Stable or @Immutable annotation 2023-11-03 15:19:55 +01:00
ganfra
564c2aa23e Pin unlock : implement design for in-app unlock 2023-10-31 20:12:45 +01:00
ganfra
8d903362c8 Feature/fga/biometric unlock (#1702) 
* Biometric unlock : refactor a bit existing classes

* Biometric unlock : first implementation

* Biometric: add ui for biometric setup

* Biometric unlock : use localazy strings

* Biometric unlock setup : branch skip/allow events

* Biometric : fix tests

* Biometrics: add small test

* Biometric : clean up

* Update screenshots

* Biometric unlock : address some PR review

* Biometric : improve a bit edge cases

* Fix lint issues

---------

Co-authored-by: ganfra <francoisg@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
Co-authored-by: Jorge Martín <jorgem@element.io>
 2023-10-31 19:22:43 +01:00
bmarty
340a4b5b4f Sync Strings from Localazy 2023-10-30 14:50:36 +00:00
bmarty
458e2a1b58 Sync Strings from Localazy 2023-10-30 00:10:04 +00:00
Benoit Marty
b5ffa6eef3 SecureBackup: update matrix sdk module. 2023-10-26 18:02:34 +02:00
ganfra
4b36eb0374 PIN: address PR review 2023-10-26 15:28:18 +02:00
ganfra
b8ce848a0c PIN : fix quality 2023-10-26 15:25:40 +02:00
ganfra
bd9179dd45 PIN : Fix SetupPinPresenterTest 2023-10-26 14:39:13 +02:00
ganfra
a34604512d Pin: add tests and make LockScreenConfig an injectable data class 2023-10-25 18:39:39 +02:00
ganfra
b135670196 Pin : clean remaining pin code attempts 2023-10-25 16:54:34 +02:00
ganfra
1d314e198a PIN: clean pin code storage 2023-10-25 16:45:42 +02:00
ganfra
ed4815c40a PIN: fix and add tests 2023-10-25 16:13:30 +02:00
ganfra
432e209618 PIN unlock : makes sure to load the pin size from storage 2023-10-25 15:07:05 +02:00
ganfra
d59eaab7a8 PIN: add callback on LockScreenEntryPoint 2023-10-25 11:27:19 +02:00
ganfra
f105455bd6 PIN: branch SignOut 2023-10-25 11:15:15 +02:00
ganfra
3e60773166 PIN : branch the mandatory flow 2023-10-24 18:13:41 +02:00