Add Konsist test to use isFalse() instead of isEqualTo(false), and fix existing issues.

This commit is contained in:
Benoit Marty
2023-12-04 15:21:25 +01:00
parent 45883975c4
commit 65924eac6b
9 changed files with 85 additions and 73 deletions

View File

@@ -132,14 +132,14 @@ class SendLocationPresenterTest {
val initialState = awaitItem()
assertThat(initialState.permissionDialog).isEqualTo(SendLocationState.Dialog.None)
assertThat(initialState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(initialState.hasLocationPermission).isEqualTo(false)
assertThat(initialState.hasLocationPermission).isFalse()
// Click on the button to switch mode
initialState.eventSink(SendLocationEvents.SwitchToMyLocationMode)
val myLocationState = awaitItem()
assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionDenied)
assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(myLocationState.hasLocationPermission).isEqualTo(false)
assertThat(myLocationState.hasLocationPermission).isFalse()
}
}
@@ -158,14 +158,14 @@ class SendLocationPresenterTest {
val initialState = awaitItem()
assertThat(initialState.permissionDialog).isEqualTo(SendLocationState.Dialog.None)
assertThat(initialState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(initialState.hasLocationPermission).isEqualTo(false)
assertThat(initialState.hasLocationPermission).isFalse()
// Click on the button to switch mode
initialState.eventSink(SendLocationEvents.SwitchToMyLocationMode)
val myLocationState = awaitItem()
assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionRationale)
assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(myLocationState.hasLocationPermission).isEqualTo(false)
assertThat(myLocationState.hasLocationPermission).isFalse()
}
}
@@ -189,14 +189,14 @@ class SendLocationPresenterTest {
val myLocationState = awaitItem()
assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionRationale)
assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(myLocationState.hasLocationPermission).isEqualTo(false)
assertThat(myLocationState.hasLocationPermission).isFalse()
// Dismiss the dialog
myLocationState.eventSink(SendLocationEvents.DismissDialog)
val dialogDismissedState = awaitItem()
assertThat(dialogDismissedState.permissionDialog).isEqualTo(SendLocationState.Dialog.None)
assertThat(dialogDismissedState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false)
assertThat(dialogDismissedState.hasLocationPermission).isFalse()
}
}
@@ -220,7 +220,7 @@ class SendLocationPresenterTest {
val myLocationState = awaitItem()
assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionRationale)
assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(myLocationState.hasLocationPermission).isEqualTo(false)
assertThat(myLocationState.hasLocationPermission).isFalse()
// Continue the dialog sends permission request to the permissions presenter
myLocationState.eventSink(SendLocationEvents.RequestPermissions)
@@ -248,14 +248,14 @@ class SendLocationPresenterTest {
val myLocationState = awaitItem()
assertThat(myLocationState.permissionDialog).isEqualTo(SendLocationState.Dialog.PermissionDenied)
assertThat(myLocationState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(myLocationState.hasLocationPermission).isEqualTo(false)
assertThat(myLocationState.hasLocationPermission).isFalse()
// Dismiss the dialog
myLocationState.eventSink(SendLocationEvents.DismissDialog)
val dialogDismissedState = awaitItem()
assertThat(dialogDismissedState.permissionDialog).isEqualTo(SendLocationState.Dialog.None)
assertThat(dialogDismissedState.mode).isEqualTo(SendLocationState.Mode.PinLocation)
assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false)
assertThat(dialogDismissedState.hasLocationPermission).isFalse()
}
}

View File

@@ -68,8 +68,8 @@ class ShowLocationPresenterTest {
val initialState = awaitItem()
assertThat(initialState.location).isEqualTo(location)
assertThat(initialState.description).isEqualTo(A_DESCRIPTION)
assertThat(initialState.hasLocationPermission).isEqualTo(false)
assertThat(initialState.isTrackMyLocation).isEqualTo(false)
assertThat(initialState.hasLocationPermission).isFalse()
assertThat(initialState.isTrackMyLocation).isFalse()
}
}
@@ -88,8 +88,8 @@ class ShowLocationPresenterTest {
val initialState = awaitItem()
assertThat(initialState.location).isEqualTo(location)
assertThat(initialState.description).isEqualTo(A_DESCRIPTION)
assertThat(initialState.hasLocationPermission).isEqualTo(false)
assertThat(initialState.isTrackMyLocation).isEqualTo(false)
assertThat(initialState.hasLocationPermission).isFalse()
assertThat(initialState.isTrackMyLocation).isFalse()
}
}
@@ -104,7 +104,7 @@ class ShowLocationPresenterTest {
assertThat(initialState.location).isEqualTo(location)
assertThat(initialState.description).isEqualTo(A_DESCRIPTION)
assertThat(initialState.hasLocationPermission).isEqualTo(true)
assertThat(initialState.isTrackMyLocation).isEqualTo(false)
assertThat(initialState.isTrackMyLocation).isFalse()
}
}
@@ -119,7 +119,7 @@ class ShowLocationPresenterTest {
assertThat(initialState.location).isEqualTo(location)
assertThat(initialState.description).isEqualTo(A_DESCRIPTION)
assertThat(initialState.hasLocationPermission).isEqualTo(true)
assertThat(initialState.isTrackMyLocation).isEqualTo(false)
assertThat(initialState.isTrackMyLocation).isFalse()
}
}
@@ -145,7 +145,7 @@ class ShowLocationPresenterTest {
}.test {
val initialState = awaitItem()
assertThat(initialState.hasLocationPermission).isEqualTo(true)
assertThat(initialState.isTrackMyLocation).isEqualTo(false)
assertThat(initialState.isTrackMyLocation).isFalse()
initialState.eventSink(ShowLocationEvents.TrackMyLocation(true))
val trackMyLocationState = awaitItem()
@@ -159,7 +159,7 @@ class ShowLocationPresenterTest {
initialState.eventSink(ShowLocationEvents.TrackMyLocation(false))
val trackLocationDisabledState = awaitItem()
assertThat(trackLocationDisabledState.permissionDialog).isEqualTo(ShowLocationState.Dialog.None)
assertThat(trackLocationDisabledState.isTrackMyLocation).isEqualTo(false)
assertThat(trackLocationDisabledState.isTrackMyLocation).isFalse()
assertThat(trackLocationDisabledState.hasLocationPermission).isEqualTo(true)
}
}
@@ -183,15 +183,15 @@ class ShowLocationPresenterTest {
initialState.eventSink(ShowLocationEvents.TrackMyLocation(true))
val trackLocationState = awaitItem()
assertThat(trackLocationState.permissionDialog).isEqualTo(ShowLocationState.Dialog.PermissionRationale)
assertThat(trackLocationState.isTrackMyLocation).isEqualTo(false)
assertThat(trackLocationState.hasLocationPermission).isEqualTo(false)
assertThat(trackLocationState.isTrackMyLocation).isFalse()
assertThat(trackLocationState.hasLocationPermission).isFalse()
// Dismiss the dialog
initialState.eventSink(ShowLocationEvents.DismissDialog)
val dialogDismissedState = awaitItem()
assertThat(dialogDismissedState.permissionDialog).isEqualTo(ShowLocationState.Dialog.None)
assertThat(dialogDismissedState.isTrackMyLocation).isEqualTo(false)
assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false)
assertThat(dialogDismissedState.isTrackMyLocation).isFalse()
assertThat(dialogDismissedState.hasLocationPermission).isFalse()
}
}
@@ -214,8 +214,8 @@ class ShowLocationPresenterTest {
initialState.eventSink(ShowLocationEvents.TrackMyLocation(true))
val trackLocationState = awaitItem()
assertThat(trackLocationState.permissionDialog).isEqualTo(ShowLocationState.Dialog.PermissionRationale)
assertThat(trackLocationState.isTrackMyLocation).isEqualTo(false)
assertThat(trackLocationState.hasLocationPermission).isEqualTo(false)
assertThat(trackLocationState.isTrackMyLocation).isFalse()
assertThat(trackLocationState.hasLocationPermission).isFalse()
// Continue the dialog sends permission request to the permissions presenter
trackLocationState.eventSink(ShowLocationEvents.RequestPermissions)
@@ -242,15 +242,15 @@ class ShowLocationPresenterTest {
initialState.eventSink(ShowLocationEvents.TrackMyLocation(true))
val trackLocationState = awaitItem()
assertThat(trackLocationState.permissionDialog).isEqualTo(ShowLocationState.Dialog.PermissionDenied)
assertThat(trackLocationState.isTrackMyLocation).isEqualTo(false)
assertThat(trackLocationState.hasLocationPermission).isEqualTo(false)
assertThat(trackLocationState.isTrackMyLocation).isFalse()
assertThat(trackLocationState.hasLocationPermission).isFalse()
// Dismiss the dialog
initialState.eventSink(ShowLocationEvents.DismissDialog)
val dialogDismissedState = awaitItem()
assertThat(dialogDismissedState.permissionDialog).isEqualTo(ShowLocationState.Dialog.None)
assertThat(dialogDismissedState.isTrackMyLocation).isEqualTo(false)
assertThat(dialogDismissedState.hasLocationPermission).isEqualTo(false)
assertThat(dialogDismissedState.isTrackMyLocation).isFalse()
assertThat(dialogDismissedState.hasLocationPermission).isFalse()
}
}

View File

@@ -95,7 +95,7 @@ class PinUnlockPresenterTest {
awaitLastSequentialItem().also { state ->
assertThat(state.remainingAttempts.dataOrNull()).isEqualTo(0)
assertThat(state.showSignOutPrompt).isEqualTo(true)
assertThat(state.isSignOutPromptCancellable).isEqualTo(false)
assertThat(state.isSignOutPromptCancellable).isFalse()
}
}
}
@@ -117,7 +117,7 @@ class PinUnlockPresenterTest {
state.eventSink(PinUnlockEvents.ClearSignOutPrompt)
}
awaitLastSequentialItem().also { state ->
assertThat(state.showSignOutPrompt).isEqualTo(false)
assertThat(state.showSignOutPrompt).isFalse()
state.eventSink(PinUnlockEvents.OnForgetPin)
}
awaitLastSequentialItem().also { state ->

View File

@@ -379,7 +379,7 @@ class MessageComposerPresenterTest {
}.test {
skipItems(1)
val initialState = awaitItem()
assertThat(initialState.showAttachmentSourcePicker).isEqualTo(false)
assertThat(initialState.showAttachmentSourcePicker).isFalse()
initialState.eventSink(MessageComposerEvents.AddAttachment)
assertThat(awaitItem().showAttachmentSourcePicker).isEqualTo(true)
}

View File

@@ -100,8 +100,8 @@ class DefaultVoiceMessagePlayerTest {
matchReadyState(fakeTotalDurationMs = 1000)
player.play()
awaitItem().let {
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isEqualTo(true)
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
@@ -125,8 +125,8 @@ class DefaultVoiceMessagePlayerTest {
matchReadyState(1_000L)
player1.play()
awaitItem().let { // it plays until the end.
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isEqualTo(true)
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
@@ -138,24 +138,24 @@ class DefaultVoiceMessagePlayerTest {
matchInitialState()
assertThat(player2.prepare().isSuccess).isTrue()
awaitItem().let { // Additional spurious state due to MediaPlayer owner change.
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isEqualTo(true)
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
}
awaitItem().let {// Additional spurious state due to MediaPlayer owner change.
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(null)
}
matchReadyState(1_000L)
player2.play()
awaitItem().let { // it plays until the end.
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isEqualTo(true)
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
@@ -165,25 +165,25 @@ class DefaultVoiceMessagePlayerTest {
// Play player1 again.
player1.state.test {
awaitItem().let {// Last previous state/
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isEqualTo(true)
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
}
assertThat(player1.prepare().isSuccess).isTrue()
awaitItem().let {// Additional spurious state due to MediaPlayer owner change.
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(null)
}
matchReadyState(1_000L)
player1.play()
awaitItem().let { // it played again until the end.
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isEqualTo(true)
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
@@ -202,7 +202,7 @@ class DefaultVoiceMessagePlayerTest {
skipItems(1) // skip play state
player.pause()
awaitItem().let {
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isPlaying).isFalse()
assertThat(it.currentPosition).isEqualTo(1000)
}
}
@@ -234,17 +234,17 @@ class DefaultVoiceMessagePlayerTest {
matchInitialState()
player.seekTo(2000)
awaitItem().let {
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(2000)
assertThat(it.duration).isEqualTo(null)
}
assertThat(player.prepare().isSuccess).isTrue()
awaitItem().let {
assertThat(it.isReady).isEqualTo(true)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(2000)
assertThat(it.duration).isEqualTo(FAKE_TOTAL_DURATION_MS)
}
@@ -261,8 +261,8 @@ class DefaultVoiceMessagePlayerTest {
player.seekTo(2000)
awaitItem().let {
assertThat(it.isReady).isEqualTo(true)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(2000)
assertThat(it.duration).isEqualTo(FAKE_TOTAL_DURATION_MS)
}
@@ -296,9 +296,9 @@ private const val MXC_URI = "mxc://matrix.org/1234567890abcdefg"
private suspend fun TurbineTestContext<VoiceMessagePlayer.State>.matchInitialState() {
awaitItem().let {
assertThat(it.isReady).isEqualTo(false)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(null)
}
@@ -309,8 +309,8 @@ private suspend fun TurbineTestContext<VoiceMessagePlayer.State>.matchReadyState
) {
awaitItem().let {
assertThat(it.isReady).isEqualTo(true)
assertThat(it.isPlaying).isEqualTo(false)
assertThat(it.isEnded).isEqualTo(false)
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(fakeTotalDurationMs)
}

View File

@@ -74,7 +74,7 @@ class PreferencesRootPresenterTest {
)
)
assertThat(loadedState.showDeveloperSettings).isEqualTo(true)
assertThat(loadedState.showAnalyticsSettings).isEqualTo(false)
assertThat(loadedState.showAnalyticsSettings).isFalse()
assertThat(loadedState.accountManagementUrl).isNull()
assertThat(loadedState.devicesManagementUrl).isNull()
}

View File

@@ -107,7 +107,7 @@ class RoomDetailsEditPresenterTest {
AvatarAction.TakePhoto,
AvatarAction.Remove
)
assertThat(initialState.saveButtonEnabled).isEqualTo(false)
assertThat(initialState.saveButtonEnabled).isFalse()
assertThat(initialState.saveAction).isInstanceOf(Async.Uninitialized::class.java)
}
}
@@ -299,7 +299,7 @@ class RoomDetailsEditPresenterTest {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.saveButtonEnabled).isEqualTo(false)
assertThat(initialState.saveButtonEnabled).isFalse()
// Once a change is made, the save button is enabled
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name II"))
@@ -310,7 +310,7 @@ class RoomDetailsEditPresenterTest {
// If it's reverted then the save disables again
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name"))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@@ -322,7 +322,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomTopic("My topic"))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@@ -334,7 +334,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.HandleAvatarAction(AvatarAction.ChoosePhoto))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
}
}
@@ -351,7 +351,7 @@ class RoomDetailsEditPresenterTest {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.saveButtonEnabled).isEqualTo(false)
assertThat(initialState.saveButtonEnabled).isFalse()
// Once a change is made, the save button is enabled
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name II"))
@@ -362,7 +362,7 @@ class RoomDetailsEditPresenterTest {
// If it's reverted then the save disables again
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("fallback"))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@@ -374,7 +374,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomTopic(""))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@@ -386,7 +386,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.HandleAvatarAction(AvatarAction.Remove))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
}
}

View File

@@ -37,7 +37,7 @@ class DefaultFeatureFlagServiceTest {
fun `given service without provider when set enabled feature is called then it returns false`() = runTest {
val featureFlagService = DefaultFeatureFlagService(emptySet())
val result = featureFlagService.setFeatureEnabled(FeatureFlags.LocationSharing, true)
assertThat(result).isEqualTo(false)
assertThat(result).isFalse()
}
@Test
@@ -56,7 +56,7 @@ class DefaultFeatureFlagServiceTest {
featureFlagService.isFeatureEnabledFlow(FeatureFlags.LocationSharing).test {
assertThat(awaitItem()).isEqualTo(true)
featureFlagService.setFeatureEnabled(FeatureFlags.LocationSharing, false)
assertThat(awaitItem()).isEqualTo(false)
assertThat(awaitItem()).isFalse()
}
}

View File

@@ -62,4 +62,16 @@ class KonsistTestTest {
functionDeclaration.text.contains("Truth.")
}
}
@Test
fun `use isFalse() instead of isEqualTo(false)`() {
Konsist
.scopeFromTest()
.functions()
// Exclude self
.withoutName("use isFalse() instead of isEqualTo(false)")
.assertFalse { functionDeclaration ->
functionDeclaration.text.contains("isEqualTo(false)")
}
}
}