Remove unused lambda parameter. The link is opened by the LocalUriHandler now.
This commit is contained in:
@@ -37,7 +37,6 @@ import io.element.android.libraries.ui.strings.CommonStrings
|
||||
fun AnalyticsPreferencesView(
|
||||
state: AnalyticsPreferencesState,
|
||||
modifier: Modifier = Modifier,
|
||||
onOpenAnalyticsPolicy: (url: String) -> Unit,
|
||||
) {
|
||||
fun onEnabledChanged(isEnabled: Boolean) {
|
||||
state.eventSink(AnalyticsOptInEvents.EnableAnalytics(isEnabled = isEnabled))
|
||||
@@ -90,6 +89,5 @@ internal fun AnalyticsPreferencesViewDarkPreview(@PreviewParameter(AnalyticsPref
|
||||
private fun ContentToPreview(state: AnalyticsPreferencesState) {
|
||||
AnalyticsPreferencesView(
|
||||
state = state,
|
||||
onOpenAnalyticsPolicy = {},
|
||||
)
|
||||
}
|
||||
|
||||
@@ -16,19 +16,15 @@
|
||||
|
||||
package io.element.android.features.preferences.impl.analytics
|
||||
|
||||
import android.app.Activity
|
||||
import androidx.compose.runtime.Composable
|
||||
import androidx.compose.ui.Modifier
|
||||
import androidx.compose.ui.platform.LocalContext
|
||||
import com.bumble.appyx.core.modality.BuildContext
|
||||
import com.bumble.appyx.core.node.Node
|
||||
import com.bumble.appyx.core.plugin.Plugin
|
||||
import dagger.assisted.Assisted
|
||||
import dagger.assisted.AssistedInject
|
||||
import io.element.android.anvilannotations.ContributesNode
|
||||
import io.element.android.libraries.androidutils.browser.openUrlInChromeCustomTab
|
||||
import io.element.android.libraries.di.SessionScope
|
||||
import io.element.android.libraries.theme.ElementTheme
|
||||
|
||||
@ContributesNode(SessionScope::class)
|
||||
class AnalyticsSettingsNode @AssistedInject constructor(
|
||||
@@ -37,19 +33,12 @@ class AnalyticsSettingsNode @AssistedInject constructor(
|
||||
private val presenter: AnalyticsSettingsPresenter,
|
||||
) : Node(buildContext, plugins = plugins) {
|
||||
|
||||
private fun onOpenAnalyticsPolicy(activity: Activity, darkTheme: Boolean, url: String) {
|
||||
activity.openUrlInChromeCustomTab(null, darkTheme, url)
|
||||
}
|
||||
|
||||
@Composable
|
||||
override fun View(modifier: Modifier) {
|
||||
val activity = LocalContext.current as Activity
|
||||
val isDark = ElementTheme.colors.isLight.not()
|
||||
val state = presenter.present()
|
||||
AnalyticsSettingsView(
|
||||
state = state,
|
||||
onBackPressed = ::navigateUp,
|
||||
onOpenAnalyticsPolicy = { onOpenAnalyticsPolicy(activity, darkTheme = isDark, it) },
|
||||
modifier = modifier
|
||||
)
|
||||
}
|
||||
|
||||
@@ -31,7 +31,6 @@ import io.element.android.libraries.ui.strings.CommonStrings
|
||||
fun AnalyticsSettingsView(
|
||||
state: AnalyticsSettingsState,
|
||||
onBackPressed: () -> Unit,
|
||||
onOpenAnalyticsPolicy: (url: String) -> Unit,
|
||||
modifier: Modifier = Modifier,
|
||||
) {
|
||||
PreferenceView(
|
||||
@@ -41,7 +40,6 @@ fun AnalyticsSettingsView(
|
||||
) {
|
||||
AnalyticsPreferencesView(
|
||||
state = state.analyticsState,
|
||||
onOpenAnalyticsPolicy = onOpenAnalyticsPolicy,
|
||||
)
|
||||
}
|
||||
}
|
||||
@@ -61,6 +59,5 @@ private fun ContentToPreview(state: AnalyticsSettingsState) {
|
||||
AnalyticsSettingsView(
|
||||
state = state,
|
||||
onBackPressed = {},
|
||||
onOpenAnalyticsPolicy = {},
|
||||
)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user