From c88b087feb16ae42c050d236c18cb2c145ba1be6 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Wed, 30 Aug 2023 10:21:27 +0200
Subject: [PATCH] Remove unused lambda parameter. The link is opened by the
 LocalUriHandler now.

---
 .../api/preferences/AnalyticsPreferencesView.kt       |  2 --
 .../impl/analytics/AnalyticsSettingsNode.kt           | 11 -----------
 .../impl/analytics/AnalyticsSettingsView.kt           |  3 ---
 3 files changed, 16 deletions(-)

diff --git a/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt b/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt
index 2b70798cbd..468babcc6f 100644
--- a/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt
+++ b/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt
@@ -37,7 +37,6 @@ import io.element.android.libraries.ui.strings.CommonStrings
 fun AnalyticsPreferencesView(
     state: AnalyticsPreferencesState,
     modifier: Modifier = Modifier,
-    onOpenAnalyticsPolicy: (url: String) -> Unit,
 ) {
     fun onEnabledChanged(isEnabled: Boolean) {
         state.eventSink(AnalyticsOptInEvents.EnableAnalytics(isEnabled = isEnabled))
@@ -90,6 +89,5 @@ internal fun AnalyticsPreferencesViewDarkPreview(@PreviewParameter(AnalyticsPref
 private fun ContentToPreview(state: AnalyticsPreferencesState) {
     AnalyticsPreferencesView(
         state = state,
-        onOpenAnalyticsPolicy = {},
     )
 }
diff --git a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsNode.kt b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsNode.kt
index 18bb99e8e1..adc917b7e6 100644
--- a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsNode.kt
+++ b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsNode.kt
@@ -16,19 +16,15 @@
 
 package io.element.android.features.preferences.impl.analytics
 
-import android.app.Activity
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.platform.LocalContext
 import com.bumble.appyx.core.modality.BuildContext
 import com.bumble.appyx.core.node.Node
 import com.bumble.appyx.core.plugin.Plugin
 import dagger.assisted.Assisted
 import dagger.assisted.AssistedInject
 import io.element.android.anvilannotations.ContributesNode
-import io.element.android.libraries.androidutils.browser.openUrlInChromeCustomTab
 import io.element.android.libraries.di.SessionScope
-import io.element.android.libraries.theme.ElementTheme
 
 @ContributesNode(SessionScope::class)
 class AnalyticsSettingsNode @AssistedInject constructor(
@@ -37,19 +33,12 @@ class AnalyticsSettingsNode @AssistedInject constructor(
     private val presenter: AnalyticsSettingsPresenter,
 ) : Node(buildContext, plugins = plugins) {
 
-    private fun onOpenAnalyticsPolicy(activity: Activity, darkTheme: Boolean, url: String) {
-        activity.openUrlInChromeCustomTab(null, darkTheme, url)
-    }
-
     @Composable
     override fun View(modifier: Modifier) {
-        val activity = LocalContext.current as Activity
-        val isDark = ElementTheme.colors.isLight.not()
         val state = presenter.present()
         AnalyticsSettingsView(
             state = state,
             onBackPressed = ::navigateUp,
-            onOpenAnalyticsPolicy = { onOpenAnalyticsPolicy(activity, darkTheme = isDark, it) },
             modifier = modifier
         )
     }
diff --git a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsView.kt b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsView.kt
index 83dd5554fd..3ee7365122 100644
--- a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsView.kt
+++ b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/analytics/AnalyticsSettingsView.kt
@@ -31,7 +31,6 @@ import io.element.android.libraries.ui.strings.CommonStrings
 fun AnalyticsSettingsView(
     state: AnalyticsSettingsState,
     onBackPressed: () -> Unit,
-    onOpenAnalyticsPolicy: (url: String) -> Unit,
     modifier: Modifier = Modifier,
 ) {
     PreferenceView(
@@ -41,7 +40,6 @@ fun AnalyticsSettingsView(
     ) {
         AnalyticsPreferencesView(
             state = state.analyticsState,
-            onOpenAnalyticsPolicy = onOpenAnalyticsPolicy,
         )
     }
 }
@@ -61,6 +59,5 @@ private fun ContentToPreview(state: AnalyticsSettingsState) {
     AnalyticsSettingsView(
         state = state,
         onBackPressed = {},
-        onOpenAnalyticsPolicy = {},
     )
 }