letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Suppress Detekt false positive (?)

Browse Source
This commit is contained in:
Benoit Marty
2025-01-17 11:49:54 +01:00
committed by Benoit Marty
parent 84d603d31f
commit 901ad85ee6
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenter.kt
View File

@@ -127,12 +127,18 @@ class MediaViewerPresenter @AssistedInject constructor(
fun handleEvents(event: MediaViewerEvents) {
when (event) {
is MediaViewerEvents.LoadMedia -> coroutineScope.downloadMedia(
data = event.data,
mediaFile = mediaFile.getOrPut(event.data.eventId) { mutableStateOf(null) },
localMedia = localMedia.getOrPut(event.data.eventId) { mutableStateOf(AsyncData.Uninitialized) },
)
is MediaViewerEvents.LoadMedia -> {
// It's OK to suppress the warning since mediaFile and localMedia are remembered
@Suppress("RememberMissing")
coroutineScope.downloadMedia(
data = event.data,
mediaFile = mediaFile.getOrPut(event.data.eventId) { mutableStateOf(null) },
localMedia = localMedia.getOrPut(event.data.eventId) { mutableStateOf(AsyncData.Uninitialized) },
)
}
is MediaViewerEvents.ClearLoadingError -> {
// It's OK to suppress the warning since localMedia is remembered
@Suppress("RememberMissing")
localMedia.getOrPut(event.eventId) { mutableStateOf(AsyncData.Uninitialized) }.value = AsyncData.Uninitialized
}
is MediaViewerEvents.SaveOnDisk -> {