From 901ad85ee65c9b5f660605be0703875a41c4145a Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Fri, 17 Jan 2025 11:49:54 +0100 Subject: [PATCH] Suppress Detekt false positive (?) --- .../impl/viewer/MediaViewerPresenter.kt | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenter.kt b/libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenter.kt index 7a93cb009b..a15804d365 100644 --- a/libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenter.kt +++ b/libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenter.kt @@ -127,12 +127,18 @@ class MediaViewerPresenter @AssistedInject constructor( fun handleEvents(event: MediaViewerEvents) { when (event) { - is MediaViewerEvents.LoadMedia -> coroutineScope.downloadMedia( - data = event.data, - mediaFile = mediaFile.getOrPut(event.data.eventId) { mutableStateOf(null) }, - localMedia = localMedia.getOrPut(event.data.eventId) { mutableStateOf(AsyncData.Uninitialized) }, - ) + is MediaViewerEvents.LoadMedia -> { + // It's OK to suppress the warning since mediaFile and localMedia are remembered + @Suppress("RememberMissing") + coroutineScope.downloadMedia( + data = event.data, + mediaFile = mediaFile.getOrPut(event.data.eventId) { mutableStateOf(null) }, + localMedia = localMedia.getOrPut(event.data.eventId) { mutableStateOf(AsyncData.Uninitialized) }, + ) + } is MediaViewerEvents.ClearLoadingError -> { + // It's OK to suppress the warning since localMedia is remembered + @Suppress("RememberMissing") localMedia.getOrPut(event.eventId) { mutableStateOf(AsyncData.Uninitialized) }.value = AsyncData.Uninitialized } is MediaViewerEvents.SaveOnDisk -> {