Update join call button in room header (#5143)

* Change the Join Call button to 1.) show a Video Call Solid icon, 2.) change the label from "Join call" to "Join", and 3.) change the background color to primary/rest.

* Add a clarifying comment and snapshots.

ElementX/Sources/Other/SwiftUI/Views/JoinCallButton.swift

@@ -22,12 +22,19 @@ struct JoinCallButton: View {
     
     var glassButton: some View {
         Button(action: action) {
-            Text(L10n.a11yJoinCall)
-                .font(.compound.bodyLG.weight(.medium))
-                .foregroundStyle(.compound.textOnSolidPrimary)
+            // Use an HStack on iOS 26 as .labelStyle(.titleAndIcon) doesn't
+            // seem to have any effect on a label in the navigation bar 🤷‍♂️
+            HStack(spacing: 6) {
+                CompoundIcon(\.videoCallSolid)
+                Text(L10n.actionJoin)
+                    .padding(.trailing, 4)
+            }
+            .font(.compound.bodyLG.weight(.medium))
+            .foregroundStyle(.compound.textOnSolidPrimary)
         }
-        .tint(.compound.bgAccentRest)
+        .tint(.compound.bgActionPrimaryRest)
         .backportButtonStyleGlassProminent()
+        .accessibilityLabel(L10n.a11yJoinCall)
     }
     
     var customButton: some View {

UITests/Sources/__Snapshots__/Application/roomScreen.testPlainNoAvatar-iPhone-en-GB.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:caa03f5a0f9650ef511bb7da58ceb0c9666524134055444493e9b5edfc18bd6f
-size 319182
+oid sha256:171da6b4a43eaacb7e3591ea7913bf1ae654bd766413fddc4035a2eb1bc52850
+size 319591

UITests/Sources/__Snapshots__/Application/roomScreen.testTimelineLayoutAtBottom-iPhone-en-GB-1.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:72843951c33223442a000d861844a33e915e481389b043455e30833ad3523d7f
-size 259234
+oid sha256:f68f6372172a8fe470121cb4a48879d42d88f68fa59f672a91b869f0f669dd21
+size 256648

UITests/Sources/__Snapshots__/Application/roomScreen.testTimelineReadReceipts-iPhone-en-GB.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3f07c729d345b6f580bff7e88df4320e6d35b2cfd56623bfeaad5c2b1470e3a9
-size 167050
+oid sha256:3591eee911fd416b8328ec696ba2287752ec08881c6ddb0e58e4d7bd79cd54b8
+size 167215

UITests/Sources/__Snapshots__/Application/roomScreen.testTimelineUndisclosedPolls-iPhone-en-GB.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:edbf75d4de036f9d60cb687a8c7fa4d1bb81f55c8f37b577dec51b761191d653
-size 234564
+oid sha256:452a2bcaa06f8e61d0921eaa6cdcf9a0f469758bb57c7730206513505aadc129
+size 234406

UITests/Sources/__Snapshots__/Application/userSessionScreen.testSpaceExploration-iPhone-en-GB-8.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f7ebc5357f3bc230345f249a64c5ddbdcd48574fd9fa6b7d7db11dca968fa086
-size 287151
+oid sha256:e51110cb27d519202e7026898fff97197b88c7936ccb210d20b33e61074918fb
+size 286820

UITests/Sources/__Snapshots__/Application/userSessionScreen.testUserSessionFlows-iPhone-en-GB-2.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:746691db124306e8507dd48e42c54c0ecce8d546edee9b549932c554a78426aa
-size 298397
+oid sha256:9e98280ce587f8f1a85e503bd4b4a2aacebfecd0e6591f5d719c3ed7097a6bce
+size 299766

UITests/Sources/__Snapshots__/Application/userSessionScreen.testUserSessionFlows-iPhone-en-GB-3.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:844ecd50cad5317ea4dddc51881a6428f3be74352240492ffba027b1f5d9e6f1
-size 442531
+oid sha256:a2bd268f7474dd09384a646e24f74a1f529f30d4717df5260208b2f4f1a07ea3
+size 443867

UITests/Sources/__Snapshots__/Application/userSessionScreen.testUserSessionReply-iPhone-en-GB.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ab174bad5c17e09709d476f2585b6a53b2b4d66f51c4708d8acfa1784fd2c49a
-size 271704
+oid sha256:c41560089930954c50895d3b8fcbfe8ff2beb037c1ac87fa51ffea79aa2982c7
+size 272629