letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Switch to optimised video uploads to 720p (#3462)

Browse Source
This commit is contained in:
Doug
2024-10-29 11:44:46 +00:00
committed by GitHub
parent b496fa327e
commit d9d6c066ee
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ElementX/Sources/Services/Media/MediaUploadingPreprocessor.swift
View File

@@ -389,7 +389,7 @@ struct MediaUploadingPreprocessor {
/// - Returns: the URL for the resulting video and its media info as a `VideoProcessingResult`
private func convertVideoToMP4(_ url: URL, targetFileSize: UInt = 0) async throws(MediaUploadingPreprocessorError) -> VideoProcessingInfo {
let asset = AVURLAsset(url: url)
let presetName = appSettings.optimizeMediaUploads ? AVAssetExportPreset640x480 : AVAssetExportPreset1920x1080
let presetName = appSettings.optimizeMediaUploads ? AVAssetExportPreset1280x720 : AVAssetExportPreset1920x1080
guard let exportSession = AVAssetExportSession(asset: asset, presetName: presetName) else {
throw .failedConvertingVideo

14
UnitTests/Sources/MediaUploadingPreprocessorTests.swift
View File

@@ -101,10 +101,10 @@ final class MediaUploadingPreprocessorTests: XCTestCase {
// Check optimised video info
XCTAssertEqual(optimizedVideoInfo.mimetype, "video/mp4")
XCTAssertEqual(optimizedVideoInfo.blurhash, "K32PJbx^I7jYaebHMvV?o$")
XCTAssertEqual(optimizedVideoInfo.size ?? 0, 4_090_898, accuracy: 100) // Note: This is slightly stupid because it is larger now 🤦‍♂️
XCTAssertEqual(optimizedVideoInfo.width, 640)
XCTAssertEqual(optimizedVideoInfo.height, 360)
XCTAssertEqual(optimizedVideoInfo.blurhash, "K22PJZx^DgadWAbbMuRio$")
XCTAssertEqual(optimizedVideoInfo.size ?? 0, 1_431_959, accuracy: 100) // Note: This is slightly stupid because it is larger now 🤦‍♂️
XCTAssertEqual(optimizedVideoInfo.width, 1280)
XCTAssertEqual(optimizedVideoInfo.height, 720)
XCTAssertEqual(optimizedVideoInfo.duration ?? 0, 30, accuracy: 100)
}
@@ -165,9 +165,9 @@ final class MediaUploadingPreprocessorTests: XCTestCase {
// Check optimised video info
XCTAssertEqual(optimizedVideoInfo.mimetype, "video/mp4")
XCTAssertEqual(optimizedVideoInfo.blurhash, "K7BDNJD*0L%#sl_2~C9ZE1")
XCTAssertEqual(optimizedVideoInfo.size ?? 0, 6_520_897, accuracy: 100)
XCTAssertEqual(optimizedVideoInfo.width, 360)
XCTAssertEqual(optimizedVideoInfo.height, 640)
XCTAssertEqual(optimizedVideoInfo.size ?? 0, 21_936_767, accuracy: 100)
XCTAssertEqual(optimizedVideoInfo.width, 720)
XCTAssertEqual(optimizedVideoInfo.height, 1280)
XCTAssertEqual(optimizedVideoInfo.duration ?? 0, 30, accuracy: 100)
}