letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Prevent crashes when computing aspect ratios on zero media width or height

Browse Source
This commit is contained in:
Stefan Ceriu
2024-02-08 17:17:46 +02:00
parent 5cd32d4625
commit c84ba3bdf6
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
View File

@@ -134,7 +134,7 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
var aspectRatio: CGFloat?
let width = imageInfo.width.map(CGFloat.init)
let height = imageInfo.height.map(CGFloat.init)
if let width, let height {
if let width, let height, width > 0, height > 0 {
aspectRatio = width / height
}
@@ -488,7 +488,7 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
let height = messageContent.info?.height.map(CGFloat.init)
var aspectRatio: CGFloat?
if let width, let height {
if let width, let height, width > 0, height > 0 {
aspectRatio = width / height
}
@@ -508,7 +508,7 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
let height = messageContent.info?.height.map(CGFloat.init)
var aspectRatio: CGFloat?
if let width, let height {
if let width, let height, width > 0, height > 0 {
aspectRatio = width / height
}

1
changelog.d/pr-2437.bugfix Normal file
View File

@@ -0,0 +1 @@
Prevent crashes when computing aspect ratios on zero media width or height