letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Add proper separated blockquotes fixtures and fix the tests.

Browse Source
This commit is contained in:
Stefan Ceriu
2025-09-09 14:26:13 +03:00
committed by Doug
parent 9bbff69c69
commit 94a2b86283
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ElementX/Sources/Other/HTMLParsing/HTMLFixtures.swift
View File

@@ -68,9 +68,11 @@ enum HTMLFixtures: String, CaseIterable {
"""
case .separatedBlockQuotes:
"""
<blockquote>First blockquote with a <a href=\"https://www.matrix.org/\">link</a> in it</blockquote>
<blockquote>Second blockquote with a <a href=\"https://www.matrix.org/\">link</a> in it</blockquote>
<blockquote>Third blockquote with a <a href=\"https://www.matrix.org/\">link</a> in it</blockquote>
Text before blockquote
<blockquote>Some blockquote</blockquote>
Text after first blockquote
<blockquote>Some other blockquote</blockquote>
Text after second blockquote
"""
case .codeBlocks:
"""

10
UnitTests/Sources/AttributedStringBuilderTests.swift
View File

@@ -424,19 +424,19 @@ class AttributedStringBuilderV1Tests: XCTestCase {
let coalescedComponents = attributedString.formattedComponents
if AttributedStringBuilder.useNextGenHTMLParser {
XCTAssertEqual(attributedString.runs.count, 11)
XCTAssertEqual(attributedString.runs.count, 5)
XCTAssertEqual(coalescedComponents.count, 5)
} else {
XCTAssertEqual(attributedString.runs.count, 7)
XCTAssertEqual(coalescedComponents.count, 1)
XCTAssertEqual(attributedString.runs.count, 6)
XCTAssertEqual(coalescedComponents.count, 5)
}
var numberOfBlockquotes = 0
for run in attributedString.runs where run.elementX.blockquote ?? false && run.link != nil {
for run in attributedString.runs where run.elementX.blockquote ?? false {
numberOfBlockquotes += 1
}
XCTAssertEqual(numberOfBlockquotes, 3, "Couldn't find all the blockquotes")
XCTAssertEqual(numberOfBlockquotes, 2, "Couldn't find all the blockquotes")
}
func testUserPermalinkMentionAtachment() {