Prevent the dismissal callback from being called multiple times if changes happen on the navigation coordinators directly from it

2023-03-01 09:03:17 +02:00
parent cadae2170b
commit 73dcfe2f27
1 changed files with 3 additions and 1 deletions
--- a/ElementX/Sources/Application/Navigation/NavigationModule.swift
+++ b/ElementX/Sources/Application/Navigation/NavigationModule.swift
@@ -36,9 +36,11 @@ class NavigationModule: Identifiable, Hashable {
    
    func tearDown() {
        coordinator?.stop()
-        dismissalCallback?()
        coordinator = nil
+        
+        let callback = dismissalCallback
        dismissalCallback = nil
+        callback?()
    }
    
    nonisolated static func == (lhs: NavigationModule, rhs: NavigationModule) -> Bool {