letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 2 Wiki Activity

Minor fixes. (#406)

Browse Source 
* Use the links colour from Compound for links.
* Avoid constantly recomputing the RoomScreen view hierarchy while scrolling.
This commit is contained in:
Doug
2023-01-05 11:06:49 +00:00
committed by GitHub
parent f9107b8ff7
commit 677888abba
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
View File

@@ -51,8 +51,7 @@ struct FormattedBodyText: View {
}
}
}
// Should be .element.accent but that's currently black
.tint(.blue)
.tint(.element.links)
}
private var blockquoteAttributes: AttributeContainer {

9
ElementX/Sources/Screens/RoomScreen/View/TimelineTableViewController.swift
View File

@@ -358,8 +358,13 @@ class TimelineTableViewController: UIViewController {
extension TimelineTableViewController: UITableViewDelegate {
func scrollViewDidScroll(_ scrollView: UIScrollView) {
// Dispatches fix runtime warnings about making changes during a view update.
DispatchQueue.main.async { self.scrollToBottomButtonVisible = self.isAtBottom() }
let isAtBottom = isAtBottom()
// Only update the binding on changes to avoid needlessly recomputing the hierarchy when scrolling.
if scrollToBottomButtonVisible != isAtBottom {
// Dispatch to fix runtime warning about making changes during a view update.
DispatchQueue.main.async { self.scrollToBottomButtonVisible = isAtBottom }
}
paginateBackwardsPublisher.send(())
}

1
changelog.d/pr-406.change Normal file
View File

@@ -0,0 +1 @@
Use the links colour from Compound for links and avoid recomputing the RoomScreen view hierarchy while scrolling.