letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Fixing a crash that happened when leaving the room through the details screen (#2160)

Browse Source
This commit is contained in:
Mauro
2023-11-23 18:24:37 +01:00
committed by GitHub
parent 4ab033191a
commit 60bb495b2d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ElementX/Sources/FlowCoordinators/RoomFlowCoordinator.swift
View File

@@ -410,10 +410,9 @@ class RoomFlowCoordinator: FlowCoordinatorProtocol {
}
private func dismissRoom(animated: Bool) {
// Setting the detail coordinator to nil afirst allows the dismiss to work properly
// if followed immediately by another navigation on iPhone
navigationSplitCoordinator.setDetailCoordinator(nil, animated: animated)
// DON'T CHANGE THE ORDER IN WHICH POP AND SET ARE DONE, IT CAN CAUSE A CRASH
navigationStackCoordinator.popToRoot(animated: false)
navigationSplitCoordinator.setDetailCoordinator(nil, animated: animated)
roomProxy = nil
timelineController = nil

1
changelog.d/pr-2160.bugfix Normal file
View File

@@ -0,0 +1 @@
Fixed a crash that happened when leaving a room through the details screen.