letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Fix crashes when blocking/unblocking users

Browse Source 
- SwiftUI crashes when mutating optional state properties in place
- workaround it buy mutating a local reference first
This commit is contained in:
Stefan Ceriu
2024-03-11 14:17:27 +02:00
parent eebe5f362b
commit 3715a0ea3f
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenViewModel.swift
View File

@@ -108,7 +108,10 @@ class RoomMemberDetailsScreenViewModel: RoomMemberDetailsScreenViewModelType, Ro
state.isProcessingIgnoreRequest = false
switch result {
case .success:
state.memberDetails?.isIgnored = true
var details = state.memberDetails
details?.isIgnored = true
state.memberDetails = details
updateMembers()
case .failure:
state.bindings.alertInfo = .init(id: .unknown)
@@ -126,7 +129,10 @@ class RoomMemberDetailsScreenViewModel: RoomMemberDetailsScreenViewModelType, Ro
state.isProcessingIgnoreRequest = false
switch result {
case .success:
state.memberDetails?.isIgnored = false
var details = state.memberDetails
details?.isIgnored = false
state.memberDetails = details
updateMembers()
case .failure:
state.bindings.alertInfo = .init(id: .unknown)

1
changelog.d/pr-2553.bugfix Normal file
View File

@@ -0,0 +1 @@
Fix crashes when blocking/unblocking users