letro/letro-authentication-service
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Highlight dangerous scopes when consenting to them (#5180)

Browse Source
This commit is contained in:
Quentin Gliech
2025-10-22 12:11:32 +02:00
committed by GitHub
parent 904ffbd8ee 3f66053943
commit d2cff3f58a
4 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/components/SessionDetail/SessionInfo.tsx
View File

@@ -3,10 +3,11 @@
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
// Please see LICENSE files in the repository root for full details.
import IconAdmin from "@vector-im/compound-design-tokens/assets/web/icons/admin";
import IconChat from "@vector-im/compound-design-tokens/assets/web/icons/chat";
import IconComputer from "@vector-im/compound-design-tokens/assets/web/icons/computer";
import IconErrorSolid from "@vector-im/compound-design-tokens/assets/web/icons/error-solid";
import IconInfo from "@vector-im/compound-design-tokens/assets/web/icons/info";
import IconRoom from "@vector-im/compound-design-tokens/assets/web/icons/room";
import IconSend from "@vector-im/compound-design-tokens/assets/web/icons/send";
import IconUserProfile from "@vector-im/compound-design-tokens/assets/web/icons/user-profile";
import {
@@ -68,7 +69,7 @@ export const ScopeSendMessages: React.FC = () => {
const ScopeSynapseAdmin: React.FC = () => {
const { t } = useTranslation();
return (
<VisualListItem Icon={IconErrorSolid}>
<VisualListItem Icon={IconRoom} destructive>
{t("mas.scope.synapse_admin")}
</VisualListItem>
);
@@ -77,7 +78,7 @@ const ScopeSynapseAdmin: React.FC = () => {
const ScopeMasAdmin: React.FC = () => {
const { t } = useTranslation();
return (
<VisualListItem Icon={IconErrorSolid}>
<VisualListItem Icon={IconAdmin} destructive>
{t("mas.scope.mas_admin")}
</VisualListItem>
);

11
frontend/src/templates.css
View File

@@ -117,6 +117,17 @@
width: var(--cpd-space-6x);
color: var(--cpd-color-icon-quaternary);
}
&.dangerous {
border: 1px solid var(--cpd-color-border-critical-subtle);
background-color: var(--cpd-color-bg-critical-subtle);
font: var(--cpd-font-body-md-medium);
color: var(--cpd-color-text-critical-primary);
& > svg {
color: var(--cpd-color-icon-critical-primary);
}
}
}
}
}

4
templates/components/scope.html
View File

@@ -18,9 +18,9 @@ Please see LICENSE files in the repository root for full details.
<li>{{ icon.chat() }}<p>{{ _("mas.scope.view_messages") }}</p></li>
<li>{{ icon.send() }}<p>{{ _("mas.scope.send_messages") }}</p></li>
{% elif scope == "urn:synapse:admin:*" %}
<li>{{ icon.error_solid() }}<p>{{ _("mas.scope.synapse_admin") }}</p></li>
<li class="dangerous">{{ icon.room() }}<p>{{ _("mas.scope.synapse_admin") }}</p></li>
{% elif scope == "urn:mas:admin" %}
<li>{{ icon.error_solid() }}<p>{{ _("mas.scope.mas_admin") }}</p></li>
<li class="dangerous">{{ icon.admin() }}<p>{{ _("mas.scope.mas_admin") }}</p></li>
{% elif scope is startingwith("urn:matrix:client:device:") or scope is startingwith("urn:matrix:org.matrix.msc2967.client:device:") %}
{# We hide this scope #}
{% else %}

4
translations/en.json
View File

@@ -666,7 +666,7 @@
},
"mas_admin": "Administer any user on the matrix-authentication-service",
"@mas_admin": {
"context": "components/scope.html:23:42-66",
"context": "components/scope.html:23:54-78",
"description": "Displayed when the 'urn:mas:admin' scope is requested"
},
"send_messages": "Send new messages on your behalf",
@@ -675,7 +675,7 @@
},
"synapse_admin": "Administer the Synapse homeserver",
"@synapse_admin": {
"context": "components/scope.html:21:42-70",
"context": "components/scope.html:21:53-81",
"description": "Displayed when the 'urn:synapse:admin:*' scope is requested"
},
"view_messages": "View your existing messages and data",