Commit Graph

1337 Commits

Author SHA1 Message Date
Benoit Marty
ac1d355f65 Cleanup: there are no androidTest on those modules. 2023-07-24 12:41:02 +02:00
bmarty
e196d951f8 Sync Strings from Localazy 2023-07-24 00:10:09 +00:00
Benoit Marty
45954b4723 Fix code quality check failures after new rules from #935 has been merged on develop. 2023-07-21 16:04:55 +02:00
Benoit Marty
f09996cb30 Merge pull request #935 from vector-im/feature/bma/noWarnings
Code quality: warnings are errors and enable more Detekt rules.
2023-07-21 15:52:05 +02:00
Marco Romano
71676c3faf Static images improvements (#933)
1. On devices less than xhdpi request a 1x image from MapTiler (such devices are generally old, slower and with little memory so avoiding to get the 2x image only to have to shrink it later could help).
2. Coerce too big width/height combos within the API limits keeping the aspect ratio (this will allow requests on big horizontal displays to succeed).
3. Don't crash when given weird width/height combos (i.e. zero or negative).
4. Introduce interfaces to hide this whole logic and make it easier for forks to implement their own.

Related to:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-21 13:37:08 +00:00
Benoit Marty
59a66479ab Merge branch 'develop' into feature/bma/noWarnings 2023-07-21 12:17:50 +02:00
David Langley
4c87138a48 Merge pull request #912 from vector-im/feature/dla_custom_reactions_layout
Reactions layout improvements
2023-07-21 11:00:43 +01:00
Benoit Marty
e03408a806 Test new field canShareLocation 2023-07-20 23:18:18 +02:00
Benoit Marty
a41fffbe4c Must skip 1 item due to the location feature flag value emitting 1 item. 2023-07-20 23:17:29 +02:00
Benoit Marty
f0d02996df canShareLocation must be a MutableState. 2023-07-20 22:23:54 +02:00
Benoit Marty
cd3e6c42e2 Replace FeatureFlags.ShowMediaUploadingFlow by FeatureFlags.LocationSharing because it has more chance to be disabled.
I do not want to remove all our feature flags...
2023-07-20 22:20:38 +02:00
Benoit Marty
c72f1a09a7 Enable detekt rules UnnecessaryParentheses and cleanup the code. 2023-07-20 18:08:08 +02:00
Benoit Marty
55538c2773 Enable detekt rules UnusedImports and cleanup the code. 2023-07-20 18:00:23 +02:00
Benoit Marty
8f715cbc92 Enable detekt rules TopLevelPropertyNaming and cleanup the code. 2023-07-20 17:52:48 +02:00
Benoit Marty
2bd1c75937 Enable detekt rules VariableNaming and cleanup the code. 2023-07-20 17:50:23 +02:00
Benoit Marty
bd2826da3a Enable detekt rules UnusedParameter and UnusedPrivateProperty and cleanup the code. 2023-07-20 17:48:56 +02:00
Benoit Marty
2449cbbaa3 Fix warning (bottom sheet still not previewable correctly in screenshot test) 2023-07-20 17:41:18 +02:00
Benoit Marty
f77349332e Fix warning (there is a TODO) 2023-07-20 17:39:55 +02:00
Benoit Marty
058f35c06a Fix warning (keep the same format for all methods) 2023-07-20 17:39:55 +02:00
Benoit Marty
80f7b63acc Fix warning (we will handle error case later) 2023-07-20 17:39:55 +02:00
Benoit Marty
7524758d05 Fix warning (there is a TODO) 2023-07-20 17:39:55 +02:00
Marco Romano
ffaf24751a Use correct share my location icon in button (#936)
As per newer design specs.

Related to:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-20 13:59:06 +00:00
Benoit Marty
5edcffca93 Fix warning (suppress unused param for now) 2023-07-20 15:47:42 +02:00
Benoit Marty
2872e8faca Fix warning (suppress unused param for now) 2023-07-20 15:47:14 +02:00
Benoit Marty
dc9212c559 Fix warning (suppress unused param for now, EAX does not support sticker right now.) 2023-07-20 15:46:41 +02:00
Benoit Marty
45f8f134ae Fix warning (suppress unused param for now) 2023-07-20 15:46:09 +02:00
Benoit Marty
8a82aab014 Fix warning (suppress unused param for now) 2023-07-20 15:45:18 +02:00
Marco Romano
d5a93a50e0 Add screenshots with ~1.5 lines long desc to expanded location view (#923)
This will help in catching alignment regressions.

Related to:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-20 13:42:35 +00:00
Marco Romano
8648e8ba53 Extract maptiler's map ids (#926)
Maptiler custom map ids are only useable by the account that create them. So if we hardcode them forkers won't be able to use the maps even if the bring in their own api key (because they can't access our maps with their api key).

Requires to set our map ids in `local.properties` for local development:
```
services.maptiler.lightMapId=9bc819c8-e627-474a-a348-ec144fe3d810
services.maptiler.darkMapId=dea61faf-292b-4774-9660-58fcef89a7f3
```
2023-07-20 14:29:06 +02:00
Marco Romano
188af2ee98 Correct location event body (#930)
- Now sending the correct body format as agreed with design. This won't be show in EX clients though.

Related to:
- https://github.com/vector-im/element-meta/issues/1682
2023-07-20 10:16:40 +00:00
Marco Romano
584a227920 maplibre-compose allow customisation of location dot style (#929)
- And style it according to our designs.

Related to:
- https://github.com/vector-im/element-meta/issues/1682
2023-07-20 12:09:40 +02:00
renovate[bot]
6d3b816bf5 Update dependency app.cash.molecule:molecule-runtime to v1 (#925)
* Update dependency app.cash.molecule:molecule-runtime to v1

* Replace `RecompositionClock` with `RecompositionMode`

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jorge Martín <jorgem@element.io>
2023-07-20 07:36:19 +02:00
Jorge Martín
9073ea2107 Fix more lint issues 2023-07-20 07:35:27 +02:00
Jorge Martín
281cb17c2b Fix typo 2023-07-20 07:27:13 +02:00
Jorge Martín
217169620c Use ElementTheme as much as possible 2023-07-20 07:27:02 +02:00
Jorge Martín
0c9c162354 Try to fix lint issue 2023-07-20 07:21:28 +02:00
Marco Romano
025d8781a7 Refactor a custom alignment to its own modifier for readability. (#924) 2023-07-19 16:58:04 +02:00
Marco Romano
30060b5729 Don't crash when sharing a location with no maptiler apikey (#919)
Related to:
- https://github.com/vector-im/element-meta/issues/1682
2023-07-19 16:33:50 +02:00
Marco Romano
c135da2562 Location expanded view: show own location (#916)
If the location permission is granted:
- Shows the user's own location
- Shows a button to center the map on it

Part of:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-19 13:26:06 +00:00
Marco Romano
fb85cc0be4 Fix insets for nav bar in send location view (#915)
Improvement of https://github.com/vector-im/element-x-android/pull/770

- https://github.com/vector-im/element-meta/issues/1682
2023-07-19 13:57:34 +02:00
Marco Romano
278f8ae4c6 Send My Location (#770)
- https://github.com/vector-im/element-meta/issues/1682
2023-07-19 09:58:13 +00:00
Benoit Marty
494e00dcb1 Merge pull request #901 from vector-im/feature/fga/power_level
Feature/fga/power level
2023-07-18 23:39:52 +02:00
Benoit Marty
86cc4a9e05 Also rename the Composable. 2023-07-18 23:10:10 +02:00
ganfra
d4ee9fd9d3 Merge branch 'develop' into feature/fga/fix_room_list_scroll_position 2023-07-18 23:07:10 +02:00
Benoit Marty
456f4fba6b Format files. 2023-07-18 23:05:50 +02:00
ganfra
888ca1c86b Merge branch 'develop' into feature/fga/power_level 2023-07-18 22:54:33 +02:00
ganfra
c7d0bbc174 Merge pull request #906 from vector-im/feature/fga/update-rust-sdk-0.1.34
Feature/fga/update rust sdk 0.1.34
2023-07-18 22:52:48 +02:00
Benoit Marty
ff4b068008 Move test classes to the correct package. 2023-07-18 22:48:23 +02:00
Benoit Marty
9dcb419560 Not a fixture so prefixed with create instead of a. 2023-07-18 22:41:42 +02:00
David Langley
b0c680e1c6 Add more button should have primary text colour 2023-07-18 21:39:37 +01:00