Merge pull request #438 from vector-im/feature/fre/invite_people_action

Handle "Invite people" action in the start a chat flow

changelog.d/437.feature

@@ -0,0 +1 @@
+Handle "Invite people" action in the start a chat flow

features/createroom/impl/build.gradle.kts

@@ -45,6 +45,7 @@ dependencies {
     implementation(projects.libraries.designsystem)
     implementation(projects.libraries.elementresources)
     implementation(projects.libraries.uiStrings)
+    implementation(projects.libraries.androidutils)
     implementation(projects.libraries.mediapickers.api)
     implementation(projects.libraries.mediaupload.api)
     implementation(libs.coil.compose)

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootEvents.kt

@@ -19,7 +19,6 @@ package io.element.android.features.createroom.impl.root
 import io.element.android.libraries.matrix.api.user.MatrixUser
 
 sealed interface CreateRoomRootEvents {
-    object InvitePeople : CreateRoomRootEvents
     data class StartDM(val matrixUser: MatrixUser) : CreateRoomRootEvents
     object CancelStartDM : CreateRoomRootEvents
 }

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootNode.kt

@@ -16,8 +16,10 @@
 
 package io.element.android.features.createroom.impl.root
 
+import android.content.Context
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.LocalContext
 import com.bumble.appyx.core.modality.BuildContext
 import com.bumble.appyx.core.node.Node
 import com.bumble.appyx.core.plugin.Plugin
@@ -25,14 +27,22 @@ import com.bumble.appyx.core.plugin.plugins
 import dagger.assisted.Assisted
 import dagger.assisted.AssistedInject
 import io.element.android.anvilannotations.ContributesNode
+import io.element.android.libraries.androidutils.system.startSharePlainTextIntent
+import io.element.android.libraries.core.meta.BuildMeta
 import io.element.android.libraries.di.SessionScope
+import io.element.android.libraries.matrix.api.MatrixClient
 import io.element.android.libraries.matrix.api.core.RoomId
+import io.element.android.libraries.matrix.api.permalink.PermalinkBuilder
+import io.element.android.libraries.ui.strings.R
+import timber.log.Timber
 
 @ContributesNode(SessionScope::class)
 class CreateRoomRootNode @AssistedInject constructor(
     @Assisted buildContext: BuildContext,
     @Assisted plugins: List<Plugin>,
     private val presenter: CreateRoomRootPresenter,
+    private val matrixClient: MatrixClient,
+    private val buildMeta: BuildMeta,
 ) : Node(buildContext, plugins = plugins) {
 
     interface Callback : Plugin {
@@ -53,12 +63,31 @@ class CreateRoomRootNode @AssistedInject constructor(
     @Composable
     override fun View(modifier: Modifier) {
         val state = presenter.present()
+        val context = LocalContext.current
         CreateRoomRootView(
             state = state,
             modifier = modifier,
             onClosePressed = this::navigateUp,
             onNewRoomClicked = callback::onCreateNewRoom,
             onOpenDM = callback::onStartChatSuccess,
+            onInviteFriendsClicked = { invitePeople(context) }
         )
     }
+
+    private fun invitePeople(context: Context) {
+        val permalinkResult = PermalinkBuilder.permalinkForUser(matrixClient.sessionId)
+        permalinkResult.onSuccess { permalink ->
+            val appName = buildMeta.applicationName
+            startSharePlainTextIntent(
+                context = context,
+                activityResultLauncher = null,
+                chooserTitle = context.getString(R.string.action_invite_friends),
+                text = context.getString(R.string.invite_friends_text, appName, permalink),
+                extraTitle = context.getString(R.string.invite_friends_rich_title, appName),
+                noActivityFoundMessage = context.getString(io.element.android.libraries.androidutils.R.string.error_no_compatible_app_found)
+            )
+        }.onFailure {
+            Timber.e(it)
+        }
+    }
 }

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootPresenter.kt

@@ -75,7 +75,6 @@ class CreateRoomRootPresenter @Inject constructor(
             when (event) {
                 is CreateRoomRootEvents.StartDM -> startDm(event.matrixUser)
                 CreateRoomRootEvents.CancelStartDM -> startDmAction.value = Async.Uninitialized
-                CreateRoomRootEvents.InvitePeople -> Unit // Todo Handle invite people action
             }
         }
 

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootView.kt

@@ -64,6 +64,7 @@ fun CreateRoomRootView(
     onClosePressed: () -> Unit = {},
     onNewRoomClicked: () -> Unit = {},
     onOpenDM: (RoomId) -> Unit = {},
+    onInviteFriendsClicked: () -> Unit = {},
 ) {
     if (state.startDmAction is Async.Success) {
         LaunchedEffect(state.startDmAction) {
@@ -96,7 +97,7 @@ fun CreateRoomRootView(
             if (!state.userListState.isSearchActive) {
                 CreateRoomActionButtonsList(
                     onNewRoomClicked = onNewRoomClicked,
-                    onInvitePeopleClicked = { state.eventSink(CreateRoomRootEvents.InvitePeople) },
+                    onInvitePeopleClicked = onInviteFriendsClicked,
                 )
             }
         }

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootPresenterTests.kt

@@ -62,16 +62,6 @@ class CreateRoomRootPresenterTests {
         }
     }
 
-    @Test
-    fun `present - trigger action buttons`() = runTest {
-        moleculeFlow(RecompositionClock.Immediate) {
-            presenter.present()
-        }.test {
-            val initialState = awaitItem()
-            initialState.eventSink(CreateRoomRootEvents.InvitePeople) // Not implemented yet
-        }
-    }
-
     @Test
     fun `present - trigger create DM action`() = runTest {
         moleculeFlow(RecompositionClock.Immediate) {

features/roomdetails/impl/src/main/res/values/localazy.xml

@@ -6,9 +6,11 @@
   </plurals>
   <string name="screen_room_details_already_a_member">"Already a member"</string>
   <string name="screen_room_details_already_invited">"Already invited"</string>
+  <string name="screen_room_details_edition_error">"An error occurred when updating the room details"</string>
   <string name="screen_room_details_encryption_enabled_subtitle">"Messages are secured with locks. Only you and the recipients have the unique keys to unlock them."</string>
   <string name="screen_room_details_encryption_enabled_title">"Message encryption enabled"</string>
   <string name="screen_room_details_share_room_title">"Share room"</string>
+  <string name="screen_room_details_updating_room">"Updating room…"</string>
   <string name="screen_room_member_list_pending_header_title">"Pending"</string>
   <string name="screen_room_member_list_room_members_header_title">"Room members"</string>
   <string name="screen_dm_details_block_alert_action">"Block"</string>

libraries/ui-strings/src/main/res/values/localazy.xml

@@ -23,6 +23,7 @@
   <string name="action_edit">"Edit"</string>
   <string name="action_enable">"Enable"</string>
   <string name="action_invite">"Invite"</string>
+  <string name="action_invite_friends">"Invite friends"</string>
   <string name="action_invite_friends_to_app">"Invite friends to %1$s"</string>
   <string name="action_invites_list">"Invites"</string>
   <string name="action_learn_more">"Learn more"</string>
@@ -121,6 +122,7 @@
   <string name="error_failed_loading_messages">"Failed loading messages"</string>
   <string name="error_some_messages_have_not_been_sent">"Some messages have not been sent"</string>
   <string name="error_unknown">"Sorry, an error occurred"</string>
+    <string name="invite_friends_rich_title">"🔐️ Join me on %1$s"</string>
   <string name="invite_friends_text">"Hey, talk to me on %1$s: %2$s"</string>
   <string name="leave_room_alert_empty_subtitle">"Are you sure that you want to leave this room? You are the only person here. If you leave, no one will be able to join in the future, including you."</string>
   <string name="leave_room_alert_private_subtitle">"Are you sure that you want to leave this room? This room is not public and you will not be able to rejoin without an invite."</string>