Always use method aRichTextEditorState instead of invoking the constructor directly, and remove parameter when it's the default value.

This commit is contained in:
Benoit Marty
2024-03-14 15:05:57 +01:00
committed by Benoit Marty
parent beffc0cce6
commit eb91f83f51
3 changed files with 10 additions and 9 deletions

View File

@@ -22,6 +22,7 @@ import io.element.android.features.messages.impl.mentions.MentionSuggestion
import io.element.android.libraries.matrix.api.core.UserId
import io.element.android.libraries.matrix.api.permalink.PermalinkData
import io.element.android.libraries.matrix.api.permalink.PermalinkParser
import io.element.android.libraries.textcomposer.aRichTextEditorState
import io.element.android.libraries.textcomposer.model.MessageComposerMode
import io.element.android.wysiwyg.compose.RichTextEditorState
import kotlinx.collections.immutable.ImmutableList
@@ -35,7 +36,7 @@ open class MessageComposerStateProvider : PreviewParameterProvider<MessageCompos
}
fun aMessageComposerState(
richTextEditorState: RichTextEditorState = RichTextEditorState(""),
richTextEditorState: RichTextEditorState = aRichTextEditorState(),
isFullScreen: Boolean = false,
mode: MessageComposerMode = MessageComposerMode.Normal,
showTextFormatting: Boolean = false,

View File

@@ -637,7 +637,7 @@ internal fun TextComposerSimplePreview() = ElementPreview {
},
{
ATextComposer(
aRichTextEditorState(initialText = "A message without focus", initialFocus = false),
aRichTextEditorState(initialText = "A message without focus"),
voiceMessageState = VoiceMessageState.Idle,
composerMode = MessageComposerMode.Normal,
enableTextFormatting = true,
@@ -654,7 +654,7 @@ internal fun TextComposerSimplePreview() = ElementPreview {
internal fun TextComposerFormattingPreview() = ElementPreview {
PreviewColumn(items = persistentListOf({
ATextComposer(
aRichTextEditorState(initialText = "", initialFocus = false),
aRichTextEditorState(),
voiceMessageState = VoiceMessageState.Idle,
showTextFormatting = true,
composerMode = MessageComposerMode.Normal,
@@ -664,7 +664,7 @@ internal fun TextComposerFormattingPreview() = ElementPreview {
)
}, {
ATextComposer(
aRichTextEditorState(initialText = "A message", initialFocus = false),
aRichTextEditorState(initialText = "A message"),
voiceMessageState = VoiceMessageState.Idle,
showTextFormatting = true,
composerMode = MessageComposerMode.Normal,
@@ -676,7 +676,6 @@ internal fun TextComposerFormattingPreview() = ElementPreview {
ATextComposer(
aRichTextEditorState(
initialText = "A message\nWith several lines\nTo preview larger textfields and long lines with overflow",
initialFocus = false
),
voiceMessageState = VoiceMessageState.Idle,
showTextFormatting = true,
@@ -710,7 +709,7 @@ internal fun TextComposerReplyPreview() = ElementPreview {
items = persistentListOf(
{
ATextComposer(
aRichTextEditorState(""),
aRichTextEditorState(),
voiceMessageState = VoiceMessageState.Idle,
composerMode = MessageComposerMode.Reply(
isThreaded = false,
@@ -728,7 +727,7 @@ internal fun TextComposerReplyPreview() = ElementPreview {
},
{
ATextComposer(
RichTextEditorState(""),
aRichTextEditorState(),
voiceMessageState = VoiceMessageState.Idle,
composerMode = MessageComposerMode.Reply(
isThreaded = true,
@@ -839,7 +838,7 @@ internal fun TextComposerVoicePreview() = ElementPreview {
fun VoicePreview(
voiceMessageState: VoiceMessageState
) = ATextComposer(
RichTextEditorState("", initialFocus = true),
aRichTextEditorState(initialFocus = true),
voiceMessageState = voiceMessageState,
composerMode = MessageComposerMode.Normal,
enableTextFormatting = true,

View File

@@ -35,6 +35,7 @@ import io.element.android.libraries.designsystem.preview.ElementPreview
import io.element.android.libraries.designsystem.preview.PreviewsDayNight
import io.element.android.libraries.textcomposer.R
import io.element.android.libraries.textcomposer.TextComposerLinkDialog
import io.element.android.libraries.textcomposer.aRichTextEditorState
import io.element.android.wysiwyg.compose.RichTextEditorState
import io.element.android.wysiwyg.view.models.InlineFormat
import io.element.android.wysiwyg.view.models.LinkAction
@@ -209,5 +210,5 @@ private fun ActionState?.toButtonState(): FormattingOptionState =
@PreviewsDayNight
@Composable
internal fun TextFormattingPreview() = ElementPreview {
TextFormatting(state = RichTextEditorState())
TextFormatting(state = aRichTextEditorState())
}