Avoid hard-coded number and update the related test.
This commit is contained in:
committed by
Benoit Marty
parent
9e1c8279b2
commit
eb2810e467
@@ -42,6 +42,6 @@ fun avatarColors(userId: String): AvatarColors {
|
||||
}
|
||||
|
||||
internal fun String.toHash(): Int {
|
||||
return toList().sumOf { it.code } % 8
|
||||
return toList().sumOf { it.code } % avatarColorsLight.size
|
||||
}
|
||||
|
||||
|
||||
@@ -24,11 +24,8 @@ import org.junit.Test
|
||||
class AvatarColorsTest {
|
||||
|
||||
@Test
|
||||
fun `ensure list size`() {
|
||||
// avatarColorsDark and avatarColorsLight size must not be modified.
|
||||
// 8 is used as a hard-coded modulo in `String.toHash()` extension.
|
||||
assertThat(avatarColorsDark.size).isEqualTo(8)
|
||||
assertThat(avatarColorsLight.size).isEqualTo(8)
|
||||
fun `ensure the size of the avatar color are equal for light and dark theme`() {
|
||||
assertThat(avatarColorsDark.size).isEqualTo(avatarColorsLight.size)
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
Reference in New Issue
Block a user