Fix detekted issues.

features/messages/src/main/java/io/element/android/x/features/messages/MessagesScreen.kt

@@ -101,6 +101,9 @@ import io.element.android.x.features.messages.textcomposer.MessageComposerViewMo
 import io.element.android.x.features.messages.textcomposer.MessageComposerViewState
 import io.element.android.x.textcomposer.MessageComposerMode
 import io.element.android.x.textcomposer.TextComposer
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.persistentListOf
+import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.flow.distinctUntilChanged
 import kotlinx.coroutines.launch
 import timber.log.Timber
@@ -140,7 +143,7 @@ fun MessagesScreen(
     MessagesScreenContent(
         roomTitle = roomTitle,
         roomAvatar = roomAvatar,
-        timelineItems = timelineItems().orEmpty(),
+        timelineItems = timelineItems().orEmpty().toImmutableList(),
         hasMoreToLoad = hasMoreToLoad,
         onReachedLoadMore = viewModel::loadMore,
         onBackPressed = onBackPressed,
@@ -182,7 +185,7 @@ fun MessagesScreen(
 fun MessagesScreenContent(
     roomTitle: String?,
     roomAvatar: AvatarData?,
-    timelineItems: List<MessagesTimelineItemState>,
+    timelineItems: ImmutableList<MessagesTimelineItemState>,
     hasMoreToLoad: Boolean,
     onReachedLoadMore: () -> Unit,
     onBackPressed: () -> Unit,
@@ -241,7 +244,7 @@ fun MessagesScreenContent(
 
 @Composable
 fun MessagesContent(
-    timelineItems: List<MessagesTimelineItemState>,
+    timelineItems: ImmutableList<MessagesTimelineItemState>,
     hasMoreToLoad: Boolean,
     onReachedLoadMore: () -> Unit,
     onSendMessage: (String) -> Unit,
@@ -337,7 +340,7 @@ fun MessagesTopAppBar(
 @Composable
 fun TimelineItems(
     lazyListState: LazyListState,
-    timelineItems: List<MessagesTimelineItemState>,
+    timelineItems: ImmutableList<MessagesTimelineItemState>,
     highlightedEventId: String?,
     modifier: Modifier = Modifier,
     hasMoreToLoad: Boolean = false,
@@ -523,7 +526,7 @@ private fun MessageSenderInformation(
 @Composable
 internal fun BoxScope.MessagesScrollHelper(
     lazyListState: LazyListState,
-    timelineItems: List<MessagesTimelineItemState>,
+    timelineItems: ImmutableList<MessagesTimelineItemState>,
     onLoadMore: () -> Unit = {},
 ) {
     val coroutineScope = rememberCoroutineScope()
@@ -609,7 +612,7 @@ private fun TimelineItemsPreview(
 ) {
     TimelineItems(
         lazyListState = LazyListState(),
-        timelineItems = listOf(
+        timelineItems = persistentListOf(
             // 3 items (First Middle Last) with isMine = false
             createMessageEvent(
                 isMine = false,

features/roomlist/src/main/java/io/element/android/x/features/roomlist/RoomListScreen.kt

@@ -36,6 +36,8 @@ import io.element.android.x.features.roomlist.model.RoomListRoomSummary
 import io.element.android.x.features.roomlist.model.RoomListViewState
 import io.element.android.x.features.roomlist.model.stubbedRoomSummaries
 import io.element.android.x.matrix.core.RoomId
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.toImmutableList
 
 @Composable
 fun RoomListScreen(
@@ -53,7 +55,7 @@ fun RoomListScreen(
     val roomSummaries by viewModel.collectAsState(RoomListViewState::rooms)
     val matrixUser by viewModel.collectAsState(RoomListViewState::user)
     RoomListContent(
-        roomSummaries = roomSummaries().orEmpty(),
+        roomSummaries = roomSummaries().orEmpty().toImmutableList(),
         matrixUser = matrixUser(),
         onRoomClicked = onRoomClicked,
         onLogoutClicked = viewModel::logout,
@@ -66,16 +68,16 @@ fun RoomListScreen(
 
 @Composable
 fun RoomListContent(
-    roomSummaries: List<RoomListRoomSummary>,
+    roomSummaries: ImmutableList<RoomListRoomSummary>,
     matrixUser: MatrixUser?,
-    onRoomClicked: (RoomId) -> Unit,
     filter: String,
-    onFilterChanged: (String) -> Unit,
-    onLogoutClicked: () -> Unit,
-    onScrollOver: (IntRange) -> Unit,
     isLoginOut: Boolean,
+    modifier: Modifier = Modifier,
+    onRoomClicked: (RoomId) -> Unit = {},
+    onFilterChanged: (String) -> Unit = {},
+    onLogoutClicked: () -> Unit = {},
+    onScrollOver: (IntRange) -> Unit = {},
 ) {
-
     fun onRoomClicked(room: RoomListRoomSummary) {
         onRoomClicked(room.roomId)
     }
@@ -104,7 +106,7 @@ fun RoomListContent(
     }
 
     Scaffold(
-        modifier = Modifier.nestedScroll(scrollBehavior.nestedScrollConnection),
+        modifier = modifier.nestedScroll(scrollBehavior.nestedScrollConnection),
         topBar = {
             RoomListTopBar(
                 matrixUser = matrixUser,

features/roomlist/src/main/java/io/element/android/x/features/roomlist/components/RoomListTopBar.kt

@@ -84,14 +84,15 @@ fun RoomListTopBar(
 @Composable
 fun SearchRoomListTopBar(
     text: String,
-    onFilterChanged: (String) -> Unit,
-    onCloseClicked: () -> Unit,
-    scrollBehavior: TopAppBarScrollBehavior
+    scrollBehavior: TopAppBarScrollBehavior,
+    modifier: Modifier = Modifier,
+    onFilterChanged: (String) -> Unit = {},
+    onCloseClicked: () -> Unit = {},
 ) {
     var filterState by textFieldState(stateValue = text)
     val focusRequester = remember { FocusRequester() }
     TopAppBar(
-        modifier = Modifier
+        modifier = modifier
             .nestedScroll(scrollBehavior.nestedScrollConnection),
         title = {
             TextField(

features/roomlist/src/main/java/io/element/android/x/features/roomlist/components/RoomSummaryRow.kt

@@ -43,11 +43,10 @@ private val minHeight = 72.dp
 
 @Composable
 internal fun RoomSummaryRow(
-    modifier: Modifier = Modifier,
     room: RoomListRoomSummary,
-    onClick: (RoomListRoomSummary) -> Unit
+    modifier: Modifier = Modifier,
+    onClick: (RoomListRoomSummary) -> Unit = {},
 ) {
-
     val clickModifier = if (room.isPlaceholder) {
         modifier
     } else {

features/roomlist/src/main/java/io/element/android/x/features/roomlist/model/stubbed.kt

@@ -1,9 +1,11 @@
 package io.element.android.x.features.roomlist.model
 
 import io.element.android.x.designsystem.components.avatar.AvatarData
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.persistentListOf
 
-internal fun stubbedRoomSummaries(): List<RoomListRoomSummary> {
-    return listOf(
+internal fun stubbedRoomSummaries(): ImmutableList<RoomListRoomSummary> {
+    return persistentListOf(
         RoomListRoomSummary(
             name = "Room",
             hasUnread = true,