fix test for voice call button

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt

@@ -271,7 +271,6 @@ class MessagesPresenter(
 
         return MessagesState(
             roomId = room.roomId,
-            isDm = roomInfo.isDm,
             roomName = roomInfo.name,
             roomAvatar = roomAvatar,
             heroes = heroes,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesState.kt

@@ -32,7 +32,6 @@ import kotlinx.collections.immutable.ImmutableList
 data class MessagesState(
     val roomId: RoomId,
     val roomName: String?,
-    val isDm: Boolean,
     val roomAvatar: AvatarData,
     val heroes: ImmutableList<AvatarData>,
     val userEventPermissions: UserEventPermissions,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesStateProvider.kt

@@ -126,7 +126,6 @@ fun aMessagesState(
 ) = MessagesState(
     roomId = RoomId("!id:domain"),
     roomName = roomName,
-    isDm = false,
     roomAvatar = roomAvatar,
     heroes = persistentListOf(),
     userEventPermissions = userEventPermissions,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/CallMenuItem.kt

@@ -76,7 +76,7 @@ private fun StandByCallMenuItem(
             ) {
                 Icon(
                     imageVector = CompoundIcons.VoiceCallSolid(),
-                    contentDescription = stringResource(CommonStrings.a11y_start_call),
+                    contentDescription = stringResource(CommonStrings.a11y_start_voice_call),
                 )
             }
         }

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesViewTest.kt

@@ -53,6 +53,7 @@ import io.element.android.features.messages.impl.timeline.components.receipt.aRe
 import io.element.android.features.messages.impl.timeline.components.receipt.bottomsheet.ReadReceiptBottomSheetEvent
 import io.element.android.features.messages.impl.timeline.model.TimelineItem
 import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemTextContent
+import io.element.android.features.roomcall.api.aStandByCallState
 import io.element.android.libraries.matrix.api.core.RoomId
 import io.element.android.libraries.matrix.api.core.UserId
 import io.element.android.libraries.matrix.api.room.tombstone.SuccessorRoom
@@ -71,6 +72,7 @@ import io.element.android.tests.testutils.EventsRecorder
 import io.element.android.tests.testutils.assertNoNodeWithText
 import io.element.android.tests.testutils.clickOn
 import io.element.android.tests.testutils.ensureCalledOnce
+import io.element.android.tests.testutils.ensureCalledOnceWithParam
 import io.element.android.tests.testutils.pressBack
 import io.element.android.tests.testutils.setSafeContent
 import kotlinx.collections.immutable.persistentListOf
@@ -122,7 +124,7 @@ class MessagesViewTest {
         val state = aMessagesState(
             eventSink = eventsRecorder
         )
-        ensureCalledOnce { callback ->
+        ensureCalledOnceWithParam(false) { callback ->
             rule.setMessagesView(
                 state = state,
                 onJoinCallClick = callback,
@@ -132,6 +134,23 @@ class MessagesViewTest {
         }
     }
 
+    @Test
+    fun `clicking on join voice call invoke expected callback`() {
+        val eventsRecorder = EventsRecorder<MessagesEvent>(expectEvents = false)
+        val state = aMessagesState(
+            eventSink = eventsRecorder,
+            roomCallState = aStandByCallState(isDM = true)
+        )
+        ensureCalledOnceWithParam(true) { callback ->
+            rule.setMessagesView(
+                state = state,
+                onJoinCallClick = callback,
+            )
+            val joinVoiceCallContentDescription = rule.activity.getString(CommonStrings.a11y_start_voice_call)
+            rule.onNodeWithContentDescription(joinVoiceCallContentDescription).performClick()
+        }
+    }
+
     @Test
     fun `clicking on an Event invoke expected callback`() {
         val eventsRecorder = EventsRecorder<MessagesEvent>(expectEvents = false)
@@ -609,7 +628,7 @@ private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setMessa
     onLinkClick: (String, Boolean) -> Unit = EnsureNeverCalledWithTwoParams(),
     onSendLocationClick: () -> Unit = EnsureNeverCalled(),
     onCreatePollClick: () -> Unit = EnsureNeverCalled(),
-    onJoinCallClick: () -> Unit = EnsureNeverCalled(),
+    onJoinCallClick: (Boolean) -> Unit = EnsureNeverCalledWithParam(),
     onViewAllPinnedMessagesClick: () -> Unit = EnsureNeverCalled(),
 ) {
     setSafeContent {

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/TimelineViewTest.kt

@@ -30,7 +30,6 @@ import io.element.android.libraries.matrix.api.timeline.Timeline
 import io.element.android.libraries.matrix.api.timeline.item.event.MessageShield
 import io.element.android.libraries.matrix.api.user.MatrixUser
 import io.element.android.libraries.ui.strings.CommonStrings
-import io.element.android.tests.testutils.EnsureNeverCalled
 import io.element.android.tests.testutils.EnsureNeverCalledWithParam
 import io.element.android.tests.testutils.EnsureNeverCalledWithTwoParams
 import io.element.android.tests.testutils.EventsRecorder
@@ -186,7 +185,7 @@ private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setTimel
     onReactionLongClick: (emoji: String, TimelineItem.Event) -> Unit = EnsureNeverCalledWithTwoParams(),
     onMoreReactionsClick: (TimelineItem.Event) -> Unit = EnsureNeverCalledWithParam(),
     onReadReceiptClick: (TimelineItem.Event) -> Unit = EnsureNeverCalledWithParam(),
-    onJoinCallClick: () -> Unit = EnsureNeverCalled(),
+    onJoinCallClick: (Boolean) -> Unit = EnsureNeverCalledWithParam(),
     forceJumpToBottomVisibility: Boolean = false,
 ) {
     setSafeContent(clearAndroidUiDispatcher = true) {

libraries/ui-strings/src/main/res/values/localazy.xml

@@ -48,6 +48,7 @@
   <string name="a11y_session_verification_time_limited_action_required">"Time limited action required, you have one minute to verify"</string>
   <string name="a11y_show_password">"Show password"</string>
   <string name="a11y_start_call">"Start a call"</string>
+  <string name="a11y_start_voice_call">"Start a voice call"</string>
   <string name="a11y_tombstoned_room">"Tombstoned room"</string>
   <string name="a11y_user_avatar">"User avatar"</string>
   <string name="a11y_user_menu">"User menu"</string>