More string fiddling

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt

@@ -228,7 +228,7 @@ fun RoomNameWithAvatar(
         LabelledTextField(
             label = stringResource(R.string.screen_create_room_room_name_label),
             value = roomName,
-            placeholder = stringResource(R.string.screen_create_room_room_name_placeholder),
+            placeholder = stringResource(StringR.string.common_room_name_placeholder),
             singleLine = true,
             onValueChange = onRoomNameChanged,
         )
@@ -245,7 +245,7 @@ fun RoomTopic(
         modifier = modifier,
         label = stringResource(R.string.screen_create_room_topic_label),
         value = topic,
-        placeholder = stringResource(R.string.screen_create_room_topic_placeholder),
+        placeholder = stringResource(StringR.string.common_topic_placeholder),
         onValueChange = onTopicChanged,
         maxLines = 3,
     )

features/invitelist/impl/src/main/res/values/localazy.xml

@@ -6,4 +6,4 @@
   <string name="screen_invites_decline_direct_chat_title">"Decline chat"</string>
   <string name="screen_invites_empty_list">"No Invites"</string>
   <string name="screen_invites_invited_you">"%1$s (%2$s) invited you"</string>
-</resources>
+</resources>

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/edit/RoomDetailsEditView.kt

@@ -145,7 +145,7 @@ fun RoomDetailsEditView(
                 LabelledTextField(
                     label = stringResource(id = R.string.screen_room_details_room_name_label),
                     value = state.roomName,
-                    placeholder = stringResource(id = R.string.screen_room_details_room_name_placeholder),
+                    placeholder = stringResource(StringR.string.common_room_name_placeholder),
                     singleLine = true,
                     onValueChange = { state.eventSink(RoomDetailsEditEvents.UpdateRoomName(it)) },
                 )
@@ -160,9 +160,9 @@ fun RoomDetailsEditView(
 
             if (state.canChangeTopic) {
                 LabelledTextField(
-                    label = stringResource(id = StringR.string.common_topic),
+                    label = stringResource(StringR.string.common_topic),
                     value = state.roomTopic,
-                    placeholder = stringResource(id = R.string.screen_room_details_topic_placeholder),
+                    placeholder = stringResource(StringR.string.common_topic_placeholder),
                     maxLines = 10,
                     onValueChange = { state.eventSink(RoomDetailsEditEvents.UpdateRoomTopic(it)) },
                 )

features/roomdetails/impl/src/main/res/values/localazy.xml

@@ -12,6 +12,7 @@
   <string name="screen_room_details_edition_error_title">"Unable to update room"</string>
   <string name="screen_room_details_encryption_enabled_subtitle">"Messages are secured with locks. Only you and the recipients have the unique keys to unlock them."</string>
   <string name="screen_room_details_encryption_enabled_title">"Message encryption enabled"</string>
+  <string name="screen_room_details_invite_people_title">"Invite people"</string>
   <string name="screen_room_details_room_name_label">"Room name"</string>
   <string name="screen_room_details_room_name_placeholder">"e.g. Product Sprint"</string>
   <string name="screen_room_details_share_room_title">"Share room"</string>
@@ -25,7 +26,6 @@
   <string name="screen_dm_details_unblock_alert_action">"Unblock"</string>
   <string name="screen_dm_details_unblock_alert_description">"On unblocking the user, you will be able to see all messages by them again."</string>
   <string name="screen_dm_details_unblock_user">"Unblock user"</string>
-  <string name="screen_room_details_invite_people_title">"Invite friends to Element"</string>
   <string name="screen_room_details_leave_room_title">"Leave room"</string>
   <string name="screen_room_details_people_title">"People"</string>
   <string name="screen_room_details_security_title">"Security"</string>

libraries/ui-strings/src/main/res/values/localazy.xml

@@ -89,6 +89,7 @@
   <string name="common_report_a_bug">"Report a bug"</string>
   <string name="common_report_submitted">"Report submitted"</string>
   <string name="common_room_name">"Room name"</string>
+  <string name="common_room_name_placeholder">"e.g. Product Sprint"</string>
   <string name="common_search_for_someone">"Search for someone"</string>
   <string name="common_search_results">"Search results"</string>
   <string name="common_security">"Security"</string>
@@ -102,6 +103,7 @@
   <string name="common_success">"Success"</string>
   <string name="common_suggestions">"Suggestions"</string>
   <string name="common_topic">"Topic"</string>
+  <string name="common_topic_placeholder">"What is this room about?"</string>
   <string name="common_unable_to_decrypt">"Unable to decrypt"</string>
   <string name="common_unable_to_invite_message">"We were unable to successfully send invites to one or more users."</string>
   <string name="common_unable_to_invite_title">"Unable to send invite(s)"</string>