Remove useless selectedUsers parameter

This commit is contained in:
Florian Renaud
2023-04-13 11:37:17 +02:00
parent 93b06116a3
commit 9cbfa4096a
3 changed files with 7 additions and 10 deletions

View File

@@ -37,7 +37,6 @@ import io.element.android.libraries.architecture.bindings
import io.element.android.libraries.architecture.createNode
import io.element.android.libraries.di.DaggerComponentOwner
import io.element.android.libraries.di.SessionScope
import io.element.android.libraries.matrix.ui.model.MatrixUser
import kotlinx.parcelize.Parcelize
@ContributesNode(SessionScope::class)
@@ -73,7 +72,7 @@ class ConfigureRoomFlowNode @AssistedInject constructor(
return when (navTarget) {
NavTarget.Root -> {
val callback = object : AddPeopleNode.Callback {
override fun onContinue(selectedUsers: List<MatrixUser>) {
override fun onContinue() {
backstack.push(NavTarget.ConfigureRoom)
}
}

View File

@@ -26,7 +26,6 @@ import dagger.assisted.Assisted
import dagger.assisted.AssistedInject
import io.element.android.anvilannotations.ContributesNode
import io.element.android.features.createroom.impl.di.CreateRoomScope
import io.element.android.libraries.matrix.ui.model.MatrixUser
@ContributesNode(CreateRoomScope::class)
class AddPeopleNode @AssistedInject constructor(
@@ -36,11 +35,11 @@ class AddPeopleNode @AssistedInject constructor(
) : Node(buildContext, plugins = plugins) {
interface Callback : Plugin {
fun onContinue(selectedUsers: List<MatrixUser>)
fun onContinue()
}
private fun onContinue(selectedUsers: List<MatrixUser>) {
plugins<Callback>().forEach { it.onContinue(selectedUsers) }
private fun onContinue() {
plugins<Callback>().forEach { it.onContinue() }
}
@Composable
@@ -49,7 +48,7 @@ class AddPeopleNode @AssistedInject constructor(
AddPeopleView(
state = state,
modifier = modifier,
onBackPressed = { navigateUp() },
onBackPressed = this::navigateUp,
onNextPressed = this::onContinue,
)
}

View File

@@ -39,7 +39,6 @@ import io.element.android.libraries.designsystem.theme.components.CenterAlignedT
import io.element.android.libraries.designsystem.theme.components.Scaffold
import io.element.android.libraries.designsystem.theme.components.Text
import io.element.android.libraries.designsystem.theme.components.TextButton
import io.element.android.libraries.matrix.ui.model.MatrixUser
import io.element.android.libraries.ui.strings.R as StringR
@OptIn(ExperimentalMaterial3Api::class)
@@ -48,7 +47,7 @@ fun AddPeopleView(
state: UserListState,
modifier: Modifier = Modifier,
onBackPressed: () -> Unit = {},
onNextPressed: (List<MatrixUser>) -> Unit = {},
onNextPressed: () -> Unit = {},
) {
Scaffold(
topBar = {
@@ -56,7 +55,7 @@ fun AddPeopleView(
AddPeopleViewTopBar(
hasSelectedUsers = state.selectedUsers.isNotEmpty(),
onBackPressed = onBackPressed,
onNextPressed = { onNextPressed(state.selectedUsers) },
onNextPressed = onNextPressed,
)
}
}