letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

change (media preview config) : address review remarks

Browse Source
This commit is contained in:
ganfra
2025-07-01 11:22:03 +02:00
parent 341ae17b72
commit 9b593e4bb9
4 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
appnav/src/main/kotlin/io/element/android/appnav/loggedin/MediaPreviewConfigMigration.kt
View File

@@ -52,7 +52,7 @@ class MediaPreviewConfigMigration @Inject constructor(
}
}
.onFailure {
Timber.d("Couldn't perform migration, failed to fetch media preview config.")
Timber.e(it, "Couldn't perform migration, failed to fetch media preview config.")
}
}
}

11
features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt
View File

@@ -7,7 +7,6 @@
package io.element.android.features.preferences.impl.advanced
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.navigationBarsPadding
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
@@ -143,12 +142,10 @@ private fun ModerationAndSafety(
title = stringResource(R.string.screen_advanced_settings_show_media_timeline_title),
hasDivider = false,
description = {
Row {
ListSupportingText(
text = stringResource(R.string.screen_advanced_settings_show_media_timeline_subtitle),
contentPadding = ListSupportingTextDefaults.Padding.None,
)
}
ListSupportingText(
text = stringResource(R.string.screen_advanced_settings_show_media_timeline_subtitle),
contentPadding = ListSupportingTextDefaults.Padding.None,
)
}
)
ListItem(

6
features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/MediaPreviewConfigStateStore.kt
View File

@@ -88,8 +88,9 @@ class DefaultMediaPreviewConfigStateStore @Inject constructor(
override fun setHideInviteAvatars(hide: Boolean) {
sessionCoroutineScope.launch {
Timber.d("Setting hide invite avatars to $hide")
val prevHideInviteAvatars = hideInviteAvatars.value
if (prevHideInviteAvatars == hide) return@launch
Timber.d("Setting hide invite avatars to $hide")
hideInviteAvatars.value = hide
runUpdatingState(setHideInviteAvatarsAction) {
mediaPreviewService
@@ -104,8 +105,9 @@ class DefaultMediaPreviewConfigStateStore @Inject constructor(
override fun setTimelineMediaPreviewValue(value: MediaPreviewValue) {
sessionCoroutineScope.launch {
Timber.d("Setting timeline media preview value to $value")
val prevTimelineMediaPreviewValue = timelineMediaPreviewValue.value
if (prevTimelineMediaPreviewValue == value) return@launch
Timber.d("Setting timeline media preview value to $value")
timelineMediaPreviewValue.value = value
runUpdatingState(setTimelineMediaPreviewAction) {
mediaPreviewService

2
libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/media/RustMediaPreviewService.kt
View File

@@ -56,7 +56,7 @@ class RustMediaPreviewService(
private fun RustMediaPreviewConfig.into(): MediaPreviewConfig {
return MediaPreviewConfig(
mediaPreviewValue = this@into.mediaPreviews.into(),
mediaPreviewValue = mediaPreviews.into(),
hideInviteAvatar = inviteAvatars == InviteAvatars.OFF
)
}