letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Rename View to follow naming convention and file name

Browse Source
This commit is contained in:
Benoit Marty
2025-08-13 11:21:31 +02:00
parent 519d24d3f0
commit 9411b309d2
3 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
features/startchat/impl/src/main/kotlin/io/element/android/features/startchat/impl/root/StartChatNode.kt
View File

@@ -46,7 +46,7 @@ class StartChatNode @AssistedInject constructor(
override fun View(modifier: Modifier) {
val state = presenter.present()
val activity = requireNotNull(LocalActivity.current)
CreateRoomRootView(
StartChatView(
state = state,
modifier = modifier,
onCloseClick = this::navigateUp,

6
features/startchat/impl/src/main/kotlin/io/element/android/features/startchat/impl/root/StartChatView.kt
View File

@@ -48,7 +48,7 @@ import io.element.android.libraries.ui.strings.CommonStrings
import kotlinx.collections.immutable.persistentListOf
@Composable
fun CreateRoomRootView(
fun StartChatView(
state: StartChatState,
onCloseClick: () -> Unit,
onNewRoomClick: () -> Unit,
@@ -239,9 +239,9 @@ private fun CreateRoomActionButton(
@PreviewsDayNight
@Composable
internal fun CreateRoomRootViewPreview(@PreviewParameter(StartChatStateProvider::class) state: StartChatState) =
internal fun StartChatViewPreview(@PreviewParameter(StartChatStateProvider::class) state: StartChatState) =
ElementPreview {
CreateRoomRootView(
StartChatView(
state = state,
onCloseClick = {},
onNewRoomClick = {},

18
features/startchat/impl/src/test/kotlin/io/element/android/features/startchat/impl/root/CreateBaseRoomRootViewTest.kt → features/startchat/impl/src/test/kotlin/io/element/android/features/startchat/impl/root/StartChatViewTest.kt
View File

@@ -34,7 +34,7 @@ import org.robolectric.annotation.Config
import kotlin.collections.get
@RunWith(AndroidJUnit4::class)
class CreateBaseRoomRootViewTest {
class StartChatViewTest {
@get:Rule
val rule = createAndroidComposeRule<ComponentActivity>()
@@ -42,7 +42,7 @@ class CreateBaseRoomRootViewTest {
fun `clicking on back invokes the expected callback`() {
val eventsRecorder = EventsRecorder<StartChatEvents>(expectEvents = false)
ensureCalledOnce {
rule.setCreateRoomRootView(
rule.setStartChatView(
aCreateRoomRootState(
eventSink = eventsRecorder,
),
@@ -56,7 +56,7 @@ class CreateBaseRoomRootViewTest {
fun `clicking on New room invokes the expected callback`() {
val eventsRecorder = EventsRecorder<StartChatEvents>(expectEvents = false)
ensureCalledOnce {
rule.setCreateRoomRootView(
rule.setStartChatView(
aCreateRoomRootState(
eventSink = eventsRecorder,
),
@@ -71,7 +71,7 @@ class CreateBaseRoomRootViewTest {
fun `clicking on Invite people invokes the expected callback`() {
val eventsRecorder = EventsRecorder<StartChatEvents>(expectEvents = false)
ensureCalledOnce {
rule.setCreateRoomRootView(
rule.setStartChatView(
aCreateRoomRootState(
applicationName = "test",
eventSink = eventsRecorder,
@@ -90,7 +90,7 @@ class CreateBaseRoomRootViewTest {
val firstRoom = recentDirectRoomList[0]
val eventsRecorder = EventsRecorder<StartChatEvents>(expectEvents = false)
ensureCalledOnceWithParam(firstRoom.roomId) {
rule.setCreateRoomRootView(
rule.setStartChatView(
aCreateRoomRootState(
userListState = aUserListState(
recentDirectRooms = recentDirectRoomList
@@ -108,7 +108,7 @@ class CreateBaseRoomRootViewTest {
fun `clicking on Join room by address invokes the expected callback`() {
val eventsRecorder = EventsRecorder<StartChatEvents>(expectEvents = false)
ensureCalledOnce {
rule.setCreateRoomRootView(
rule.setStartChatView(
aCreateRoomRootState(
eventSink = eventsRecorder,
),
@@ -122,7 +122,7 @@ class CreateBaseRoomRootViewTest {
fun `clicking on room directory invokes the expected callback`() {
val eventsRecorder = EventsRecorder<StartChatEvents>(expectEvents = false)
ensureCalledOnce {
rule.setCreateRoomRootView(
rule.setStartChatView(
aCreateRoomRootState(
eventSink = eventsRecorder,
isRoomDirectorySearchEnabled = true
@@ -134,7 +134,7 @@ class CreateBaseRoomRootViewTest {
}
}
private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setCreateRoomRootView(
private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setStartChatView(
state: StartChatState,
onCloseClick: () -> Unit = EnsureNeverCalled(),
onNewRoomClick: () -> Unit = EnsureNeverCalled(),
@@ -144,7 +144,7 @@ private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setCreat
onRoomDirectorySearchClick: () -> Unit = EnsureNeverCalled(),
) {
setContent {
CreateRoomRootView(
StartChatView(
state = state,
onCloseClick = onCloseClick,
onNewRoomClick = onNewRoomClick,