Bug reporter crashes when 'send logs' is disabled. (#1184)

* Bug reporter crashes when 'send logs' is disabled.

* Make sure generated files are cleaned up when uploading the logs fails.
This commit is contained in:
Jorge Martin Espinosa
2023-08-30 12:49:58 +02:00
committed by GitHub
parent e67c7ac9f1
commit 7929181c0f
2 changed files with 6 additions and 4 deletions

1
changelog.d/1168.bugfix Normal file
View File

@@ -0,0 +1 @@
Bug reporter crashes when 'send logs' is disabled.

View File

@@ -268,12 +268,13 @@ class DefaultBugReporter @Inject constructor(
}
}
if (!uploadedSomeLogs) {
error("Couldn't upload any logs")
}
mBugReportFiles.addAll(gzippedFiles)
if (gzippedFiles.isNotEmpty() && !uploadedSomeLogs) {
serverError = "Couldn't upload any logs, please retry."
return@withContext
}
if (withScreenshot) {
screenshotHolder.getFileUri()
?.toUri()