Replace textPlaceholder color usages with textSecondary (#3873)

* Replace `textPlaceholder` color usages with `textSecondary`

* Update screenshots

---------

Co-authored-by: ElementBot <android@element.io>

features/roomdirectory/impl/src/main/kotlin/io/element/android/features/roomdirectory/impl/root/RoomDirectoryView.kt

@@ -145,7 +145,7 @@ private fun RoomDirectoryRoomList(
                 Text(
                     text = stringResource(id = CommonStrings.common_no_results),
                     style = ElementTheme.typography.fontBodyLgRegular,
-                    color = ElementTheme.colors.textPlaceholder,
+                    color = ElementTheme.colors.textSecondary,
                     modifier = Modifier.padding(16.dp)
                 )
             }
@@ -185,8 +185,8 @@ private fun SearchTextField(
     colors: TextFieldColors = TextFieldDefaults.colors(
         focusedContainerColor = Color.Transparent,
         unfocusedContainerColor = Color.Transparent,
-        unfocusedPlaceholderColor = ElementTheme.colors.textPlaceholder,
-        focusedPlaceholderColor = ElementTheme.colors.textPlaceholder,
+        unfocusedPlaceholderColor = ElementTheme.colors.textSecondary,
+        focusedPlaceholderColor = ElementTheme.colors.textSecondary,
         focusedTextColor = ElementTheme.colors.textPrimary,
         unfocusedTextColor = ElementTheme.colors.textPrimary,
         focusedIndicatorColor = ElementTheme.colors.borderInteractiveSecondary,

libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/atomic/molecules/NumberedListMolecule.kt

@@ -41,7 +41,7 @@ fun NumberedListMolecule(
 private fun ItemNumber(
     index: Int,
 ) {
-    val color = ElementTheme.colors.textPlaceholder
+    val color = ElementTheme.colors.textSecondary
     Box(
         modifier = Modifier
             .border(1.dp, color, CircleShape)

libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/TextField.kt

@@ -200,7 +200,7 @@ private fun DecorationBox(
                     if (placeholder != null && isTextEmpty) {
                         Text(
                             text = placeholder,
-                            color = ElementTheme.colors.textPlaceholder,
+                            color = ElementTheme.colors.textSecondary,
                             style = ElementTheme.typography.fontBodyLgRegular,
                         )
                     }