Enable Element Call integration in rooms by default (#1685)

Also change base url to `call.element.dev`.

appconfig/src/main/kotlin/io/element/android/appconfig/ElementCallConfig.kt

@@ -17,5 +17,5 @@
 package io.element.android.appconfig
 
 object ElementCallConfig {
-    const val DEFAULT_BASE_URL = "https://call.element.io"
+    const val DEFAULT_BASE_URL = "https://call.element.dev"
 }

changelog.d/+enable-element-call.feature

@@ -0,0 +1 @@
+Enable Element Call integration in rooms by default.

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsPresenter.kt

@@ -82,7 +82,7 @@ class AdvancedSettingsPresenter @Inject constructor(
                     validator = ::customElementCallUrlValidator,
                 )
             } else null,
-            eventSink = ::handleEvents
+            eventSink = { handleEvents(it) }
         )
     }
 

features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsPresenterTest.kt

@@ -44,6 +44,7 @@ class AdvancedSettingsPresenterTest {
             val initialState = awaitItem()
             assertThat(initialState.isDeveloperModeEnabled).isFalse()
             assertThat(initialState.isRichTextEditorEnabled).isFalse()
+            assertThat(initialState.customElementCallBaseUrlState).isNull()
         }
     }
 
@@ -99,9 +100,7 @@ class AdvancedSettingsPresenterTest {
     @Test
     fun `present - custom element call base url`() = runTest {
         val store = InMemoryPreferencesStore()
-        val featureFlagService = FakeFeatureFlagService().apply {
-            setFeatureEnabled(FeatureFlags.InRoomCalls, true)
-        }
+        val featureFlagService = FakeFeatureFlagService(initialState = hashMapOf(FeatureFlags.InRoomCalls.key to true))
         val presenter = AdvancedSettingsPresenter(store, featureFlagService)
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
@@ -113,9 +112,9 @@ class AdvancedSettingsPresenterTest {
             assertThat(initialState.customElementCallBaseUrlState).isNotNull()
             assertThat(initialState.customElementCallBaseUrlState?.baseUrl).isNull()
 
-            initialState.eventSink(AdvancedSettingsEvents.SetCustomElementCallBaseUrl("https://call.element.dev"))
+            initialState.eventSink(AdvancedSettingsEvents.SetCustomElementCallBaseUrl("https://call.element.ahoy"))
             val updatedItem = awaitItem()
-            assertThat(updatedItem.customElementCallBaseUrlState?.baseUrl).isEqualTo("https://call.element.dev")
+            assertThat(updatedItem.customElementCallBaseUrlState?.baseUrl).isEqualTo("https://call.element.ahoy")
         }
     }
 

libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt

@@ -59,7 +59,7 @@ enum class FeatureFlags(
         key = "feature.elementcall",
         title = "Element call in rooms",
         description = "Allow user to start or join a call in a room",
-        defaultValue = false,
+        defaultValue = true,
     ),
     Mentions(
         key = "feature.mentions",

libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/StaticFeatureFlagProvider.kt

@@ -37,7 +37,7 @@ class StaticFeatureFlagProvider @Inject constructor() :
                 FeatureFlags.NotificationSettings -> true
                 FeatureFlags.VoiceMessages -> true
                 FeatureFlags.PinUnlock -> false
-                FeatureFlags.InRoomCalls -> false
+                FeatureFlags.InRoomCalls -> true
                 FeatureFlags.Mentions -> false
             }
         } else {

libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt

@@ -31,6 +31,6 @@ class FakeFeatureFlagService(
     }
 
     override suspend fun isFeatureEnabled(feature: Feature): Boolean {
-        return enabledFeatures[feature.key] ?: feature.defaultValue
+        return enabledFeatures[feature.key] ?: false
     }
 }