Update dependency io.nlopez.compose.rules:detekt to v0.4.8 (#3254)

* Update dependency io.nlopez.compose.rules:detekt to v0.4.8

* Fix new lint issues

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jorge Martín <jorgem@element.io>

build.gradle.kts

@@ -61,7 +61,7 @@ allprojects {
         config.from(files("$rootDir/tools/detekt/detekt.yml"))
     }
     dependencies {
-        detektPlugins("io.nlopez.compose.rules:detekt:0.4.5")
+        detektPlugins("io.nlopez.compose.rules:detekt:0.4.8")
     }
 
     // KtLint

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/ExpandableBottomSheetScaffold.kt

@@ -58,7 +58,11 @@ import kotlin.math.roundToInt
  * @param modifier The modifier for the layout.
  * @param sheetContentKey The key for the sheet content. If the key changes, the sheet will be remeasured.
  */
-@Suppress("ContentTrailingLambda")
+@Suppress(
+    "ContentTrailingLambda",
+    // False positive
+    "MultipleEmitters",
+)
 @OptIn(ExperimentalMaterial3Api::class)
 @Composable
 internal fun ExpandableBottomSheetScaffold(

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt

@@ -218,6 +218,7 @@ private fun SheetContent(
     }
 }
 
+@Suppress("MultipleEmitters") // False positive
 @Composable
 private fun MessageSummary(event: TimelineItem.Event, modifier: Modifier = Modifier) {
     val content: @Composable () -> Unit

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/TimelineItemEventRow.kt

@@ -376,6 +376,7 @@ private fun MessageSenderInformation(
     }
 }
 
+@Suppress("MultipleEmitters") // False positive
 @Composable
 private fun MessageEventBubbleContent(
     event: TimelineItem.Event,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/TimelineItemReactionsLayout.kt

@@ -110,7 +110,7 @@ fun TimelineItemReactionsLayout(
             }
             val rows = rowsIn.toMutableList()
             val secondLastRow = rows[rows.size - 2].toMutableList()
-            val expandButtonPlaceable = secondLastRow.removeLast()
+            val expandButtonPlaceable = secondLastRow.removeAt(secondLastRow.lastIndex)
             lastRow.add(0, expandButtonPlaceable)
             rows[rows.size - 2] = secondLastRow
             rows[rows.size - 1] = lastRow

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/typing/TypingNotificationView.kt

@@ -53,6 +53,7 @@ import io.element.android.libraries.designsystem.theme.components.Text
 import io.element.android.libraries.matrix.api.room.RoomMember
 import kotlinx.collections.immutable.ImmutableList
 
+@Suppress("MultipleEmitters") // False positive
 @Composable
 fun TypingNotificationView(
     state: TypingNotificationState,

libraries/roomselect/impl/src/main/kotlin/io/element/android/libraries/roomselect/impl/RoomSelectView.kt

@@ -64,6 +64,7 @@ import io.element.android.libraries.ui.strings.CommonStrings
 import kotlinx.collections.immutable.ImmutableList
 import kotlinx.collections.immutable.toPersistentList
 
+@Suppress("MultipleEmitters") // False positive
 @OptIn(ExperimentalMaterial3Api::class)
 @Composable
 fun RoomSelectView(

libraries/troubleshoot/impl/src/main/kotlin/io/element/android/libraries/troubleshoot/impl/TroubleshootNotificationsView.kt

@@ -16,6 +16,7 @@
 
 package io.element.android.libraries.troubleshoot.impl
 
+import androidx.compose.foundation.layout.ColumnScope
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.progressSemantics
@@ -68,7 +69,7 @@ fun TroubleshootNotificationsView(
 }
 
 @Composable
-private fun TroubleshootTestView(
+private fun ColumnScope.TroubleshootTestView(
     testState: NotificationTroubleshootTestState,
     onQuickFixClick: () -> Unit,
 ) {
@@ -127,7 +128,7 @@ private fun TroubleshootTestView(
 }
 
 @Composable
-private fun TroubleshootNotificationsContent(state: TroubleshootNotificationsState) {
+private fun ColumnScope.TroubleshootNotificationsContent(state: TroubleshootNotificationsState) {
     when (state.testSuiteState.mainState) {
         AsyncAction.Loading,
         AsyncAction.Confirming,
@@ -197,7 +198,7 @@ private fun RunTestButton(state: TroubleshootNotificationsState) {
 }
 
 @Composable
-private fun TestSuiteView(
+private fun ColumnScope.TestSuiteView(
     testSuiteState: TroubleshootTestSuiteState,
     onQuickFixClick: (Int) -> Unit,
 ) {