Update the strings for the device verification flow (#5419)

* Update the strings for the device verification flow

Part of https://github.com/element-hq/element-meta/issues/2898

.maestro/tests/account/verifySession.yaml

@@ -8,6 +8,6 @@ appId: ${MAESTRO_APP_ID}
 - hideKeyboard
 - tapOn: "Continue"
 - extendedWaitUntil:
-    visible: "Verification complete"
+    visible: "Device verified"
     timeout: 30000
 - tapOn: "Continue"

features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationView.kt

@@ -238,7 +238,7 @@ private fun IncomingVerificationBottomMenu(
                 VerificationBottomMenu {
                     Button(
                         modifier = Modifier.fillMaxWidth(),
-                        text = stringResource(CommonStrings.action_start),
+                        text = stringResource(CommonStrings.action_start_verification),
                         onClick = { eventSink(IncomingVerificationViewEvents.StartVerification) },
                     )
                     TextButton(

features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/outgoing/OutgoingVerificationView.kt

@@ -157,7 +157,10 @@ private fun OutgoingVerificationHeader(step: Step, request: VerificationRequest.
         }
         Step.Canceled -> CommonStrings.common_verification_failed
         Step.Ready -> R.string.screen_session_verification_compare_emojis_title
-        Step.Completed -> CommonStrings.common_verification_complete
+        Step.Completed -> when (request) {
+            is VerificationRequest.Outgoing.CurrentSession -> R.string.screen_session_verification_device_verified
+            is VerificationRequest.Outgoing.User -> CommonStrings.common_verification_complete
+        }
         is Step.Verifying -> when (step.data) {
             is SessionVerificationData.Decimals -> R.string.screen_session_verification_compare_numbers_title
             is SessionVerificationData.Emojis -> R.string.screen_session_verification_compare_emojis_title

features/verifysession/impl/src/test/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationViewTest.kt

@@ -62,7 +62,7 @@ class IncomingVerificationViewTest {
                 eventSink = eventsRecorder
             ),
         )
-        rule.clickOn(CommonStrings.action_start)
+        rule.clickOn(CommonStrings.action_start_verification)
         eventsRecorder.assertSingle(IncomingVerificationViewEvents.StartVerification)
     }