Rename method.
This commit is contained in:
committed by
Benoit Marty
parent
2b42271615
commit
4daf57ab2d
@@ -33,7 +33,7 @@ class DefaultIntentProvider @Inject constructor(
|
||||
): Intent {
|
||||
return Intent(context, MainActivity::class.java).apply {
|
||||
action = Intent.ACTION_VIEW
|
||||
data = deepLinkCreator.room(sessionId, roomId, threadId).toUri()
|
||||
data = deepLinkCreator.create(sessionId, roomId, threadId).toUri()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -12,5 +12,5 @@ import io.element.android.libraries.matrix.api.core.SessionId
|
||||
import io.element.android.libraries.matrix.api.core.ThreadId
|
||||
|
||||
fun interface DeepLinkCreator {
|
||||
fun room(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String
|
||||
fun create(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String
|
||||
}
|
||||
|
||||
@@ -17,7 +17,7 @@ import javax.inject.Inject
|
||||
|
||||
@ContributesBinding(AppScope::class)
|
||||
class DefaultDeepLinkCreator @Inject constructor() : DeepLinkCreator {
|
||||
override fun room(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String {
|
||||
override fun create(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String {
|
||||
return buildString {
|
||||
append("$SCHEME://$HOST/")
|
||||
append(sessionId.value)
|
||||
|
||||
@@ -15,13 +15,13 @@ import org.junit.Test
|
||||
|
||||
class DefaultDeepLinkCreatorTest {
|
||||
@Test
|
||||
fun room() {
|
||||
fun create() {
|
||||
val sut = DefaultDeepLinkCreator()
|
||||
assertThat(sut.room(A_SESSION_ID, null, null))
|
||||
assertThat(sut.create(A_SESSION_ID, null, null))
|
||||
.isEqualTo("elementx://open/@alice:server.org")
|
||||
assertThat(sut.room(A_SESSION_ID, A_ROOM_ID, null))
|
||||
assertThat(sut.create(A_SESSION_ID, A_ROOM_ID, null))
|
||||
.isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain")
|
||||
assertThat(sut.room(A_SESSION_ID, A_ROOM_ID, A_THREAD_ID))
|
||||
assertThat(sut.create(A_SESSION_ID, A_ROOM_ID, A_THREAD_ID))
|
||||
.isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain/\$aThreadId")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user