letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

Use produceState and fetch profile only if necessary.

Browse Source
This commit is contained in:
Benoit Marty
2024-04-17 16:15:36 +02:00
parent 57072c3e6a
commit 291983f6bc
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/details/RoomMemberDetailsPresenter.kt
View File

@@ -21,6 +21,7 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.MutableState
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.produceState
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
@@ -74,9 +75,10 @@ class RoomMemberDetailsPresenter @AssistedInject constructor(
// Update room member info when opening this screen
// We don't need to assign the result as it will be automatically propagated by `room.getRoomMemberAsState`
room.getUpdatedMember(roomMemberId)
}
LaunchedEffect(Unit) {
userProfile = client.getProfile(roomMemberId).getOrNull()
.onFailure {
// Not a member of the room, try to get the user profile
userProfile = client.getProfile(roomMemberId).getOrNull()
}
}
fun handleEvents(event: RoomMemberDetailsEvents) {
@@ -112,9 +114,12 @@ class RoomMemberDetailsPresenter @AssistedInject constructor(
}
}
var userName: String? by remember { mutableStateOf(roomMember?.displayName ?: userProfile?.displayName) }
LaunchedEffect(roomMember, userProfile) {
userName = room.userDisplayName(roomMemberId)
val userName: String? by produceState(
initialValue = roomMember?.displayName ?: userProfile?.displayName,
key1 = roomMember,
key2 = userProfile,
) {
value = room.userDisplayName(roomMemberId)
.fold(
onSuccess = { it },
onFailure = {
@@ -124,9 +129,12 @@ class RoomMemberDetailsPresenter @AssistedInject constructor(
)
}
var userAvatar: String? by remember { mutableStateOf(roomMember?.avatarUrl ?: userProfile?.avatarUrl) }
LaunchedEffect(roomMember, userProfile) {
userAvatar = room.userAvatarUrl(roomMemberId)
val userAvatar: String? by produceState(
initialValue = roomMember?.avatarUrl ?: userProfile?.avatarUrl,
key1 = roomMember,
key2 = userProfile,
) {
value = room.userAvatarUrl(roomMemberId)
.fold(
onSuccess = { it },
onFailure = {