Moar fixes

This commit is contained in:
Benoit Marty
2023-06-08 10:32:24 +02:00
committed by Benoit Marty
parent de31591eba
commit 248d0bad83
2 changed files with 15 additions and 28 deletions

View File

@@ -56,7 +56,7 @@ import io.element.android.libraries.designsystem.theme.components.TopAppBar
fun ChangeAccountProviderView(
state: ChangeAccountProviderState,
modifier: Modifier = Modifier,
onBackPressed: () -> Unit,
onBackPressed: () -> Unit = {},
onAccountProviderClicked: (AccountProvider) -> Unit = {},
onOtherProviderClicked: () -> Unit = {},
) {

View File

@@ -133,11 +133,22 @@ fun LoginPasswordView(
subTitle = stringResource(id = R.string.screen_login_form_header)
)
Spacer(Modifier.height(32.dp))
ServerDetailForm(
state = state,
LoginForm(state = state,
isLoading = isLoading,
submit = ::submit
onSubmit = ::submit
)
Spacer(Modifier.height(28.dp))
// Submit
ButtonWithProgress(
text = stringResource(R.string.screen_login_submit),
showProgress = isLoading,
onClick = ::submit,
enabled = state.submitEnabled,
modifier = Modifier
.fillMaxWidth()
.testTag(TestTags.loginContinue)
)
Spacer(modifier = Modifier.height(32.dp))
}
if (state.loginAction is Async.Failure) {
@@ -149,30 +160,6 @@ fun LoginPasswordView(
}
}
@Composable
fun ServerDetailForm(
state: LoginPasswordState,
isLoading: Boolean,
submit: () -> Unit,
modifier: Modifier = Modifier,
) {
LoginForm(state = state, isLoading = isLoading, onSubmit = submit, modifier = modifier)
Spacer(Modifier.height(28.dp))
// Submit
ButtonWithProgress(
text = stringResource(R.string.screen_login_submit),
showProgress = isLoading,
onClick = submit,
enabled = state.submitEnabled,
modifier = Modifier
.fillMaxWidth()
.testTag(TestTags.loginContinue)
)
Spacer(modifier = Modifier.height(32.dp))
}
@OptIn(ExperimentalComposeUiApi::class)
@Composable
internal fun LoginForm(