letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Rename function (code review)

Browse Source
This commit is contained in:
Benoit Marty
2023-01-25 11:14:50 +01:00
parent 9cac97784e
commit 15700062c7
6 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/kotlin/io/element/android/x/node/LoggedInFlowNode.kt
View File

@@ -34,7 +34,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
import com.bumble.appyx.navmodel.backstack.operation.push
import io.element.android.features.preferences.PreferencesFlowNode
import io.element.android.features.roomlist.RoomListNode
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
import io.element.android.libraries.architecture.bindings
import io.element.android.libraries.architecture.createNode
import io.element.android.libraries.di.DaggerComponentOwner
@@ -129,7 +129,7 @@ class LoggedInFlowNode(
navModel = backstack,
modifier = modifier,
// Animate navigation to settings and to a room
transitionHandler = getDefaultTransitionHandler(),
transitionHandler = rememberDefaultTransitionHandler(),
)
}
}

4
app/src/main/kotlin/io/element/android/x/node/NotLoggedInFlowNode.kt
View File

@@ -29,7 +29,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
import com.bumble.appyx.navmodel.backstack.operation.push
import io.element.android.features.login.LoginFlowNode
import io.element.android.features.onboarding.OnBoardingScreen
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
import kotlinx.parcelize.Parcelize
import timber.log.Timber
@@ -76,7 +76,7 @@ class NotLoggedInFlowNode(
navModel = backstack,
modifier = modifier,
// Animate navigation to login screen
transitionHandler = getDefaultTransitionHandler(),
transitionHandler = rememberDefaultTransitionHandler(),
)
}
}

4
app/src/main/kotlin/io/element/android/x/node/RootFlowNode.kt
View File

@@ -37,7 +37,7 @@ import com.bumble.appyx.navmodel.backstack.operation.newRoot
import com.bumble.appyx.navmodel.backstack.operation.pop
import com.bumble.appyx.navmodel.backstack.operation.push
import io.element.android.features.rageshake.bugreport.BugReportNode
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
import io.element.android.libraries.architecture.createNode
import io.element.android.libraries.architecture.presenterConnector
import io.element.android.libraries.di.DaggerComponentOwner
@@ -114,7 +114,7 @@ class RootFlowNode(
Children(
navModel = backstack,
// Animate opening the bug report screen
transitionHandler = getDefaultTransitionHandler(),
transitionHandler = rememberDefaultTransitionHandler(),
)
}
}

4
features/login/src/main/kotlin/io/element/android/features/login/LoginFlowNode.kt
View File

@@ -27,7 +27,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
import com.bumble.appyx.navmodel.backstack.operation.push
import io.element.android.features.login.changeserver.ChangeServerNode
import io.element.android.features.login.root.LoginRootNode
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
import io.element.android.libraries.architecture.createNode
import kotlinx.parcelize.Parcelize
@@ -69,7 +69,7 @@ class LoginFlowNode(
navModel = backstack,
modifier = modifier,
// Animate transition to change server screen
transitionHandler = getDefaultTransitionHandler(),
transitionHandler = rememberDefaultTransitionHandler(),
)
}
}

4
features/preferences/src/main/kotlin/io/element/android/features/preferences/PreferencesFlowNode.kt
View File

@@ -25,7 +25,7 @@ import com.bumble.appyx.core.node.Node
import com.bumble.appyx.core.node.ParentNode
import com.bumble.appyx.navmodel.backstack.BackStack
import io.element.android.features.preferences.root.PreferencesRootNode
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
import io.element.android.libraries.architecture.createNode
import kotlinx.parcelize.Parcelize
@@ -63,7 +63,7 @@ class PreferencesFlowNode(
Children(
navModel = backstack,
modifier = modifier,
transitionHandler = getDefaultTransitionHandler()
transitionHandler = rememberDefaultTransitionHandler()
)
}
}

2
libraries/architecture/src/main/kotlin/io/element/android/libraries/architecture/animation/ScreenTransition.kt
View File

@@ -24,7 +24,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
import com.bumble.appyx.navmodel.backstack.transitionhandler.rememberBackstackSlider
@Composable
fun <NavTarget> getDefaultTransitionHandler(): ModifierTransitionHandler<NavTarget, BackStack.State> {
fun <NavTarget> rememberDefaultTransitionHandler(): ModifierTransitionHandler<NavTarget, BackStack.State> {
return rememberBackstackSlider(
transitionSpec = { spring(stiffness = Spring.StiffnessMediumLow) },
)