letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Convert forbiddenTerms to a dict, and improve the output format.

Browse Source
This commit is contained in:
Benoit Marty
2024-04-10 17:04:08 +02:00
parent 650a2b84a1
commit 152d69ccf4
1 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tools/localazy/checkForbiddenTerms.py
View File

@@ -5,21 +5,19 @@ from xml.dom import minidom
file = sys.argv[1]
# Arrays of forbidden terms, with exceptions for some keys
forbiddenTerms = [
[
"Element",
[
# Those 2 strings are only used in debug version
"screen_advanced_settings_element_call_base_url",
"screen_advanced_settings_element_call_base_url_description",
# only used for element.io homeserver, so it's fine
"screen_server_confirmation_message_login_element_dot_io",
# "Be in your element", will probably be changed on the forks, so we can ignore.
"screen_onboarding_welcome_title",
]
# Dict of forbidden terms, with exceptions for some String name
# Keys are the terms, values are the exceptions.
forbiddenTerms = {
"Element": [
# Those 2 strings are only used in debug version
"screen_advanced_settings_element_call_base_url",
"screen_advanced_settings_element_call_base_url_description",
# only used for element.io homeserver, so it's fine
"screen_server_confirmation_message_login_element_dot_io",
# "Be in your element", will probably be changed on the forks, so we can ignore.
"screen_onboarding_welcome_title",
]
]
}
content = minidom.parse(file)
@@ -35,9 +33,9 @@ for elem in content.getElementsByTagName('string'):
continue
value = child.nodeValue
# If value contains a forbidden term, add the error to errors
for (term, exceptions) in forbiddenTerms:
for (term, exceptions) in forbiddenTerms.items():
if term in value and name not in exceptions:
errors.append('Forbidden term "' + term + '" in string: ' + name + ": " + value)
errors.append('Forbidden term "' + term + '" in string: "' + name + '": ' + value)
### Plurals
for elem in content.getElementsByTagName('plurals'):
@@ -52,9 +50,9 @@ for elem in content.getElementsByTagName('plurals'):
continue
value = child.nodeValue
# If value contains a forbidden term, add the error to errors
for (term, exceptions) in forbiddenTerms:
for (term, exceptions) in forbiddenTerms.items():
if term in value and name not in exceptions:
errors.append('Forbidden term "' + term + '" in plural: ' + name + ": " + value)
errors.append('Forbidden term "' + term + '" in plural: "' + name + '": ' + value)
# If errors is not empty print the report
if errors: