New copy for members search results (#430)

* New copy for members search results

Context: https://matrix.to/#/!dypRwVXIkJaTAACHPd:element.io/$Obt7MbgGtHBqJHpZqcdd6OQ5XgxxNXSJofnFG1NyWWM?via=matrix.org&via=element.io&via=t2l.io

Related to: https://github.com/vector-im/element-x-android/issues/246

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt

@@ -113,7 +113,8 @@ fun RoomMemberListView(
                 if (state.roomMembers is Async.Success) {
                     RoomMemberList(
                         roomMembers = state.roomMembers.state,
-                        onUserSelected = ::onUserSelected,
+                        showMembersCount = true,
+                        onUserSelected = ::onUserSelected
                     )
                 } else if (state.roomMembers.isLoading()) {
                     Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
@@ -128,6 +129,7 @@ fun RoomMemberListView(
 @Composable
 private fun RoomMemberList(
     roomMembers: RoomMembers,
+    showMembersCount: Boolean,
     onUserSelected: (RoomMember) -> Unit,
 ) {
     LazyColumn(modifier = Modifier.fillMaxWidth(), state = rememberLazyListState()) {
@@ -139,9 +141,15 @@ private fun RoomMemberList(
             )
         }
         if (roomMembers.joined.isNotEmpty()) {
-            val memberCount = roomMembers.joined.count()
             roomMemberListSection(
-                headerText = { pluralStringResource(id = R.plurals.screen_room_member_list_header_title, count = memberCount, memberCount) },
+                headerText = {
+                    if (showMembersCount) {
+                        val memberCount = roomMembers.joined.count()
+                        pluralStringResource(id = R.plurals.screen_room_member_list_header_title, count = memberCount, memberCount)
+                    } else {
+                        stringResource(id = R.string.screen_room_member_list_room_members_header_title)
+                    }
+                },
                 members = roomMembers.joined,
                 onMemberSelected = { onUserSelected(it) }
             )
@@ -272,7 +280,8 @@ private fun RoomMemberSearchBar(
             if (state is RoomMemberSearchResultState.Results) {
                 RoomMemberList(
                     roomMembers = state.results,
-                    onUserSelected = { onUserSelected(it) }
+                    showMembersCount = false,
+                    onUserSelected = onUserSelected
                 )
             } else if (state is RoomMemberSearchResultState.NoResults) {
                 Spacer(Modifier.size(80.dp))

features/roomdetails/impl/src/main/res/values/localazy.xml

@@ -1,24 +1,25 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
-    <plurals name="screen_room_member_list_header_title">
-        <item quantity="one">"1 person"</item>
-        <item quantity="other">"%1$d people"</item>
-    </plurals>
-    <string name="screen_room_details_already_a_member">"Already a member"</string>
-    <string name="screen_room_details_already_invited">"Already invited"</string>
-    <string name="screen_room_details_encryption_enabled_subtitle">"Messages are secured with locks. Only you and the recipients have the unique keys to unlock them."</string>
-    <string name="screen_room_details_encryption_enabled_title">"Message encryption enabled"</string>
-    <string name="screen_room_details_share_room_title">"Share room"</string>
-    <string name="screen_room_member_list_pending_header_title">"Pending"</string>
-    <string name="screen_dm_details_block_alert_action">"Block"</string>
-    <string name="screen_dm_details_block_alert_description">"Blocked users will not be able to send you messages and all message by them will be hidden. You can reverse this action anytime."</string>
-    <string name="screen_dm_details_block_user">"Block user"</string>
-    <string name="screen_dm_details_unblock_alert_action">"Unblock"</string>
-    <string name="screen_dm_details_unblock_alert_description">"On unblocking the user, you will be able to see all messages by them again."</string>
-    <string name="screen_dm_details_unblock_user">"Unblock user"</string>
+  <plurals name="screen_room_member_list_header_title">
+    <item quantity="one">"1 person"</item>
+    <item quantity="other">"%1$d people"</item>
+  </plurals>
+  <string name="screen_room_details_already_a_member">"Already a member"</string>
+  <string name="screen_room_details_already_invited">"Already invited"</string>
+  <string name="screen_room_details_encryption_enabled_subtitle">"Messages are secured with locks. Only you and the recipients have the unique keys to unlock them."</string>
+  <string name="screen_room_details_encryption_enabled_title">"Message encryption enabled"</string>
+  <string name="screen_room_details_share_room_title">"Share room"</string>
+  <string name="screen_room_member_list_pending_header_title">"Pending"</string>
+  <string name="screen_room_member_list_room_members_header_title">"Room members"</string>
+  <string name="screen_dm_details_block_alert_action">"Block"</string>
+  <string name="screen_dm_details_block_alert_description">"Blocked users will not be able to send you messages and all message by them will be hidden. You can reverse this action anytime."</string>
+  <string name="screen_dm_details_block_user">"Block user"</string>
+  <string name="screen_dm_details_unblock_alert_action">"Unblock"</string>
+  <string name="screen_dm_details_unblock_alert_description">"On unblocking the user, you will be able to see all messages by them again."</string>
+  <string name="screen_dm_details_unblock_user">"Unblock user"</string>
   <string name="screen_room_details_invite_people_title">"Invite people"</string>
   <string name="screen_room_details_leave_room_title">"Leave room"</string>
   <string name="screen_room_details_people_title">"People"</string>
   <string name="screen_room_details_security_title">"Security"</string>
   <string name="screen_room_details_topic_title">"Topic"</string>
-</resources>
+</resources>