* Implement voice message variable playback speed * Move playback speed string to Untranslated https://github.com/element-hq/element-x-ios/pull/5121#discussion_r2822631371 * Address review feedback for voice message playback speed - Persist voice message playback speed as an enum in AppSettings instead of storing an index. - Update playback speed cycling to derive from enum allCases and safely fall back to `.default` if the stored value cannot be resolved. - Apply runtime speed updates in AudioPlayer only when the player is in the `.playing` state. - Keep MediaPlayerProviderTests formatting/indentation style intact while retaining mock playback speed setup. - Regenerate preview snapshots for: - PlaybackSpeedButton - VoiceMessageRoomPlaybackView - VoiceMessageRoomTimelineView * Move VoiceMessagePlaybackSpeed outside AppSettings, remove speedRatio * Stabilize PlaybackSpeedButton width * Sync voice-message speed label - Add voiceMessagePlaybackSpeed to TimelineViewState and bind it from appSettings.$voiceMessagePlaybackSpeed. - Pass that timeline-level speed into VoiceMessageRoomPlaybackView and use it for PlaybackSpeedButton, so labels update consistently across items. - Use @EnvironmentObject in VoiceMessageRoomTimelineContent so the view re-renders when timeline context state changes. - In WaveformInteractionModifier, add .allowsHitTesting(showCursor) to the cursor interaction view so hidden pre-playback cursor hit area does not steal taps from the speed button.
88 lines
3.3 KiB
Swift
88 lines
3.3 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2023-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Combine
|
|
@testable import ElementX
|
|
import Foundation
|
|
import Testing
|
|
|
|
@MainActor
|
|
@Suite
|
|
struct MediaPlayerProviderTests {
|
|
private var mediaPlayerProvider: MediaPlayerProvider
|
|
|
|
private let oggMimeType = "audio/ogg"
|
|
private let someURL = URL.mockMXCAudio
|
|
private let someOtherURL = URL.mockMXCFile
|
|
|
|
init() async {
|
|
mediaPlayerProvider = MediaPlayerProvider()
|
|
}
|
|
|
|
@Test
|
|
func playerStates() {
|
|
let audioPlayerStateId = AudioPlayerStateIdentifier.timelineItemIdentifier(.randomEvent)
|
|
// By default, there should be no player state
|
|
#expect(mediaPlayerProvider.playerState(for: audioPlayerStateId) == nil)
|
|
|
|
let audioPlayerState = AudioPlayerState(id: audioPlayerStateId, title: "", duration: 10.0)
|
|
mediaPlayerProvider.register(audioPlayerState: audioPlayerState)
|
|
#expect(audioPlayerState == mediaPlayerProvider.playerState(for: audioPlayerStateId))
|
|
|
|
mediaPlayerProvider.unregister(audioPlayerState: audioPlayerState)
|
|
#expect(mediaPlayerProvider.playerState(for: audioPlayerStateId) == nil)
|
|
}
|
|
|
|
@Test
|
|
func detachAllStates() {
|
|
let audioPlayer = AudioPlayerMock()
|
|
audioPlayer.actions = PassthroughSubject<AudioPlayerAction, Never>().eraseToAnyPublisher()
|
|
audioPlayer.playbackSpeed = 1.0
|
|
|
|
let audioPlayerStates = Array(repeating: AudioPlayerState(id: .timelineItemIdentifier(.randomEvent), title: "", duration: 0), count: 10)
|
|
for audioPlayerState in audioPlayerStates {
|
|
mediaPlayerProvider.register(audioPlayerState: audioPlayerState)
|
|
audioPlayerState.attachAudioPlayer(audioPlayer)
|
|
let isAttached = audioPlayerState.isAttached
|
|
#expect(isAttached)
|
|
}
|
|
|
|
mediaPlayerProvider.detachAllStates(except: nil)
|
|
for audioPlayerState in audioPlayerStates {
|
|
let isAttached = audioPlayerState.isAttached
|
|
#expect(!isAttached)
|
|
}
|
|
}
|
|
|
|
@Test
|
|
func detachAllStatesWithException() {
|
|
let audioPlayer = AudioPlayerMock()
|
|
audioPlayer.actions = PassthroughSubject<AudioPlayerAction, Never>().eraseToAnyPublisher()
|
|
audioPlayer.playbackSpeed = 1.0
|
|
|
|
let audioPlayerStates = Array(repeating: AudioPlayerState(id: .timelineItemIdentifier(.randomEvent), title: "", duration: 0), count: 10)
|
|
for audioPlayerState in audioPlayerStates {
|
|
mediaPlayerProvider.register(audioPlayerState: audioPlayerState)
|
|
audioPlayerState.attachAudioPlayer(audioPlayer)
|
|
let isAttached = audioPlayerState.isAttached
|
|
#expect(isAttached)
|
|
}
|
|
|
|
let exception = audioPlayerStates[1]
|
|
mediaPlayerProvider.detachAllStates(except: exception)
|
|
for audioPlayerState in audioPlayerStates {
|
|
let isAttached = audioPlayerState.isAttached
|
|
if audioPlayerState == exception {
|
|
#expect(isAttached)
|
|
} else {
|
|
#expect(!isAttached)
|
|
}
|
|
}
|
|
}
|
|
}
|