5f724941ee
* Implement voice message variable playback speed * Move playback speed string to Untranslated https://github.com/element-hq/element-x-ios/pull/5121#discussion_r2822631371 * Address review feedback for voice message playback speed - Persist voice message playback speed as an enum in AppSettings instead of storing an index. - Update playback speed cycling to derive from enum allCases and safely fall back to `.default` if the stored value cannot be resolved. - Apply runtime speed updates in AudioPlayer only when the player is in the `.playing` state. - Keep MediaPlayerProviderTests formatting/indentation style intact while retaining mock playback speed setup. - Regenerate preview snapshots for: - PlaybackSpeedButton - VoiceMessageRoomPlaybackView - VoiceMessageRoomTimelineView * Move VoiceMessagePlaybackSpeed outside AppSettings, remove speedRatio * Stabilize PlaybackSpeedButton width * Sync voice-message speed label - Add voiceMessagePlaybackSpeed to TimelineViewState and bind it from appSettings.$voiceMessagePlaybackSpeed. - Pass that timeline-level speed into VoiceMessageRoomPlaybackView and use it for PlaybackSpeedButton, so labels update consistently across items. - Use @EnvironmentObject in VoiceMessageRoomTimelineContent so the view re-renders when timeline context state changes. - In WaveformInteractionModifier, add .allowsHitTesting(showCursor) to the cursor interaction view so hidden pre-playback cursor hit area does not steal taps from the speed button.
100 lines
4.5 KiB
Swift
100 lines
4.5 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2023-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Foundation
|
|
import SwiftUI
|
|
|
|
struct VoiceMessageRoomTimelineView: View {
|
|
let timelineItem: VoiceMessageRoomTimelineItem
|
|
let playerState: AudioPlayerState
|
|
|
|
var body: some View {
|
|
TimelineStyler(timelineItem: timelineItem) {
|
|
VoiceMessageRoomTimelineContent(timelineItem: timelineItem,
|
|
playerState: playerState)
|
|
.frame(maxWidth: 400)
|
|
}
|
|
}
|
|
}
|
|
|
|
struct VoiceMessageRoomTimelineContent: View {
|
|
@EnvironmentObject private var context: TimelineViewModel.Context
|
|
@State private var resumePlaybackAfterScrubbing = false
|
|
|
|
let timelineItem: VoiceMessageRoomTimelineItem
|
|
let playerState: AudioPlayerState
|
|
|
|
var body: some View {
|
|
VoiceMessageRoomPlaybackView(playerState: playerState,
|
|
onPlayPause: onPlaybackPlayPause,
|
|
onSeek: { onPlaybackSeek($0) },
|
|
onScrubbing: { onPlaybackScrubbing($0) },
|
|
playbackSpeed: context.viewState.voiceMessagePlaybackSpeed,
|
|
onPlaybackSpeedChange: onPlaybackSpeedChange)
|
|
.fixedSize(horizontal: false, vertical: true)
|
|
}
|
|
|
|
private func onPlaybackPlayPause() {
|
|
context.send(viewAction: .handleAudioPlayerAction(.playPause(itemID: timelineItem.id)))
|
|
}
|
|
|
|
private func onPlaybackSpeedChange() {
|
|
context.send(viewAction: .handleAudioPlayerAction(.changePlaybackSpeed(itemID: timelineItem.id)))
|
|
}
|
|
|
|
private func onPlaybackSeek(_ progress: Double) {
|
|
context.send(viewAction: .handleAudioPlayerAction(.seek(itemID: timelineItem.id, progress: progress)))
|
|
}
|
|
|
|
private func onPlaybackScrubbing(_ dragging: Bool) {
|
|
if dragging {
|
|
if playerState.playbackState == .playing {
|
|
resumePlaybackAfterScrubbing = true
|
|
context.send(viewAction: .handleAudioPlayerAction(.playPause(itemID: timelineItem.id)))
|
|
}
|
|
} else {
|
|
if resumePlaybackAfterScrubbing {
|
|
context.send(viewAction: .handleAudioPlayerAction(.playPause(itemID: timelineItem.id)))
|
|
resumePlaybackAfterScrubbing = false
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
struct VoiceMessageRoomTimelineView_Previews: PreviewProvider, TestablePreview {
|
|
static let viewModel = TimelineViewModel.mock
|
|
static let timelineItemIdentifier = TimelineItemIdentifier.randomEvent
|
|
static let voiceRoomTimelineItem = VoiceMessageRoomTimelineItem(id: timelineItemIdentifier,
|
|
timestamp: .mock,
|
|
isOutgoing: false,
|
|
isEditable: false,
|
|
canBeRepliedTo: true,
|
|
sender: .init(id: "Bob"),
|
|
content: .init(filename: "audio.ogg",
|
|
duration: 300,
|
|
waveform: EstimatedWaveform.mockWaveform,
|
|
source: nil,
|
|
fileSize: nil,
|
|
contentType: nil))
|
|
|
|
static let playerState = AudioPlayerState(id: .timelineItemIdentifier(timelineItemIdentifier),
|
|
title: L10n.commonVoiceMessage,
|
|
duration: 10.0,
|
|
waveform: EstimatedWaveform.mockWaveform,
|
|
progress: 0.4)
|
|
|
|
static var previews: some View {
|
|
body.environmentObject(viewModel.context)
|
|
}
|
|
|
|
static var body: some View {
|
|
VoiceMessageRoomTimelineView(timelineItem: voiceRoomTimelineItem, playerState: playerState)
|
|
.fixedSize(horizontal: false, vertical: true)
|
|
}
|
|
}
|