* Initial plan * Migrate 3 test files from XCTest to Swift Testing - MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(), BundleFinder class for Bundle(for:), mutating test/setup functions, [self] capture replacing [weak self] in closures - NotificationManagerTests: @MainActor @Suite final class with init()/deinit, expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped - NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with init() throws, non-optional stored properties, test prefix stripped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 3 XCTest files to Swift Testing - NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods - TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit - AttributedStringBuilderTests: @Suite struct with init() async throws All XCT assertions replaced with #expect/#require/Issue.record Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs, testLoadingItem renamed to loadingItem (called internally by other tests) - ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit - CompletionSuggestionServiceTests: @Suite struct with init() - RoomFlowCoordinatorTests: @Suite final class with deinit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - VoiceMessageRecorderTests: @Suite struct with init() async throws, added BundleFinder class for Bundle lookup, migrated all assertions - SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel, all test funcs mutating, XCTestExpectation → confirmation - RoomNotificationSettingsScreenViewModelTests: @Suite struct with init() throws, cancellable tests marked mutating - JoinRoomScreenViewModelTests: @Suite final class with init()/deinit, XCTestExpectation → confirmation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 6 test files from XCTestCase to Swift Testing Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Fix trailing blank line in RoomPollsHistoryScreenViewModelTests Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Migrate 3 test files from XCTest to Swift Testing - MediaUploadingPreprocessorTests: @Suite final class with init()/deinit, removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double) - SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class, 5 expectation+fulfillment → await confirmation(...) - CreateRoomViewModelTests: @MainActor @Suite final class, 4 expectation+fulfillment → await confirmation(...) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing - Replace XCTest with Testing framework - RoomScreenViewModelTests: final class with init() async throws + deinit - RoomDetailsScreenViewModelTests: struct with init() and mutating funcs - Convert XCT assertions to #expect / Issue.record - Convert XCTestExpectation patterns to confirmation { confirm in } - Strip 'test' prefix from all test function names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing - Replace import XCTest with import Testing - Convert XCTestCase class to @MainActor @Suite final class - Replace setUp()/tearDown() with init()/deinit - Strip 'test' prefix from all 41 test method names and add @Test - Replace XCTAssert* with #expect()/#require() - Replace try XCTUnwrap() with try #require() - Convert expectation+wait patterns to deferFulfillment with PassthroughSubject - Convert isInverted expectation to boolean flag checked after await - Use deferFulfillment on $viewState for state-transition tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address comments with Copilot. * Fix the failing tests. * Fixed flaky tests (#5137) resolved flaky tests * Tweaks and fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
189 lines
7.8 KiB
Swift
189 lines
7.8 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import Foundation
|
|
import Testing
|
|
|
|
@Suite
|
|
@MainActor
|
|
struct RoomPollsHistoryScreenViewModelTests {
|
|
var viewModel: RoomPollsHistoryScreenViewModelProtocol!
|
|
var interactionHandler: PollInteractionHandlerMock!
|
|
var timelineController: MockTimelineController!
|
|
|
|
init() throws {
|
|
interactionHandler = PollInteractionHandlerMock()
|
|
timelineController = MockTimelineController()
|
|
viewModel = RoomPollsHistoryScreenViewModel(pollInteractionHandler: interactionHandler,
|
|
timelineController: timelineController,
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
}
|
|
|
|
@Test
|
|
func backPaginate() async throws {
|
|
timelineController.backPaginationResponses = [
|
|
[PollRoomTimelineItem.mock(poll: .emptyDisclosed, isEditable: true),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: true)),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: false)),
|
|
PollRoomTimelineItem.mock(poll: .endedDisclosed)]
|
|
]
|
|
|
|
let deferredViewState = deferFulfillment(viewModel.context.$viewState, keyPath: \.isBackPaginating, transitionValues: [false, true, false])
|
|
|
|
viewModel.context.send(viewAction: .loadMore)
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(viewModel.context.viewState.pollTimelineItems.count == 3)
|
|
#expect(!viewModel.context.viewState.canBackPaginate)
|
|
}
|
|
|
|
@Test
|
|
func backPaginateCanBackPaginate() async throws {
|
|
timelineController.backPaginationResponses = [
|
|
[PollRoomTimelineItem.mock(poll: .emptyDisclosed, isEditable: true),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: true)),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: false)),
|
|
PollRoomTimelineItem.mock(poll: .endedDisclosed)],
|
|
[]
|
|
]
|
|
|
|
let deferredViewState = deferFulfillment(viewModel.context.$viewState, keyPath: \.isBackPaginating, transitionValues: [false, true, false])
|
|
|
|
viewModel.context.send(viewAction: .loadMore)
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(viewModel.context.viewState.pollTimelineItems.count == 3)
|
|
#expect(viewModel.context.viewState.canBackPaginate)
|
|
}
|
|
|
|
@Test
|
|
func backPaginateTwice() async throws {
|
|
timelineController.backPaginationResponses = [
|
|
[PollRoomTimelineItem.mock(poll: .emptyDisclosed, isEditable: true),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: true)),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: false))],
|
|
[PollRoomTimelineItem.mock(poll: .endedDisclosed)]
|
|
]
|
|
let deferredViewState = deferFulfillment(viewModel.context.$viewState, keyPath: \.isBackPaginating, transitionValues: [false, true, false])
|
|
|
|
viewModel.context.send(viewAction: .loadMore)
|
|
viewModel.context.send(viewAction: .loadMore)
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(viewModel.context.viewState.pollTimelineItems.count == 3)
|
|
#expect(viewModel.context.viewState.canBackPaginate)
|
|
}
|
|
|
|
@Test
|
|
func filters() async throws {
|
|
timelineController.backPaginationResponses = [
|
|
[PollRoomTimelineItem.mock(poll: .emptyDisclosed, isEditable: true),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: true)),
|
|
PollRoomTimelineItem.mock(poll: .disclosed(createdByAccountOwner: false)),
|
|
PollRoomTimelineItem.mock(poll: .endedDisclosed)],
|
|
[]
|
|
]
|
|
|
|
let deferredViewState = deferFulfillment(viewModel.context.$viewState) { value in
|
|
!value.pollTimelineItems.isEmpty
|
|
}
|
|
|
|
viewModel.context.filter = .ongoing
|
|
viewModel.context.send(viewAction: .loadMore)
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(viewModel.context.viewState.pollTimelineItems.count == 3)
|
|
|
|
viewModel.context.send(viewAction: .filter(.past))
|
|
#expect(viewModel.context.viewState.pollTimelineItems.count == 1)
|
|
}
|
|
|
|
@Test
|
|
func endPoll() async throws {
|
|
let deferred = deferFulfillment(interactionHandler.publisher.delay(for: 0.1, scheduler: DispatchQueue.main)) { _ in true }
|
|
|
|
interactionHandler.endPollPollStartIDReturnValue = .success(())
|
|
viewModel.context.send(viewAction: .end(pollStartID: "somePollID"))
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(interactionHandler.endPollPollStartIDCalled)
|
|
#expect(interactionHandler.endPollPollStartIDReceivedPollStartID == "somePollID")
|
|
}
|
|
|
|
@Test
|
|
func endPollFailure() async throws {
|
|
let deferred = deferFulfillment(viewModel.context.$viewState) { value in
|
|
value.bindings.alertInfo != nil
|
|
}
|
|
|
|
interactionHandler.endPollPollStartIDReturnValue = .failure(SDKError.generic)
|
|
viewModel.context.send(viewAction: .end(pollStartID: "somePollID"))
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(interactionHandler.endPollPollStartIDCalled)
|
|
#expect(interactionHandler.endPollPollStartIDReceivedPollStartID == "somePollID")
|
|
}
|
|
|
|
@Test
|
|
func sendPollResponse() async throws {
|
|
let deferred = deferFulfillment(interactionHandler.publisher.delay(for: 0.1, scheduler: DispatchQueue.main)) { _ in true }
|
|
|
|
interactionHandler.sendPollResponsePollStartIDOptionIDReturnValue = .success(())
|
|
viewModel.context.send(viewAction: .sendPollResponse(pollStartID: "somePollID", optionID: "someOptionID"))
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(interactionHandler.sendPollResponsePollStartIDOptionIDCalled)
|
|
#expect(interactionHandler.sendPollResponsePollStartIDOptionIDReceivedInvocations[0].pollStartID == "somePollID")
|
|
#expect(interactionHandler.sendPollResponsePollStartIDOptionIDReceivedInvocations[0].optionID == "someOptionID")
|
|
}
|
|
|
|
@Test
|
|
func sendPollResponseFailure() async throws {
|
|
let deferred = deferFulfillment(viewModel.context.$viewState) { value in
|
|
value.bindings.alertInfo != nil
|
|
}
|
|
|
|
interactionHandler.sendPollResponsePollStartIDOptionIDReturnValue = .failure(SDKError.generic)
|
|
viewModel.context.send(viewAction: .sendPollResponse(pollStartID: "somePollID", optionID: "someOptionID"))
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(interactionHandler.sendPollResponsePollStartIDOptionIDCalled)
|
|
#expect(interactionHandler.sendPollResponsePollStartIDOptionIDReceivedInvocations[0].pollStartID == "somePollID")
|
|
#expect(interactionHandler.sendPollResponsePollStartIDOptionIDReceivedInvocations[0].optionID == "someOptionID")
|
|
}
|
|
|
|
@Test
|
|
func editPoll() async throws {
|
|
let expectedPoll: Poll = .emptyDisclosed
|
|
let expectedPollStartID = "someEventID"
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { action in
|
|
switch action {
|
|
case .editPoll(let pollStartID, let poll):
|
|
expectedPollStartID == pollStartID && expectedPoll == poll
|
|
}
|
|
}
|
|
|
|
viewModel.context.send(viewAction: .edit(pollStartID: expectedPollStartID, poll: expectedPoll))
|
|
try await deferred.fulfill()
|
|
}
|
|
}
|
|
|
|
private enum SDKError: Error {
|
|
case generic
|
|
}
|