Files
letro-ios/UnitTests/Sources/SessionVerificationViewModelTests.swift
Copilot 4834f453ef Finish migration of UnitTests target from XCTestCase to Swift Testing (#5129)
* Initial plan

* Migrate 3 test files from XCTest to Swift Testing

- MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(),
  BundleFinder class for Bundle(for:), mutating test/setup functions,
  [self] capture replacing [weak self] in closures
- NotificationManagerTests: @MainActor @Suite final class with init()/deinit,
  expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped
- NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with
  init() throws, non-optional stored properties, test prefix stripped

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 3 XCTest files to Swift Testing

- NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods
- TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit
- AttributedStringBuilderTests: @Suite struct with init() async throws

All XCT assertions replaced with #expect/#require/Issue.record

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 4 test files from XCTest to Swift Testing

- TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs,
  testLoadingItem renamed to loadingItem (called internally by other tests)
- ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit
- CompletionSuggestionServiceTests: @Suite struct with init()
- RoomFlowCoordinatorTests: @Suite final class with deinit

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 4 test files from XCTest to Swift Testing

- VoiceMessageRecorderTests: @Suite struct with init() async throws,
  added BundleFinder class for Bundle lookup, migrated all assertions
- SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel,
  all test funcs mutating, XCTestExpectation → confirmation
- RoomNotificationSettingsScreenViewModelTests: @Suite struct with
  init() throws, cancellable tests marked mutating
- JoinRoomScreenViewModelTests: @Suite final class with init()/deinit,
  XCTestExpectation → confirmation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 6 test files from XCTestCase to Swift Testing

Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>

* Fix trailing blank line in RoomPollsHistoryScreenViewModelTests

Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>

* Migrate 3 test files from XCTest to Swift Testing

- MediaUploadingPreprocessorTests: @Suite final class with init()/deinit,
  removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double)
- SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class,
  5 expectation+fulfillment → await confirmation(...)
- CreateRoomViewModelTests: @MainActor @Suite final class,
  4 expectation+fulfillment → await confirmation(...)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing

- Replace XCTest with Testing framework
- RoomScreenViewModelTests: final class with init() async throws + deinit
- RoomDetailsScreenViewModelTests: struct with init() and mutating funcs
- Convert XCT assertions to #expect / Issue.record
- Convert XCTestExpectation patterns to confirmation { confirm in }
- Strip 'test' prefix from all test function names

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing

- Replace import XCTest with import Testing
- Convert XCTestCase class to @MainActor @Suite final class
- Replace setUp()/tearDown() with init()/deinit
- Strip 'test' prefix from all 41 test method names and add @Test
- Replace XCTAssert* with #expect()/#require()
- Replace try XCTUnwrap() with try #require()
- Convert expectation+wait patterns to deferFulfillment with PassthroughSubject
- Convert isInverted expectation to boolean flag checked after await
- Use deferFulfillment on $viewState for state-transition tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address comments with Copilot.

* Fix the failing tests.

* Fixed flaky tests (#5137)

resolved flaky tests

* Tweaks and fixes.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <douglase@element.io>
Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
2026-02-24 12:20:01 +00:00

134 lines
5.1 KiB
Swift

//
// Copyright 2025 Element Creations Ltd.
// Copyright 2022-2025 New Vector Ltd.
//
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
// Please see LICENSE files in the repository root for full details.
//
import Combine
@testable import ElementX
import Foundation
import Testing
@Suite
@MainActor
struct SessionVerificationViewModelTests {
var viewModel: SessionVerificationScreenViewModelProtocol!
var context: SessionVerificationViewModelType.Context!
var sessionVerificationController: SessionVerificationControllerProxyMock!
init() throws {
sessionVerificationController = SessionVerificationControllerProxyMock.configureMock()
viewModel = SessionVerificationScreenViewModel(sessionVerificationControllerProxy: sessionVerificationController,
flow: .deviceInitiator,
appSettings: AppSettings(),
mediaProvider: MediaProviderMock(configuration: .init()))
context = viewModel.context
}
@Test
func requestVerification() async throws {
#expect(context.viewState.verificationState == .initial)
context.send(viewAction: .requestVerification)
try await Task.sleep(for: .milliseconds(100))
#expect(sessionVerificationController.requestDeviceVerificationCallsCount == 1)
#expect(context.viewState.verificationState == .requestingVerification)
}
@Test
func verificationCancellation() async throws {
#expect(context.viewState.verificationState == .initial)
context.send(viewAction: .requestVerification)
viewModel.stop()
#expect(context.viewState.verificationState == .cancelling)
let deferred = deferFulfillment(context.$viewState) { state in
state.verificationState == .cancelled
}
try await deferred.fulfill()
#expect(context.viewState.verificationState == .cancelled)
context.send(viewAction: .restart)
#expect(context.viewState.verificationState == .initial)
#expect(sessionVerificationController.requestDeviceVerificationCallsCount == 1)
#expect(sessionVerificationController.cancelVerificationCallsCount == 1)
}
@Test
mutating func receiveChallenge() async throws {
try await setupChallengeReceived()
}
@Test
mutating func acceptChallenge() async throws {
try await setupChallengeReceived()
let deferred = deferFulfillment(sessionVerificationController.actions
.delay(for: .seconds(0.1), scheduler: DispatchQueue.main)) { callback in
if case .finished = callback { return true }
return false
}
context.send(viewAction: .accept)
try await deferred.fulfill()
#expect(context.viewState.verificationState == .verified)
#expect(sessionVerificationController.approveVerificationCallsCount == 1)
}
@Test
mutating func declineChallenge() async throws {
try await setupChallengeReceived()
let deferred = deferFulfillment(sessionVerificationController.actions
.delay(for: .seconds(0.1), scheduler: DispatchQueue.main)) { callback in
if case .cancelled = callback { return true }
return false
}
context.send(viewAction: .decline)
try await deferred.fulfill()
#expect(context.viewState.verificationState == .cancelled)
#expect(sessionVerificationController.declineVerificationCallsCount == 1)
}
// MARK: - Private
private mutating func setupChallengeReceived() async throws {
let actionsPublisher = sessionVerificationController.actions.delay(for: .seconds(0.1), scheduler: DispatchQueue.main)
let cancellable = actionsPublisher
.sink { [context] action in
if case .acceptedVerificationRequest = action {
context?.send(viewAction: .startSasVerification)
}
}
let deferred = deferFulfillment(actionsPublisher,
keyPath: \.self,
transitionValues: [.acceptedVerificationRequest,
.startedSasVerification,
.receivedVerificationData(SessionVerificationControllerProxyMock.emojis)])
context.send(viewAction: .requestVerification)
try await deferred.fulfill()
#expect(context.viewState.verificationState == .showingChallenge(emojis: SessionVerificationControllerProxyMock.emojis))
#expect(sessionVerificationController.requestDeviceVerificationCallsCount == 1)
#expect(sessionVerificationController.startSasVerificationCallsCount == 1)
cancellable.cancel()
}
}