* Initial plan * Migrate 3 test files from XCTest to Swift Testing - MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(), BundleFinder class for Bundle(for:), mutating test/setup functions, [self] capture replacing [weak self] in closures - NotificationManagerTests: @MainActor @Suite final class with init()/deinit, expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped - NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with init() throws, non-optional stored properties, test prefix stripped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 3 XCTest files to Swift Testing - NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods - TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit - AttributedStringBuilderTests: @Suite struct with init() async throws All XCT assertions replaced with #expect/#require/Issue.record Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs, testLoadingItem renamed to loadingItem (called internally by other tests) - ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit - CompletionSuggestionServiceTests: @Suite struct with init() - RoomFlowCoordinatorTests: @Suite final class with deinit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - VoiceMessageRecorderTests: @Suite struct with init() async throws, added BundleFinder class for Bundle lookup, migrated all assertions - SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel, all test funcs mutating, XCTestExpectation → confirmation - RoomNotificationSettingsScreenViewModelTests: @Suite struct with init() throws, cancellable tests marked mutating - JoinRoomScreenViewModelTests: @Suite final class with init()/deinit, XCTestExpectation → confirmation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 6 test files from XCTestCase to Swift Testing Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Fix trailing blank line in RoomPollsHistoryScreenViewModelTests Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Migrate 3 test files from XCTest to Swift Testing - MediaUploadingPreprocessorTests: @Suite final class with init()/deinit, removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double) - SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class, 5 expectation+fulfillment → await confirmation(...) - CreateRoomViewModelTests: @MainActor @Suite final class, 4 expectation+fulfillment → await confirmation(...) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing - Replace XCTest with Testing framework - RoomScreenViewModelTests: final class with init() async throws + deinit - RoomDetailsScreenViewModelTests: struct with init() and mutating funcs - Convert XCT assertions to #expect / Issue.record - Convert XCTestExpectation patterns to confirmation { confirm in } - Strip 'test' prefix from all test function names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing - Replace import XCTest with import Testing - Convert XCTestCase class to @MainActor @Suite final class - Replace setUp()/tearDown() with init()/deinit - Strip 'test' prefix from all 41 test method names and add @Test - Replace XCTAssert* with #expect()/#require() - Replace try XCTUnwrap() with try #require() - Convert expectation+wait patterns to deferFulfillment with PassthroughSubject - Convert isInverted expectation to boolean flag checked after await - Use deferFulfillment on $viewState for state-transition tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address comments with Copilot. * Fix the failing tests. * Fixed flaky tests (#5137) resolved flaky tests * Tweaks and fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
259 lines
12 KiB
Swift
259 lines
12 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import MatrixRustSDK
|
|
import Testing
|
|
|
|
@Suite
|
|
@MainActor
|
|
struct NotificationSettingsEditScreenViewModelTests {
|
|
private var viewModel: NotificationSettingsEditScreenViewModelProtocol!
|
|
private var notificationSettingsProxy: NotificationSettingsProxyMock!
|
|
private var userSession: UserSessionMock!
|
|
private var clientProxy: ClientProxyMock!
|
|
|
|
private var context: NotificationSettingsEditScreenViewModelType.Context {
|
|
viewModel.context
|
|
}
|
|
|
|
init() throws {
|
|
notificationSettingsProxy = NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration())
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneReturnValue = .allMessages
|
|
|
|
clientProxy = ClientProxyMock(.init(userID: "@a:b.com", notificationSettings: notificationSettingsProxy))
|
|
userSession = UserSessionMock(.init(clientProxy: clientProxy))
|
|
}
|
|
|
|
@Test
|
|
mutating func fetchSettings() async throws {
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneClosure = { isEncrypted, isOneToOne in
|
|
switch (isEncrypted, isOneToOne) {
|
|
case (_, true):
|
|
return .allMessages
|
|
case (_, _):
|
|
return .mentionsAndKeywordsOnly
|
|
}
|
|
}
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .groupChat, userSession: userSession)
|
|
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode)) { $0 != nil }
|
|
|
|
viewModel.fetchInitialContent()
|
|
|
|
try await deferred.fulfill()
|
|
|
|
// `getDefaultRoomNotificationModeIsEncryptedIsOneToOne` must have been called twice (for encrypted and unencrypted group chats)
|
|
let invocations = notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneReceivedInvocations
|
|
|
|
#expect(invocations.count == 2)
|
|
// First call for encrypted group chats
|
|
#expect(invocations[0].isEncrypted == true)
|
|
#expect(invocations[0].isOneToOne == false)
|
|
// Second call for unencrypted group chats
|
|
#expect(invocations[1].isEncrypted == false)
|
|
#expect(invocations[1].isOneToOne == false)
|
|
|
|
#expect(context.viewState.defaultMode == .mentionsAndKeywordsOnly)
|
|
#expect(context.viewState.bindings.alertInfo == nil)
|
|
#expect(!context.viewState.canPushEncryptedEvents)
|
|
#expect(context.viewState.description(for: .mentionsAndKeywordsOnly) != nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func fetchSettingsWithCanPushEncryptedEvents() async throws {
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneClosure = { isEncrypted, isOneToOne in
|
|
switch (isEncrypted, isOneToOne) {
|
|
case (_, true):
|
|
return .allMessages
|
|
case (_, _):
|
|
return .mentionsAndKeywordsOnly
|
|
}
|
|
}
|
|
notificationSettingsProxy.canPushEncryptedEventsToDeviceClosure = {
|
|
true
|
|
}
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .groupChat, userSession: userSession)
|
|
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode)) { $0 != nil }
|
|
|
|
viewModel.fetchInitialContent()
|
|
|
|
try await deferred.fulfill()
|
|
|
|
// `getDefaultRoomNotificationModeIsEncryptedIsOneToOne` must have been called twice (for encrypted and unencrypted group chats)
|
|
let invocations = notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneReceivedInvocations
|
|
|
|
#expect(invocations.count == 2)
|
|
// First call for encrypted group chats
|
|
#expect(invocations[0].isEncrypted == true)
|
|
#expect(invocations[0].isOneToOne == false)
|
|
// Second call for unencrypted group chats
|
|
#expect(invocations[1].isEncrypted == false)
|
|
#expect(invocations[1].isOneToOne == false)
|
|
|
|
#expect(context.viewState.defaultMode == .mentionsAndKeywordsOnly)
|
|
#expect(context.viewState.bindings.alertInfo == nil)
|
|
#expect(context.viewState.canPushEncryptedEvents)
|
|
#expect(context.viewState.description(for: .mentionsAndKeywordsOnly) == nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func setModeAllMessages() async throws {
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneReturnValue = .mentionsAndKeywordsOnly
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .groupChat, userSession: userSession)
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode)) { $0 != nil }
|
|
|
|
viewModel.fetchInitialContent()
|
|
|
|
try await deferred.fulfill()
|
|
|
|
var deferredViewState = deferFulfillment(viewModel.context.observe(\.viewState.pendingMode),
|
|
transitionValues: [nil, .allMessages, nil])
|
|
|
|
context.send(viewAction: .setMode(.allMessages))
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
// `setDefaultRoomNotificationModeIsEncryptedIsOneToOneMode` must have been called twice (for encrypted and unencrypted group chats)
|
|
let invocations = notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeReceivedInvocations
|
|
#expect(notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeCallsCount == 2)
|
|
// First call for encrypted group chats
|
|
#expect(invocations[0].isEncrypted == true)
|
|
#expect(invocations[0].isOneToOne == false)
|
|
#expect(invocations[0].mode == .allMessages)
|
|
// Second call for unencrypted group chats
|
|
#expect(invocations[1].isEncrypted == false)
|
|
#expect(invocations[1].isOneToOne == false)
|
|
#expect(invocations[1].mode == .allMessages)
|
|
|
|
deferredViewState = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode),
|
|
transitionValues: [.allMessages])
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(context.viewState.defaultMode == .allMessages)
|
|
#expect(context.viewState.bindings.alertInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func setModeMentions() async throws {
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .groupChat, userSession: userSession)
|
|
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode)) { $0 != nil }
|
|
|
|
viewModel.fetchInitialContent()
|
|
|
|
try await deferred.fulfill()
|
|
|
|
var deferredViewState = deferFulfillment(viewModel.context.observe(\.viewState.pendingMode),
|
|
transitionValues: [nil, .mentionsAndKeywordsOnly, nil])
|
|
|
|
context.send(viewAction: .setMode(.mentionsAndKeywordsOnly))
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
// `setDefaultRoomNotificationModeIsEncryptedIsOneToOneMode` must have been called twice (for encrypted and unencrypted group chats)
|
|
let invocations = notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeReceivedInvocations
|
|
#expect(notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeCallsCount == 2)
|
|
// First call for encrypted group chats
|
|
#expect(invocations[0].isEncrypted == true)
|
|
#expect(invocations[0].isOneToOne == false)
|
|
#expect(invocations[0].mode == .mentionsAndKeywordsOnly)
|
|
// Second call for unencrypted group chats
|
|
#expect(invocations[1].isEncrypted == false)
|
|
#expect(invocations[1].isOneToOne == false)
|
|
#expect(invocations[1].mode == .mentionsAndKeywordsOnly)
|
|
|
|
deferredViewState = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode),
|
|
transitionValues: [.mentionsAndKeywordsOnly])
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(context.viewState.defaultMode == .mentionsAndKeywordsOnly)
|
|
#expect(context.viewState.bindings.alertInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func setModeDirectChats() async throws {
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneReturnValue = .mentionsAndKeywordsOnly
|
|
// Initialize for direct chats
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .oneToOneChat, userSession: userSession)
|
|
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode)) { $0 != nil }
|
|
|
|
viewModel.fetchInitialContent()
|
|
|
|
try await deferred.fulfill()
|
|
|
|
let deferredViewState = deferFulfillment(viewModel.context.observe(\.viewState.pendingMode),
|
|
transitionValues: [nil, .allMessages, nil])
|
|
|
|
context.send(viewAction: .setMode(.allMessages))
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
// `setDefaultRoomNotificationModeIsEncryptedIsOneToOneMode` must have been called twice (for encrypted and unencrypted direct chats)
|
|
let invocations = notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeReceivedInvocations
|
|
#expect(notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeCallsCount == 2)
|
|
// First call for encrypted direct chats
|
|
#expect(invocations[0].isEncrypted == true)
|
|
#expect(invocations[0].isOneToOne == true)
|
|
#expect(invocations[0].mode == .allMessages)
|
|
// Second call for unencrypted direct chats
|
|
#expect(invocations[1].isEncrypted == false)
|
|
#expect(invocations[1].isOneToOne == true)
|
|
#expect(invocations[1].mode == .allMessages)
|
|
}
|
|
|
|
@Test
|
|
mutating func setModeFailure() async throws {
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneReturnValue = .mentionsAndKeywordsOnly
|
|
notificationSettingsProxy.setDefaultRoomNotificationModeIsEncryptedIsOneToOneModeThrowableError = NotificationSettingsError.Generic(msg: "error")
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .oneToOneChat, userSession: userSession)
|
|
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.defaultMode)) { $0 != nil }
|
|
|
|
viewModel.fetchInitialContent()
|
|
|
|
try await deferred.fulfill()
|
|
|
|
let deferredViewState = deferFulfillment(viewModel.context.observe(\.viewState.pendingMode),
|
|
transitionValues: [nil, .allMessages, nil])
|
|
|
|
context.send(viewAction: .setMode(.allMessages))
|
|
|
|
try await deferredViewState.fulfill()
|
|
|
|
#expect(context.viewState.bindings.alertInfo != nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func selectRoom() async throws {
|
|
let roomID = "!roomidentifier:matrix.org"
|
|
viewModel = NotificationSettingsEditScreenViewModel(chatType: .oneToOneChat, userSession: userSession)
|
|
|
|
let deferredActions = deferFulfillment(viewModel.actions) { action in
|
|
switch action {
|
|
case .requestRoomNotificationSettingsPresentation:
|
|
return true
|
|
}
|
|
}
|
|
|
|
context.send(viewAction: .selectRoom(roomIdentifier: roomID))
|
|
|
|
let sentAction = try await deferredActions.fulfill()
|
|
|
|
let expectedAction = NotificationSettingsEditScreenViewModelAction.requestRoomNotificationSettingsPresentation(roomID: roomID)
|
|
guard case let .requestRoomNotificationSettingsPresentation(roomID: receivedRoomID) = sentAction, receivedRoomID == roomID else {
|
|
Issue.record("Expected action \(expectedAction), but was \(sentAction)")
|
|
return
|
|
}
|
|
}
|
|
}
|