* Initial plan * Migrate 3 test files from XCTest to Swift Testing - MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(), BundleFinder class for Bundle(for:), mutating test/setup functions, [self] capture replacing [weak self] in closures - NotificationManagerTests: @MainActor @Suite final class with init()/deinit, expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped - NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with init() throws, non-optional stored properties, test prefix stripped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 3 XCTest files to Swift Testing - NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods - TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit - AttributedStringBuilderTests: @Suite struct with init() async throws All XCT assertions replaced with #expect/#require/Issue.record Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs, testLoadingItem renamed to loadingItem (called internally by other tests) - ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit - CompletionSuggestionServiceTests: @Suite struct with init() - RoomFlowCoordinatorTests: @Suite final class with deinit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - VoiceMessageRecorderTests: @Suite struct with init() async throws, added BundleFinder class for Bundle lookup, migrated all assertions - SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel, all test funcs mutating, XCTestExpectation → confirmation - RoomNotificationSettingsScreenViewModelTests: @Suite struct with init() throws, cancellable tests marked mutating - JoinRoomScreenViewModelTests: @Suite final class with init()/deinit, XCTestExpectation → confirmation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 6 test files from XCTestCase to Swift Testing Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Fix trailing blank line in RoomPollsHistoryScreenViewModelTests Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Migrate 3 test files from XCTest to Swift Testing - MediaUploadingPreprocessorTests: @Suite final class with init()/deinit, removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double) - SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class, 5 expectation+fulfillment → await confirmation(...) - CreateRoomViewModelTests: @MainActor @Suite final class, 4 expectation+fulfillment → await confirmation(...) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing - Replace XCTest with Testing framework - RoomScreenViewModelTests: final class with init() async throws + deinit - RoomDetailsScreenViewModelTests: struct with init() and mutating funcs - Convert XCT assertions to #expect / Issue.record - Convert XCTestExpectation patterns to confirmation { confirm in } - Strip 'test' prefix from all test function names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing - Replace import XCTest with import Testing - Convert XCTestCase class to @MainActor @Suite final class - Replace setUp()/tearDown() with init()/deinit - Strip 'test' prefix from all 41 test method names and add @Test - Replace XCTAssert* with #expect()/#require() - Replace try XCTUnwrap() with try #require() - Convert expectation+wait patterns to deferFulfillment with PassthroughSubject - Convert isInverted expectation to boolean flag checked after await - Use deferFulfillment on $viewState for state-transition tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address comments with Copilot. * Fix the failing tests. * Fixed flaky tests (#5137) resolved flaky tests * Tweaks and fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
183 lines
7.7 KiB
Swift
183 lines
7.7 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Combine
|
|
@testable import ElementX
|
|
import Foundation
|
|
import Testing
|
|
|
|
@Suite
|
|
final class BugReportServiceTests {
|
|
var appSettings: AppSettings!
|
|
var bugReportService: BugReportServiceProtocol!
|
|
|
|
init() throws {
|
|
AppSettings.resetAllSettings()
|
|
appSettings = AppSettings()
|
|
appSettings.bugReportRageshakeURL.reset()
|
|
|
|
let bugReportServiceMock = BugReportServiceMock()
|
|
bugReportServiceMock.underlyingCrashedLastRun = false
|
|
bugReportServiceMock.submitBugReportProgressListenerReturnValue = .success(SubmitBugReportResponse(reportURL: "https://www.example.com/123"))
|
|
bugReportService = bugReportServiceMock
|
|
}
|
|
|
|
deinit {
|
|
appSettings.bugReportRageshakeURL.reset()
|
|
}
|
|
|
|
@Test
|
|
func initialStateWithMockService() {
|
|
#expect(!bugReportService.crashedLastRun)
|
|
}
|
|
|
|
@Test
|
|
func submitBugReportWithMockService() async throws {
|
|
let bugReport = BugReport(userID: "@mock:client.com",
|
|
deviceID: nil,
|
|
ed25519: nil,
|
|
curve25519: nil,
|
|
text: "i cannot send message",
|
|
logFiles: [URL(filePath: "/logs/1.log"), URL(filePath: "/logs/2.log")],
|
|
canContact: false,
|
|
githubLabels: [],
|
|
files: [])
|
|
let progressSubject = CurrentValueSubject<Double, Never>(0.0)
|
|
let response = try await bugReportService.submitBugReport(bugReport, progressListener: progressSubject).get()
|
|
let reportURL = try #require(response.reportURL)
|
|
#expect(!reportURL.isEmpty)
|
|
}
|
|
|
|
@Test
|
|
@MainActor
|
|
func initialStateWithRealService() {
|
|
let urlPublisher: CurrentValueSubject<RageshakeConfiguration, Never> = .init(.url("https://example.com/submit"))
|
|
let service = BugReportService(rageshakeURLPublisher: urlPublisher.asCurrentValuePublisher(),
|
|
applicationID: "mock_app_id",
|
|
sdkGitSHA: "1234",
|
|
session: .mock,
|
|
appHooks: AppHooks())
|
|
#expect(service.isEnabled)
|
|
#expect(!service.crashedLastRun)
|
|
}
|
|
|
|
@Test
|
|
func initialStateWithRealServiceAndDisabled() {
|
|
let urlPublisher: CurrentValueSubject<RageshakeConfiguration, Never> = .init(.disabled)
|
|
let service = BugReportService(rageshakeURLPublisher: urlPublisher.asCurrentValuePublisher(),
|
|
applicationID: "mock_app_id",
|
|
sdkGitSHA: "1234",
|
|
session: .mock,
|
|
appHooks: AppHooks())
|
|
#expect(!service.isEnabled)
|
|
#expect(!service.crashedLastRun)
|
|
}
|
|
|
|
@Test @MainActor
|
|
func submitBugReportWithRealService() async throws {
|
|
let urlPublisher: CurrentValueSubject<RageshakeConfiguration, Never> = .init(.url("https://example.com/submit"))
|
|
let service = BugReportService(rageshakeURLPublisher: urlPublisher.asCurrentValuePublisher(),
|
|
applicationID: "mock_app_id",
|
|
sdkGitSHA: "1234",
|
|
session: .mock,
|
|
appHooks: AppHooks())
|
|
|
|
let bugReport = BugReport(userID: "@mock:client.com",
|
|
deviceID: nil,
|
|
ed25519: nil,
|
|
curve25519: nil,
|
|
text: "i cannot send message",
|
|
logFiles: Tracing.logFiles,
|
|
canContact: false,
|
|
githubLabels: [],
|
|
files: [])
|
|
let progressSubject = CurrentValueSubject<Double, Never>(0.0)
|
|
let response = try await service.submitBugReport(bugReport, progressListener: progressSubject).get()
|
|
|
|
#expect(response.reportURL == "https://example.com/123")
|
|
}
|
|
|
|
@Test
|
|
@MainActor
|
|
func configurations() async throws {
|
|
guard case let .url(initialURL) = appSettings.bugReportRageshakeURL.publisher.value else {
|
|
Issue.record("Unexpected initial configuration.")
|
|
return
|
|
}
|
|
|
|
let service = BugReportService(rageshakeURLPublisher: appSettings.bugReportRageshakeURL.publisher,
|
|
applicationID: "mock_app_id",
|
|
sdkGitSHA: "1234",
|
|
session: .mock,
|
|
appHooks: AppHooks())
|
|
#expect(service.isEnabled)
|
|
|
|
appSettings.bugReportRageshakeURL.applyRemoteValue(.disabled)
|
|
#expect(!service.isEnabled)
|
|
|
|
appSettings.bugReportRageshakeURL.applyRemoteValue(.url("https://bugs.server.net/submit"))
|
|
#expect(service.isEnabled)
|
|
|
|
let bugReport = BugReport(userID: "@mock:client.com",
|
|
deviceID: nil,
|
|
ed25519: nil,
|
|
curve25519: nil,
|
|
text: "i cannot send message",
|
|
logFiles: Tracing.logFiles,
|
|
canContact: false,
|
|
githubLabels: [],
|
|
files: [])
|
|
let progressSubject = CurrentValueSubject<Double, Never>(0.0)
|
|
let customConfigurationResponse = try await service.submitBugReport(bugReport, progressListener: progressSubject).get()
|
|
|
|
#expect(customConfigurationResponse.reportURL == "https://bugs.server.net/123")
|
|
|
|
appSettings.bugReportRageshakeURL.reset()
|
|
#expect(service.isEnabled)
|
|
|
|
let defaultConfigurationResponse = try await service.submitBugReport(bugReport, progressListener: progressSubject).get()
|
|
|
|
#expect(defaultConfigurationResponse.reportURL == initialURL.absoluteString.replacingOccurrences(of: "submit", with: "123"))
|
|
}
|
|
}
|
|
|
|
private class MockURLProtocol: URLProtocol {
|
|
override func startLoading() {
|
|
guard let url = request.url else { return }
|
|
let reportURL = url.deletingLastPathComponent().appending(path: "123")
|
|
let response = "{\"report_url\":\"\(reportURL.absoluteString)\"}"
|
|
|
|
if let data = response.data(using: .utf8),
|
|
let urlResponse = HTTPURLResponse(url: url, statusCode: 200, httpVersion: nil, headerFields: nil) {
|
|
client?.urlProtocol(self, didReceive: urlResponse, cacheStoragePolicy: .allowedInMemoryOnly)
|
|
client?.urlProtocol(self, didLoad: data)
|
|
client?.urlProtocolDidFinishLoading(self)
|
|
}
|
|
}
|
|
|
|
override func stopLoading() {
|
|
// no-op
|
|
}
|
|
|
|
override class func canonicalRequest(for request: URLRequest) -> URLRequest {
|
|
request
|
|
}
|
|
|
|
override class func canInit(with request: URLRequest) -> Bool {
|
|
true
|
|
}
|
|
}
|
|
|
|
private extension URLSession {
|
|
static var mock: URLSession {
|
|
let configuration = URLSessionConfiguration.default
|
|
configuration.protocolClasses = [MockURLProtocol.self] + (configuration.protocolClasses ?? [])
|
|
return URLSession(configuration: configuration)
|
|
}
|
|
}
|