* Initial plan * Migrate 3 test files from XCTest to Swift Testing - MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(), BundleFinder class for Bundle(for:), mutating test/setup functions, [self] capture replacing [weak self] in closures - NotificationManagerTests: @MainActor @Suite final class with init()/deinit, expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped - NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with init() throws, non-optional stored properties, test prefix stripped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 3 XCTest files to Swift Testing - NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods - TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit - AttributedStringBuilderTests: @Suite struct with init() async throws All XCT assertions replaced with #expect/#require/Issue.record Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs, testLoadingItem renamed to loadingItem (called internally by other tests) - ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit - CompletionSuggestionServiceTests: @Suite struct with init() - RoomFlowCoordinatorTests: @Suite final class with deinit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - VoiceMessageRecorderTests: @Suite struct with init() async throws, added BundleFinder class for Bundle lookup, migrated all assertions - SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel, all test funcs mutating, XCTestExpectation → confirmation - RoomNotificationSettingsScreenViewModelTests: @Suite struct with init() throws, cancellable tests marked mutating - JoinRoomScreenViewModelTests: @Suite final class with init()/deinit, XCTestExpectation → confirmation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 6 test files from XCTestCase to Swift Testing Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Fix trailing blank line in RoomPollsHistoryScreenViewModelTests Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Migrate 3 test files from XCTest to Swift Testing - MediaUploadingPreprocessorTests: @Suite final class with init()/deinit, removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double) - SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class, 5 expectation+fulfillment → await confirmation(...) - CreateRoomViewModelTests: @MainActor @Suite final class, 4 expectation+fulfillment → await confirmation(...) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing - Replace XCTest with Testing framework - RoomScreenViewModelTests: final class with init() async throws + deinit - RoomDetailsScreenViewModelTests: struct with init() and mutating funcs - Convert XCT assertions to #expect / Issue.record - Convert XCTestExpectation patterns to confirmation { confirm in } - Strip 'test' prefix from all test function names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing - Replace import XCTest with import Testing - Convert XCTestCase class to @MainActor @Suite final class - Replace setUp()/tearDown() with init()/deinit - Strip 'test' prefix from all 41 test method names and add @Test - Replace XCTAssert* with #expect()/#require() - Replace try XCTUnwrap() with try #require() - Convert expectation+wait patterns to deferFulfillment with PassthroughSubject - Convert isInverted expectation to boolean flag checked after await - Use deferFulfillment on $viewState for state-transition tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address comments with Copilot. * Fix the failing tests. * Fixed flaky tests (#5137) resolved flaky tests * Tweaks and fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
102 lines
4.1 KiB
Swift
102 lines
4.1 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Compound
|
|
import SwiftUI
|
|
|
|
struct RoomNotificationSettingsScreen: View {
|
|
@Bindable var context: RoomNotificationSettingsScreenViewModel.Context
|
|
|
|
var body: some View {
|
|
Form {
|
|
allowCustomSettingSection
|
|
|
|
if !context.allowCustomSetting {
|
|
defaultSettingSection
|
|
} else {
|
|
customSettingsSection
|
|
}
|
|
}
|
|
.compoundList()
|
|
.navigationTitle(context.viewState.navigationTitle)
|
|
.alert(item: $context.alertInfo)
|
|
.track(screen: .RoomNotifications)
|
|
}
|
|
|
|
// MARK: - Private
|
|
|
|
private var allowCustomSettingSection: some View {
|
|
Section {
|
|
ListRow(label: .plain(title: L10n.screenRoomNotificationSettingsAllowCustom),
|
|
kind: .toggle($context.allowCustomSetting))
|
|
.accessibilityIdentifier(A11yIdentifiers.roomNotificationSettingsScreen.allowCustomSetting)
|
|
.disabled(context.viewState.notificationSettingsState.isLoading)
|
|
.onChange(of: context.allowCustomSetting) {
|
|
context.send(viewAction: .changedAllowCustomSettings)
|
|
}
|
|
} footer: {
|
|
Text(L10n.screenRoomNotificationSettingsAllowCustomFootnote)
|
|
.compoundListSectionFooter()
|
|
}
|
|
}
|
|
|
|
private var defaultSettingSection: some View {
|
|
Section {
|
|
ListRow(label: .plain(title: context.viewState.isRestoringDefaultSetting ? L10n.commonLoading : context.viewState.strings.string(for: context.viewState.notificationSettingsState)),
|
|
kind: .label)
|
|
.disabled(context.viewState.isRestoringDefaultSetting)
|
|
} header: {
|
|
Text(L10n.screenRoomNotificationSettingsDefaultSettingTitle)
|
|
.compoundListSectionHeader()
|
|
} footer: {
|
|
Text(context.viewState.strings.customSettingFootnote)
|
|
.environment(\.openURL, OpenURLAction { url in
|
|
guard url == context.viewState.strings.customSettingFootnoteLink else { return .discarded }
|
|
context.send(viewAction: .customSettingFootnoteLinkTapped)
|
|
return .handled
|
|
})
|
|
.compoundListSectionFooter()
|
|
}
|
|
}
|
|
|
|
private var customSettingsSection: some View {
|
|
RoomNotificationSettingsCustomSectionView(context: context)
|
|
}
|
|
}
|
|
|
|
// MARK: - Previews
|
|
|
|
struct RoomNotificationSettingsScreen_Previews: PreviewProvider, TestablePreview {
|
|
static let viewModel = {
|
|
let notificationSettingsProxy = NotificationSettingsProxyMock(with: .init(defaultRoomMode: .mentionsAndKeywordsOnly, roomMode: .mentionsAndKeywordsOnly))
|
|
|
|
let roomProxy = JoinedRoomProxyMock(.init(name: "Room", isEncrypted: true))
|
|
|
|
return RoomNotificationSettingsScreenViewModel(notificationSettingsProxy: notificationSettingsProxy,
|
|
roomProxy: roomProxy,
|
|
displayAsUserDefinedRoomSettings: false)
|
|
}()
|
|
|
|
static let viewModelCustom = {
|
|
let notificationSettingsProxy = NotificationSettingsProxyMock(with: .init(defaultRoomMode: .allMessages, roomMode: .mentionsAndKeywordsOnly))
|
|
|
|
let roomProxy = JoinedRoomProxyMock(.init(name: "Room", isEncrypted: true))
|
|
|
|
return RoomNotificationSettingsScreenViewModel(notificationSettingsProxy: notificationSettingsProxy,
|
|
roomProxy: roomProxy,
|
|
displayAsUserDefinedRoomSettings: false)
|
|
}()
|
|
|
|
static var previews: some View {
|
|
RoomNotificationSettingsScreen(context: viewModel.context)
|
|
.previewDisplayName("Default")
|
|
RoomNotificationSettingsScreen(context: viewModelCustom.context)
|
|
.previewDisplayName("Custom")
|
|
}
|
|
}
|