Files
letro-ios/UnitTests/Sources/SessionVerificationViewModelTests.swift
Stefan Ceriu 7eda122d20 Fix various flakey unit tests (#1783)
* Fix flakey emoji provider tests

* Fix flakey RoomScreenViewModel tests

* Fix flakey HomeScreenViewModel tests

* Fix flakey RoomMemberListScreen tests, problem with bindings getting overriden and deferFulfillment cancellable not getting stored

* Fix flakey RoomNotificationSettingsScreen tests and crashes

* Fix flakey RoomMemberDetailsScreen tests

* Deprecate old `deferFulfillment` and `nextViewState` methods

* Convert more files to the new `deferFulfillment`

* Converted the rest of the tests to the new deferFulfillment

* Removed now unused `nextViewState` and `deferFulfillment`

* Remove automatic retries from unit tests

* Reset analytics flag after running unit tests

* Address PR comments

* Introduce a new `deferFulfillment(publisher, keyPath, transitionValues)` method and use it where appropiate
2023-09-26 13:28:29 +03:00

170 lines
6.5 KiB
Swift

//
// Copyright 2022 New Vector Ltd
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
import Combine
import XCTest
@testable import ElementX
@MainActor
class SessionVerificationViewModelTests: XCTestCase {
var viewModel: SessionVerificationScreenViewModelProtocol!
var context: SessionVerificationViewModelType.Context!
var sessionVerificationController: SessionVerificationControllerProxyMock!
override func setUpWithError() throws {
sessionVerificationController = SessionVerificationControllerProxyMock.configureMock()
viewModel = SessionVerificationScreenViewModel(sessionVerificationControllerProxy: sessionVerificationController)
context = viewModel.context
}
func testRequestVerification() async throws {
XCTAssertEqual(context.viewState.verificationState, .initial)
context.send(viewAction: .requestVerification)
try await Task.sleep(for: .milliseconds(100))
XCTAssert(sessionVerificationController.requestVerificationCallsCount == 1)
XCTAssertEqual(context.viewState.verificationState, .requestingVerification)
}
func testVerificationCancellation() async throws {
XCTAssertEqual(context.viewState.verificationState, .initial)
context.send(viewAction: .requestVerification)
context.send(viewAction: .close)
XCTAssertEqual(context.viewState.verificationState, .cancelling)
let deferred = deferFulfillment(context.$viewState) { state in
state.verificationState == .cancelled
}
try await deferred.fulfill()
XCTAssertEqual(context.viewState.verificationState, .cancelled)
context.send(viewAction: .restart)
XCTAssertEqual(context.viewState.verificationState, .initial)
XCTAssert(sessionVerificationController.requestVerificationCallsCount == 1)
XCTAssert(sessionVerificationController.cancelVerificationCallsCount == 1)
}
func testReceiveChallenge() {
setupChallengeReceived()
}
func testAcceptChallenge() {
setupChallengeReceived()
let waitForAcceptance = XCTestExpectation(description: "Wait for acceptance")
let cancellable = sessionVerificationController.callbacks
.delay(for: .seconds(0.1), scheduler: DispatchQueue.main) // Allow the view model to process the callback first.
.sink { callback in
switch callback {
case .finished:
waitForAcceptance.fulfill()
default:
XCTFail("Unexpected session verification controller callback")
}
}
defer {
cancellable.cancel()
}
context.send(viewAction: .accept)
wait(for: [waitForAcceptance], timeout: 10.0)
XCTAssertEqual(context.viewState.verificationState, .verified)
XCTAssert(sessionVerificationController.approveVerificationCallsCount == 1)
}
func testDeclineChallenge() {
setupChallengeReceived()
let expectation = XCTestExpectation(description: "Wait for cancellation")
let cancellable = sessionVerificationController.callbacks
.delay(for: .seconds(0.1), scheduler: DispatchQueue.main) // Allow the view model to process the callback first.
.sink { callback in
switch callback {
case .cancelled:
expectation.fulfill()
default:
XCTFail("Unexpected session verification controller callback")
}
}
defer {
cancellable.cancel()
}
context.send(viewAction: .decline)
wait(for: [expectation], timeout: 10.0)
XCTAssertEqual(context.viewState.verificationState, .cancelled)
XCTAssert(sessionVerificationController.declineVerificationCallsCount == 1)
}
// MARK: - Private
private func setupChallengeReceived() {
let requestAcceptanceExpectation = XCTestExpectation(description: "Wait for request acceptance")
let sasVerificationStartExpectation = XCTestExpectation(description: "Wait for SaS verification start")
let verificationDataReceivalExpectation = XCTestExpectation(description: "Wait for Emoji data")
let cancellable = sessionVerificationController.callbacks
.delay(for: .seconds(0.1), scheduler: DispatchQueue.main) // Allow the view model to process the callback first.
.sink { callback in
switch callback {
case .acceptedVerificationRequest:
requestAcceptanceExpectation.fulfill()
case .startedSasVerification:
sasVerificationStartExpectation.fulfill()
case .receivedVerificationData:
verificationDataReceivalExpectation.fulfill()
default:
break
}
}
defer {
cancellable.cancel()
}
context.send(viewAction: .requestVerification)
wait(for: [requestAcceptanceExpectation], timeout: 10.0)
XCTAssertEqual(context.viewState.verificationState, .verificationRequestAccepted)
context.send(viewAction: .startSasVerification)
wait(for: [sasVerificationStartExpectation], timeout: 10.0)
XCTAssertEqual(context.viewState.verificationState, .sasVerificationStarted)
wait(for: [verificationDataReceivalExpectation], timeout: 10.0)
XCTAssertEqual(context.viewState.verificationState, .showingChallenge(emojis: SessionVerificationControllerProxyMock.emojis))
XCTAssert(sessionVerificationController.requestVerificationCallsCount == 1)
XCTAssert(sessionVerificationController.startSasVerificationCallsCount == 1)
}
}