* Initial plan * Migrate 3 test files from XCTest to Swift Testing - MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(), BundleFinder class for Bundle(for:), mutating test/setup functions, [self] capture replacing [weak self] in closures - NotificationManagerTests: @MainActor @Suite final class with init()/deinit, expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped - NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with init() throws, non-optional stored properties, test prefix stripped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 3 XCTest files to Swift Testing - NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods - TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit - AttributedStringBuilderTests: @Suite struct with init() async throws All XCT assertions replaced with #expect/#require/Issue.record Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs, testLoadingItem renamed to loadingItem (called internally by other tests) - ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit - CompletionSuggestionServiceTests: @Suite struct with init() - RoomFlowCoordinatorTests: @Suite final class with deinit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - VoiceMessageRecorderTests: @Suite struct with init() async throws, added BundleFinder class for Bundle lookup, migrated all assertions - SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel, all test funcs mutating, XCTestExpectation → confirmation - RoomNotificationSettingsScreenViewModelTests: @Suite struct with init() throws, cancellable tests marked mutating - JoinRoomScreenViewModelTests: @Suite final class with init()/deinit, XCTestExpectation → confirmation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 6 test files from XCTestCase to Swift Testing Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Fix trailing blank line in RoomPollsHistoryScreenViewModelTests Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Migrate 3 test files from XCTest to Swift Testing - MediaUploadingPreprocessorTests: @Suite final class with init()/deinit, removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double) - SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class, 5 expectation+fulfillment → await confirmation(...) - CreateRoomViewModelTests: @MainActor @Suite final class, 4 expectation+fulfillment → await confirmation(...) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing - Replace XCTest with Testing framework - RoomScreenViewModelTests: final class with init() async throws + deinit - RoomDetailsScreenViewModelTests: struct with init() and mutating funcs - Convert XCT assertions to #expect / Issue.record - Convert XCTestExpectation patterns to confirmation { confirm in } - Strip 'test' prefix from all test function names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing - Replace import XCTest with import Testing - Convert XCTestCase class to @MainActor @Suite final class - Replace setUp()/tearDown() with init()/deinit - Strip 'test' prefix from all 41 test method names and add @Test - Replace XCTAssert* with #expect()/#require() - Replace try XCTUnwrap() with try #require() - Convert expectation+wait patterns to deferFulfillment with PassthroughSubject - Convert isInverted expectation to boolean flag checked after await - Use deferFulfillment on $viewState for state-transition tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address comments with Copilot. * Fix the failing tests. * Fixed flaky tests (#5137) resolved flaky tests * Tweaks and fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
175 lines
6.2 KiB
Swift
175 lines
6.2 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import MatrixRustSDK
|
|
import Testing
|
|
|
|
@Suite
|
|
@MainActor
|
|
struct RoomDetailsEditScreenViewModelTests {
|
|
var viewModel: RoomDetailsEditScreenViewModel!
|
|
|
|
var userIndicatorController: UserIndicatorControllerMock!
|
|
|
|
var context: RoomDetailsEditScreenViewModelType.Context {
|
|
viewModel.context
|
|
}
|
|
|
|
@Test
|
|
mutating func cannotSaveOnLanding() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
#expect(!context.viewState.canSave)
|
|
}
|
|
|
|
@Test
|
|
mutating func canEdit() async throws {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.canEditName }
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.canEditAvatar)
|
|
#expect(context.viewState.canEditName)
|
|
#expect(context.viewState.canEditTopic)
|
|
}
|
|
|
|
@Test
|
|
mutating func cannotEdit() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMe]))
|
|
#expect(!context.viewState.canEditAvatar)
|
|
#expect(!context.viewState.canEditName)
|
|
#expect(!context.viewState.canEditTopic)
|
|
}
|
|
|
|
@Test
|
|
mutating func nameDidChange() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
context.name = "name"
|
|
#expect(context.viewState.nameDidChange)
|
|
#expect(context.viewState.canSave)
|
|
}
|
|
|
|
@Test
|
|
mutating func topicDidChange() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
context.topic = "topic"
|
|
#expect(context.viewState.topicDidChange)
|
|
#expect(context.viewState.canSave)
|
|
}
|
|
|
|
@Test
|
|
mutating func avatarDidChange() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", avatarURL: .mockMXCAvatar, members: [.mockMeAdmin]))
|
|
context.send(viewAction: .removeImage)
|
|
#expect(context.viewState.avatarDidChange)
|
|
#expect(context.viewState.canSave)
|
|
}
|
|
|
|
@Test
|
|
mutating func emptyNameCannotBeSaved() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
context.name = ""
|
|
#expect(!context.viewState.canSave)
|
|
}
|
|
|
|
@Test
|
|
mutating func avatarPickerShowsSheet() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
context.name = "name"
|
|
#expect(!context.showMediaSheet)
|
|
context.send(viewAction: .presentMediaSource)
|
|
#expect(context.showMediaSheet)
|
|
}
|
|
|
|
@Test
|
|
mutating func saveTriggersViewModelAction() async throws {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { action in
|
|
action == .saveFinished
|
|
}
|
|
|
|
context.name = "name"
|
|
context.send(viewAction: .save)
|
|
|
|
let action = try await deferred.fulfill()
|
|
#expect(action == .saveFinished)
|
|
}
|
|
|
|
@Test
|
|
mutating func cancelWithoutChanges() async throws {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
#expect(!context.viewState.canSave)
|
|
#expect(context.alertInfo == nil)
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { $0 == .cancel }
|
|
context.send(viewAction: .cancel)
|
|
try await deferred.fulfill()
|
|
#expect(context.alertInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func cancelWithChangesAndDiscard() async throws {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
context.name = "name"
|
|
#expect(context.viewState.canSave)
|
|
#expect(context.alertInfo == nil)
|
|
|
|
context.send(viewAction: .cancel)
|
|
|
|
#expect(context.alertInfo != nil)
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { $0 == .cancel }
|
|
context.alertInfo?.secondaryButton?.action?() // Discard
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
mutating func cancelWithChangesAndSave() async throws {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
context.name = "name"
|
|
#expect(context.viewState.canSave)
|
|
#expect(context.alertInfo == nil)
|
|
|
|
context.send(viewAction: .cancel)
|
|
|
|
#expect(context.alertInfo != nil)
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { $0 == .saveFinished }
|
|
context.alertInfo?.primaryButton.action?() // Save
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
mutating func errorShownOnFailedFetchOfMedia() async {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", members: [.mockMeAdmin]))
|
|
viewModel.didSelectMediaUrl(url: .picturesDirectory)
|
|
try? await Task.sleep(for: .milliseconds(100))
|
|
#expect(context.alertInfo != nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func deleteAvatar() {
|
|
setupViewModel(roomProxyConfiguration: .init(name: "Some room", avatarURL: .mockMXCAvatar, members: [.mockMeAdmin]))
|
|
#expect(context.viewState.avatarURL != nil)
|
|
context.send(viewAction: .removeImage)
|
|
#expect(context.viewState.avatarURL == nil)
|
|
}
|
|
|
|
// MARK: - Private
|
|
|
|
private mutating func setupViewModel(roomProxyConfiguration: JoinedRoomProxyMockConfiguration) {
|
|
userIndicatorController = UserIndicatorControllerMock.default
|
|
viewModel = .init(roomProxy: JoinedRoomProxyMock(roomProxyConfiguration),
|
|
userSession: UserSessionMock(.init()),
|
|
mediaUploadingPreprocessor: MediaUploadingPreprocessor(appSettings: ServiceLocator.shared.settings),
|
|
userIndicatorController: userIndicatorController)
|
|
}
|
|
}
|