Files
letro-ios/UnitTests/Sources/EditRoomAddressScreenViewModelTests.swift
Copilot 4834f453ef Finish migration of UnitTests target from XCTestCase to Swift Testing (#5129)
* Initial plan

* Migrate 3 test files from XCTest to Swift Testing

- MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(),
  BundleFinder class for Bundle(for:), mutating test/setup functions,
  [self] capture replacing [weak self] in closures
- NotificationManagerTests: @MainActor @Suite final class with init()/deinit,
  expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped
- NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with
  init() throws, non-optional stored properties, test prefix stripped

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 3 XCTest files to Swift Testing

- NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods
- TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit
- AttributedStringBuilderTests: @Suite struct with init() async throws

All XCT assertions replaced with #expect/#require/Issue.record

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 4 test files from XCTest to Swift Testing

- TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs,
  testLoadingItem renamed to loadingItem (called internally by other tests)
- ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit
- CompletionSuggestionServiceTests: @Suite struct with init()
- RoomFlowCoordinatorTests: @Suite final class with deinit

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 4 test files from XCTest to Swift Testing

- VoiceMessageRecorderTests: @Suite struct with init() async throws,
  added BundleFinder class for Bundle lookup, migrated all assertions
- SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel,
  all test funcs mutating, XCTestExpectation → confirmation
- RoomNotificationSettingsScreenViewModelTests: @Suite struct with
  init() throws, cancellable tests marked mutating
- JoinRoomScreenViewModelTests: @Suite final class with init()/deinit,
  XCTestExpectation → confirmation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 6 test files from XCTestCase to Swift Testing

Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>

* Fix trailing blank line in RoomPollsHistoryScreenViewModelTests

Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>

* Migrate 3 test files from XCTest to Swift Testing

- MediaUploadingPreprocessorTests: @Suite final class with init()/deinit,
  removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double)
- SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class,
  5 expectation+fulfillment → await confirmation(...)
- CreateRoomViewModelTests: @MainActor @Suite final class,
  4 expectation+fulfillment → await confirmation(...)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing

- Replace XCTest with Testing framework
- RoomScreenViewModelTests: final class with init() async throws + deinit
- RoomDetailsScreenViewModelTests: struct with init() and mutating funcs
- Convert XCT assertions to #expect / Issue.record
- Convert XCTestExpectation patterns to confirmation { confirm in }
- Strip 'test' prefix from all test function names

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing

- Replace import XCTest with import Testing
- Convert XCTestCase class to @MainActor @Suite final class
- Replace setUp()/tearDown() with init()/deinit
- Strip 'test' prefix from all 41 test method names and add @Test
- Replace XCTAssert* with #expect()/#require()
- Replace try XCTUnwrap() with try #require()
- Convert expectation+wait patterns to deferFulfillment with PassthroughSubject
- Convert isInverted expectation to boolean flag checked after await
- Use deferFulfillment on $viewState for state-transition tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address comments with Copilot.

* Fix the failing tests.

* Fixed flaky tests (#5137)

resolved flaky tests

* Tweaks and fixes.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <douglase@element.io>
Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
2026-02-24 12:20:01 +00:00

181 lines
8.0 KiB
Swift

//
// Copyright 2025 Element Creations Ltd.
// Copyright 2022-2025 New Vector Ltd.
//
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
// Please see LICENSE in the repository root for full details.
//
@testable import ElementX
import Testing
@Suite
@MainActor
struct EditRoomAddressScreenViewModelTests {
var viewModel: EditRoomAddressScreenViewModelProtocol!
var context: EditRoomAddressScreenViewModelType.Context {
viewModel.context
}
@Test
mutating func canonicalAliasChosen() async throws {
let roomProxy = JoinedRoomProxyMock(.init(name: "Room Name", canonicalAlias: "#room-name:matrix.org",
alternativeAliases: ["#beta:homeserver.io",
"#alternative-room-name:matrix.org"]))
viewModel = EditRoomAddressScreenViewModel(roomProxy: roomProxy,
clientProxy: ClientProxyMock(.init(userIDServerName: "matrix.org")),
userIndicatorController: UserIndicatorControllerMock())
let deferred = deferFulfillment(context.$viewState) { state in
state.bindings.desiredAliasLocalPart == "room-name"
}
try await deferred.fulfill()
}
/// Priority should be given to aliases from the current user's homeserver as they can edit those.
@Test
mutating func alternativeAliasChosen() async throws {
let roomProxy = JoinedRoomProxyMock(.init(name: "Room Name", canonicalAlias: "#alpha:homeserver.io",
alternativeAliases: ["#beta:homeserver.io",
"#room-name:matrix.org",
"#alternative-room-name:matrix.org"]))
viewModel = EditRoomAddressScreenViewModel(roomProxy: roomProxy,
clientProxy: ClientProxyMock(.init(userIDServerName: "matrix.org")),
userIndicatorController: UserIndicatorControllerMock())
let deferred = deferFulfillment(context.$viewState) { state in
state.bindings.desiredAliasLocalPart == "room-name"
}
try await deferred.fulfill()
}
@Test
mutating func buildAliasFromDisplayName() async throws {
let roomProxy = JoinedRoomProxyMock(.init(name: "Room Name"))
viewModel = EditRoomAddressScreenViewModel(roomProxy: roomProxy,
clientProxy: ClientProxyMock(.init(userIDServerName: "matrix.org")),
userIndicatorController: UserIndicatorControllerMock())
let deferred = deferFulfillment(context.$viewState) { state in
state.bindings.desiredAliasLocalPart == "room-name"
}
try await deferred.fulfill()
}
@Test
mutating func correctMethodsCalledOnSaveWhenNoAliasExists() async {
let clientProxy = ClientProxyMock(.init(userIDServerName: "matrix.org"))
clientProxy.isAliasAvailableReturnValue = .success(true)
let roomProxy = JoinedRoomProxyMock(.init(name: "Room Name"))
viewModel = EditRoomAddressScreenViewModel(roomProxy: roomProxy,
clientProxy: clientProxy,
userIndicatorController: UserIndicatorControllerMock())
#expect(roomProxy.infoPublisher.value.canonicalAlias == nil)
#expect(viewModel.context.viewState.bindings.desiredAliasLocalPart == "room-name")
await waitForConfirmation("Wait for save", expectedCount: 2) { confirm in
roomProxy.publishRoomAliasInRoomDirectoryClosure = { roomAlias in
#expect(roomAlias == "#room-name:matrix.org")
confirm()
return .success(true)
}
roomProxy.updateCanonicalAliasAltAliasesClosure = { roomAlias, altAliases in
#expect(altAliases == [])
#expect(roomAlias == "#room-name:matrix.org")
confirm()
return .success(())
}
context.send(viewAction: .save)
}
#expect(roomProxy.publishRoomAliasInRoomDirectoryCalled)
#expect(roomProxy.updateCanonicalAliasAltAliasesCalled)
#expect(!roomProxy.removeRoomAliasFromRoomDirectoryCalled)
}
@Test
mutating func correctMethodsCalledOnSaveWhenAliasOnSameHomeserverExists() async {
let clientProxy = ClientProxyMock(.init(userIDServerName: "matrix.org"))
clientProxy.isAliasAvailableReturnValue = .success(true)
let roomProxy = JoinedRoomProxyMock(.init(name: "Room Name", canonicalAlias: "#old-room-name:matrix.org"))
viewModel = EditRoomAddressScreenViewModel(roomProxy: roomProxy,
clientProxy: clientProxy,
userIndicatorController: UserIndicatorControllerMock())
context.desiredAliasLocalPart = "room-name"
await waitForConfirmation("Wait for save", expectedCount: 3) { confirm in
roomProxy.publishRoomAliasInRoomDirectoryClosure = { roomAlias in
#expect(roomAlias == "#room-name:matrix.org")
confirm()
return .success(true)
}
roomProxy.updateCanonicalAliasAltAliasesClosure = { roomAlias, altAliases in
#expect(altAliases == [])
#expect(roomAlias == "#room-name:matrix.org")
confirm()
return .success(())
}
roomProxy.removeRoomAliasFromRoomDirectoryClosure = { roomAlias in
#expect(roomAlias == "#old-room-name:matrix.org")
confirm()
return .success(true)
}
context.send(viewAction: .save)
}
#expect(roomProxy.publishRoomAliasInRoomDirectoryCalled)
#expect(roomProxy.updateCanonicalAliasAltAliasesCalled)
#expect(roomProxy.removeRoomAliasFromRoomDirectoryCalled)
}
@Test
mutating func correctMethodsCalledOnSaveWhenAliasOnOtherHomeserverExists() async {
let clientProxy = ClientProxyMock(.init(userIDServerName: "matrix.org"))
clientProxy.isAliasAvailableReturnValue = .success(true)
let roomProxy = JoinedRoomProxyMock(.init(name: "Room Name", canonicalAlias: "#old-room-name:element.io"))
viewModel = EditRoomAddressScreenViewModel(roomProxy: roomProxy,
clientProxy: clientProxy,
userIndicatorController: UserIndicatorControllerMock())
context.desiredAliasLocalPart = "room-name"
await waitForConfirmation("Wait for save", expectedCount: 2) { confirm in
roomProxy.publishRoomAliasInRoomDirectoryClosure = { roomAlias in
#expect(roomAlias == "#room-name:matrix.org")
confirm()
return .success(true)
}
roomProxy.updateCanonicalAliasAltAliasesClosure = { roomAlias, altAliases in
#expect(altAliases == ["#room-name:matrix.org"])
#expect(roomAlias == "#old-room-name:element.io")
confirm()
return .success(())
}
context.send(viewAction: .save)
}
#expect(roomProxy.publishRoomAliasInRoomDirectoryCalled)
#expect(roomProxy.updateCanonicalAliasAltAliasesCalled)
#expect(!roomProxy.removeRoomAliasFromRoomDirectoryCalled)
}
}