* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment more tests migration Cleaned the code manually to establish some good patterns more code improvements some more code improvements removed empty tests update project * more pr suggestions and cleanups * removed the TestSetup pattern * fixing claude not reusing tests * pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
111 lines
4.2 KiB
Swift
111 lines
4.2 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Combine
|
|
@testable import ElementX
|
|
import Testing
|
|
|
|
@MainActor
|
|
@Suite
|
|
final class SpacesScreenViewModelTests {
|
|
var topLevelSpacesSubject: CurrentValueSubject<[SpaceServiceRoom], Never>
|
|
var spaceServiceProxy: SpaceServiceProxyMock
|
|
var appSettings: AppSettings
|
|
var viewModel: SpacesScreenViewModelProtocol
|
|
|
|
var context: SpacesScreenViewModelType.Context {
|
|
viewModel.context
|
|
}
|
|
|
|
init() {
|
|
AppSettings.resetAllSettings()
|
|
appSettings = AppSettings()
|
|
|
|
let clientProxy = ClientProxyMock(.init())
|
|
let userSession = UserSessionMock(.init(clientProxy: clientProxy))
|
|
|
|
topLevelSpacesSubject = .init([
|
|
SpaceServiceRoom.mock(id: "space1", isSpace: true),
|
|
SpaceServiceRoom.mock(id: "space2", isSpace: true),
|
|
SpaceServiceRoom.mock(id: "space3", isSpace: true)
|
|
])
|
|
spaceServiceProxy = SpaceServiceProxyMock(.init())
|
|
spaceServiceProxy.topLevelSpacesPublisher = topLevelSpacesSubject.asCurrentValuePublisher()
|
|
spaceServiceProxy.spaceRoomListSpaceIDClosure = { [topLevelSpacesSubject] spaceID in
|
|
guard let spaceServiceRoom = topLevelSpacesSubject.value.first(where: { $0.id == spaceID }) else { return .failure(.missingSpace) }
|
|
return .success(SpaceRoomListProxyMock(.init(spaceServiceRoom: spaceServiceRoom)))
|
|
}
|
|
clientProxy.spaceService = spaceServiceProxy
|
|
|
|
viewModel = SpacesScreenViewModel(userSession: userSession,
|
|
selectedSpacePublisher: .init(nil),
|
|
appSettings: ServiceLocator.shared.settings,
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
}
|
|
|
|
deinit {
|
|
AppSettings.resetAllSettings()
|
|
}
|
|
|
|
@Test
|
|
func initialState() {
|
|
#expect(context.viewState.topLevelSpaces.count == 3)
|
|
}
|
|
|
|
@Test
|
|
func topLevelSpacesSubscription() async throws {
|
|
var deferred = deferFulfillment(context.observe(\.viewState.topLevelSpaces)) { $0.count == 0 }
|
|
topLevelSpacesSubject.send([])
|
|
try await deferred.fulfill()
|
|
#expect(context.viewState.topLevelSpaces.count == 0)
|
|
|
|
deferred = deferFulfillment(context.observe(\.viewState.topLevelSpaces)) { $0.count == 1 }
|
|
topLevelSpacesSubject.send([
|
|
SpaceServiceRoom.mock(isSpace: true)
|
|
])
|
|
try await deferred.fulfill()
|
|
#expect(context.viewState.topLevelSpaces.count == 1)
|
|
}
|
|
|
|
@Test
|
|
func selectingSpace() async throws {
|
|
let selectedSpace = topLevelSpacesSubject.value[0]
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { _ in true }
|
|
viewModel.context.send(viewAction: .spaceAction(.select(selectedSpace)))
|
|
let action = try await deferred.fulfill()
|
|
|
|
switch action {
|
|
case .selectSpace(let spaceRoomListProxy) where spaceRoomListProxy.id == selectedSpace.id:
|
|
break
|
|
default:
|
|
Issue.record("The action should select the space.")
|
|
}
|
|
}
|
|
|
|
@Test
|
|
func featureAnnouncement() async throws {
|
|
#expect(!appSettings.hasSeenSpacesAnnouncement)
|
|
#expect(!context.isPresentingFeatureAnnouncement)
|
|
|
|
let deferred = deferFulfillment(context.observe(\.isPresentingFeatureAnnouncement)) { $0 == true }
|
|
viewModel.context.send(viewAction: .screenAppeared)
|
|
try await deferred.fulfill()
|
|
#expect(context.isPresentingFeatureAnnouncement)
|
|
|
|
viewModel.context.send(viewAction: .featureAnnouncementAppeared)
|
|
#expect(appSettings.hasSeenSpacesAnnouncement)
|
|
|
|
context.isPresentingFeatureAnnouncement = false
|
|
|
|
let deferredFailure = deferFailure(context.observe(\.isPresentingFeatureAnnouncement), timeout: .seconds(1)) { $0 == true }
|
|
viewModel.context.send(viewAction: .screenAppeared)
|
|
try await deferredFailure.fulfill()
|
|
#expect(!context.isPresentingFeatureAnnouncement)
|
|
}
|
|
}
|