Fixes #4713, fixes #4648 - Correctly handle span tags and data attributes.

This commit is contained in:
Stefan Ceriu
2025-11-07 12:48:01 +02:00
committed by Stefan Ceriu
parent cbcb61d8f3
commit d9c885c48c
2 changed files with 18 additions and 4 deletions

View File

@@ -1016,19 +1016,33 @@ class AttributedStringBuilderTests: XCTestCase {
}
func testMxExternalPaymentDetailsRemoved() {
let htmlString = "This is visible<span data-msc4286-external-payment-details>. But text is hidden <a href=\"https://matrix.org\">and this link too</a></span>"
var htmlString = "This is visible.<span data-msc4286-external-payment-details> But this is hidden <a href=\"https://matrix.org\">and this link too</a></span>"
guard let attributedString = attributedStringBuilder.fromHTML(htmlString) else {
XCTFail("Could not build the attributed string")
return
}
XCTAssertEqual(String(attributedString.characters), "This is visible")
XCTAssertEqual(String(attributedString.characters), "This is visible.")
for run in attributedString.runs where run.link != nil {
XCTFail("No link expected, but found one")
return
}
htmlString = "This is visible.<span> And this text <a href=\"https://matrix.org\">and link</a> are visible too.</span>"
guard let attributedString = attributedStringBuilder.fromHTML(htmlString) else {
XCTFail("Could not build the attributed string")
return
}
XCTAssertEqual(String(attributedString.characters), "This is visible. And this text and link are visible too.")
guard attributedString.runs.first(where: { $0.link != nil })?.link != nil else {
XCTFail("Couldn't find the link")
return
}
}
// MARK: - Private