refactor: manage member sheet in timeline

better implementation updated tests Update ElementX/Sources/Screens/Timeline/TimelineViewModel.swift Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com> fix
2025-04-08 15:23:40 +02:00
parent 6e04be3903
commit b3bff57ed9
44 changed files with 760 additions and 344 deletions
--- a/UnitTests/Sources/ManageRoomMemberSheetViewModelTests.swift
+++ b/UnitTests/Sources/ManageRoomMemberSheetViewModelTests.swift
@@ -0,0 +1,100 @@
+//
+// Copyright 2025 New Vector Ltd.
+//
+// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
+// Please see LICENSE files in the repository root for full details.
+//
+
+import XCTest
+
+@testable import ElementX
+
+@MainActor
+class ManageRoomMemberSheetViewModelTests: XCTestCase {
+    private var viewModel: ManageRoomMemberSheetViewModel!
+    private var context: ManageRoomMemberSheetViewModel.Context! {
+        viewModel.context
+    }
+    
+    func testKick() async throws {
+        let testReason = "Kick Test"
+        let roomProxy = JoinedRoomProxyMock(.init(members: [RoomMemberProxyMock.mockAdmin, RoomMemberProxyMock.mockAlice]))
+        let expectation = XCTestExpectation(description: "Kick member")
+        roomProxy.kickUserReasonClosure = { userID, reason in
+            defer { expectation.fulfill() }
+            XCTAssertEqual(userID, RoomMemberProxyMock.mockAlice.userID)
+            XCTAssertEqual(reason, testReason)
+            return .success(())
+        }
+        
+        viewModel = ManageRoomMemberSheetViewModel(member: RoomMemberDetails(withProxy: RoomMemberProxyMock.mockAlice),
+                                                   canKick: true,
+                                                   canBan: true,
+                                                   roomProxy: roomProxy,
+                                                   userIndicatorController: UserIndicatorControllerMock(),
+                                                   analyticsService: ServiceLocator.shared.analytics,
+                                                   mediaProvider: MediaProviderMock(configuration: .init()))
+        
+        let deferred = deferFulfillment(context.$viewState) { $0.bindings.alertInfo != nil }
+        let deferredAction = deferFulfillment(viewModel.actions) { action in
+            action == .dismiss(shouldShowDetails: false)
+        }
+        context.send(viewAction: .kick)
+        try await deferred.fulfill()
+        
+        context.alertInfo?.textFields?[0].text.wrappedValue = testReason
+        context.alertInfo?.secondaryButton?.action?()
+        await fulfillment(of: [expectation])
+        try await deferredAction.fulfill()
+    }
+    
+    func testBan() async throws {
+        let testReason = "Ban Test"
+        let roomProxy = JoinedRoomProxyMock(.init(members: [RoomMemberProxyMock.mockAdmin, RoomMemberProxyMock.mockAlice]))
+        let expectation = XCTestExpectation(description: "Ban member")
+        roomProxy.banUserReasonClosure = { userID, reason in
+            defer { expectation.fulfill() }
+            XCTAssertEqual(userID, RoomMemberProxyMock.mockAlice.userID)
+            XCTAssertEqual(reason, testReason)
+            return .success(())
+        }
+        
+        viewModel = ManageRoomMemberSheetViewModel(member: RoomMemberDetails(withProxy: RoomMemberProxyMock.mockAlice),
+                                                   canKick: true,
+                                                   canBan: true,
+                                                   roomProxy: roomProxy,
+                                                   userIndicatorController: UserIndicatorControllerMock(),
+                                                   analyticsService: ServiceLocator.shared.analytics,
+                                                   mediaProvider: MediaProviderMock(configuration: .init()))
+        
+        let deferred = deferFulfillment(context.$viewState) { $0.bindings.alertInfo != nil }
+        context.send(viewAction: .ban)
+        try await deferred.fulfill()
+        
+        let deferredAction = deferFulfillment(viewModel.actions) { action in
+            action == .dismiss(shouldShowDetails: false)
+        }
+        context.alertInfo?.textFields?[0].text.wrappedValue = testReason
+        context.alertInfo?.secondaryButton?.action?()
+        await fulfillment(of: [expectation])
+        try await deferredAction.fulfill()
+    }
+    
+    func testDisplayDetails() async throws {
+        let roomProxy = JoinedRoomProxyMock(.init(members: [RoomMemberProxyMock.mockAdmin, RoomMemberProxyMock.mockAlice]))
+        viewModel = ManageRoomMemberSheetViewModel(member: RoomMemberDetails(withProxy: RoomMemberProxyMock.mockAlice),
+                                                   canKick: true,
+                                                   canBan: true,
+                                                   roomProxy: roomProxy,
+                                                   userIndicatorController: UserIndicatorControllerMock(),
+                                                   analyticsService: ServiceLocator.shared.analytics,
+                                                   mediaProvider: MediaProviderMock(configuration: .init()))
+        
+        let deferredAction = deferFulfillment(viewModel.actions) { action in
+            action == .dismiss(shouldShowDetails: true)
+        }
+        context.send(viewAction: .displayDetails)
+        try await deferredAction.fulfill()
+        XCTAssertNil(context.alertInfo)
+    }
+}